CSSOM: Remove TODOs for implementing [LegacyArrayClass] on interfaces [chromium/src : master]

Chris Nardi (Gerrit)

unread,

Apr 23, 2018, 9:14:55 PM4/23/18

to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Philip Jägenstedt, Alexis Menard, chromium...@chromium.org, Joseph Medley, Kenneth Rohde Christiansen, Rob Buis, Yoav Weiss

PTAL.

View Change

To view, visit change 1025313. To unsubscribe, or for help writing mail filters, visit settings.

Chris Nardi (Gerrit)

unread,

Apr 23, 2018, 9:14:55 PM4/23/18

to Philip Jägenstedt, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Chris Nardi would like Philip Jägenstedt to review this change.

View Change

CSSOM: Remove TODOs for implementing [LegacyArrayClass] on interfaces

https://github.com/w3c/csswg-drafts/issues/2601 removed
[LegacyArrayClass] from the spec, so these TODOs are no longer needed.

Change-Id: I38e6c2b0cd726d3f8af75e1c3966f794d4487af5
---
M third_party/blink/renderer/core/css/css_rule_list.idl
M third_party/blink/renderer/core/css/media_list.idl
M third_party/blink/renderer/core/css/style_sheet_list.idl
3 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/third_party/blink/renderer/core/css/css_rule_list.idl b/third_party/blink/renderer/core/css/css_rule_list.idl
index f1656adc..1ed135b 100644
--- a/third_party/blink/renderer/core/css/css_rule_list.idl
+++ b/third_party/blink/renderer/core/css/css_rule_list.idl
@@ -25,7 +25,6 @@
 
 // https://drafts.csswg.org/cssom/#the-cssrulelist-interface
 
-// TODO(foolip): CSSRuleList should be an [ArrayClass].
 [
     Exposed=Window
 ] interface CSSRuleList {
diff --git a/third_party/blink/renderer/core/css/media_list.idl b/third_party/blink/renderer/core/css/media_list.idl
index 1980425..6b33f75 100644
--- a/third_party/blink/renderer/core/css/media_list.idl
+++ b/third_party/blink/renderer/core/css/media_list.idl
@@ -25,7 +25,6 @@
 
 // https://drafts.csswg.org/cssom/#the-medialist-interface
 
-// TODO(foolip): MediaList should be an [ArrayClass].
 [
     Exposed=Window
 ] interface MediaList {
diff --git a/third_party/blink/renderer/core/css/style_sheet_list.idl b/third_party/blink/renderer/core/css/style_sheet_list.idl
index a3572d3..163c8f1d 100644
--- a/third_party/blink/renderer/core/css/style_sheet_list.idl
+++ b/third_party/blink/renderer/core/css/style_sheet_list.idl
@@ -20,7 +20,6 @@
 
 // https://drafts.csswg.org/cssom/#the-stylesheetlist-interface
 
-// TODO(foolip): StyleSheetList should be an [ArrayClass].
 [
     RaisesException=Constructor,
     Constructor(sequence<CSSStyleSheet> sheets),

To view, visit change 1025313. To unsubscribe, or for help writing mail filters, visit settings.

Philip Jägenstedt (Gerrit)

unread,

Apr 24, 2018, 4:36:57 AM4/24/18

to Chris Nardi, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Alexis Menard, chromium...@chromium.org, Joseph Medley, Kenneth Rohde Christiansen, Rob Buis, Yoav Weiss

Thanks!

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 1025313. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Apr 24, 2018, 5:37:46 AM4/24/18

to Chris Nardi, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Philip Jägenstedt, Alexis Menard, chromium...@chromium.org, Joseph Medley, Kenneth Rohde Christiansen, Rob Buis, Yoav Weiss

Commit Bot merged this change.

View Change

Approvals:
  Philip Jägenstedt: Looks good to me; Commit

CSSOM: Remove TODOs for implementing [LegacyArrayClass] on interfaces

https://github.com/w3c/csswg-drafts/issues/2601 removed
[LegacyArrayClass] from the spec, so these TODOs are no longer needed.

Change-Id: I38e6c2b0cd726d3f8af75e1c3966f794d4487af5

Reviewed-on: https://chromium-review.googlesource.com/1025313
Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
Commit-Queue: Philip Jägenstedt <foo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553042}

Reply all

Reply to author

Forward