Make Position::LastPositionInNode() to take const Node& instead of Node* (issue 2962473002 by yosin@chromium.org)

0 views
Skip to first unread message

yosin@chromium.org via codereview.chromium.org

unread,
Jun 26, 2017, 4:06:35 AM6/26/17
to xiaoc...@chromium.org, yoi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, groby+bl...@chromium.org, timvo...@chromium.org, xiaoc...@chromium.org
Reviewers: Xiaocheng, yoichio
CL: https://codereview.chromium.org/2962473002/

Message:
PTAL

Description:
Make Position::LastPositionInNode() to take const Node& instead of Node*

This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.


This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&

instead of Node*


BUG=734849
TEST=n/a; no behavior changes


Affected files (+61, -61 lines):
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
M third_party/WebKit/Source/core/editing/EphemeralRange.cpp
M third_party/WebKit/Source/core/editing/Position.h
M third_party/WebKit/Source/core/editing/Position.cpp
M third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
M third_party/WebKit/Source/core/editing/PositionTest.cpp
M third_party/WebKit/Source/core/editing/SurroundingText.cpp
M third_party/WebKit/Source/core/editing/TextFinder.cpp
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
M third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp


xiaoc...@chromium.org

unread,
Jun 26, 2017, 1:49:00 PM6/26/17
to yo...@chromium.org, yoi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, groby+bl...@chromium.org, timvo...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 26, 2017, 9:16:13 PM6/26/17
to yo...@chromium.org, xiaoc...@chromium.org, yoi...@chromium.org, commi...@chromium.org, xiaoc...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, groby+bl...@chromium.org, timvo...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 26, 2017, 9:30:13 PM6/26/17
to yo...@chromium.org, xiaoc...@chromium.org, yoi...@chromium.org, commi...@chromium.org, xiaoc...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, groby+bl...@chromium.org, timvo...@chromium.org
Reply all
Reply to author
Forward
0 new messages