Replace 0 with nullptr using clang-tidy. [chromium/src : master]

[Ivan Kotenkov (Gerrit)]

I've recently started tinkering with clang-tidy and here is nullptr conversion for the whole blink. Is blink interested in this change?

View Change

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: comment

Gerrit-Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Gerrit-Change-Number: 720361

Gerrit-PatchSet: 3

Gerrit-Owner: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Jochen Eisinger <joc...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: Alice Boxhall <abox...@chromium.org>

Gerrit-CC: Commit Bot <commi...@chromium.org>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>

Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>

Gerrit-CC: Eric Willigers <ericwi...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Glenn Adams <gl...@chromium.org>

Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>

Gerrit-CC: Hayato Ito <hay...@chromium.org>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: James Zern <jz...@google.com>

Gerrit-CC: Javier Fernandez <jfern...@igalia.com>

Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Justin Novosad <ju...@chromium.org>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mads Ager <ag...@chromium.org>

Gerrit-CC: Manuel Rego Casasnovas <re...@igalia.com>

Gerrit-CC: Michael Nordman <mich...@chromium.org>

Gerrit-CC: Mikhail Pozdnyakov <mikhail.p...@intel.com>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Navid Zolghadr <nzol...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Pascal Massimino <sk...@google.com>

Gerrit-CC: Raymond Toy <rt...@chromium.org>

Gerrit-CC: Renée Wright <rjwr...@chromium.org>

Gerrit-CC: Rob Buis <rob....@samsung.com>

Gerrit-CC: Sergio Villar <svi...@igalia.com>

Gerrit-CC: Shane Stephens <sh...@chromium.org>

Gerrit-CC: Silvia Pfeiffer <silv...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Taiju Tsuiki <tz...@chromium.org>

Gerrit-CC: Tim Volodine <timvo...@chromium.org>

Gerrit-CC: Urvang Joshi <urv...@chromium.org>

Gerrit-CC: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-CC: Yoav Weiss <yo...@yoav.ws>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Comment-Date: Tue, 17 Oct 2017 07:31:47 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Jochen Eisinger (Gerrit)]

maybe ask on blink-dev?

Gerrit-Comment-Date: Tue, 17 Oct 2017 11:54:36 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Ivan Kotenkov (Gerrit)]

Patch Set 3:

maybe ask on blink-dev?

Thanks. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7MD5OQOI8G4

Gerrit-Comment-Date: Tue, 17 Oct 2017 12:22:39 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Nico Weber (Gerrit)]

Can you describe in enough detail in the Cl description how you ran clang-tidy that someone else can replicate this? Then I could do that and compare diffs instead of clicking through > 400 files.

Gerrit-Comment-Date: Tue, 17 Oct 2017 17:37:24 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Ivan Kotenkov (Gerrit)]

Ivan Kotenkov uploaded patch set #4 to this change.

View Change

Replace 0 with nullptr using clang-tidy.

Steps to replicate:
1. Build clang-tidy and clang-apply-replacements as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
2. Build blink in out/gn.
3. Generate the compilation database:
  tools/clang/scripts/generate_compdb.py -p out/gn > compile_commands.json
4. Run clang-tidy and apply replacements:
  cd out/gn && PATH_TO_RUN_CLANG_TIDY/run-clang-tidy.py -p ../../ -clang-tidy-binary PATH_TO_CLANG_TIDY_BINARY -clang-apply-replacements-binary PATH_TO_CLANG_APPLY_REPLACEMENTS_BINARY -checks=-*,hicpp-use-nullptr -fix -j 8 third_party/WebKit

BUG=403854

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571
---
M third_party/WebKit/Source/bindings/core/v8/ActivityLoggerTest.cpp
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptString.cpp
M third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFactory.cpp
M third_party/WebKit/Source/core/animation/Animation.cpp
M third_party/WebKit/Source/core/animation/AnimationTest.cpp
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
M third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp
M third_party/WebKit/Source/core/animation/EffectStackTest.cpp
M third_party/WebKit/Source/core/animation/KeyframeEffectModelTest.cpp
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
M third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.cpp
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
M third_party/WebKit/Source/core/css/CSSGroupingRule.cpp
M third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
M third_party/WebKit/Source/core/css/CSSSelector.cpp
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
M third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
M third_party/WebKit/Source/core/css/StyleRule.cpp
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
M third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp
M third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp
M third_party/WebKit/Source/core/css/parser/SizesAttributeParserTest.cpp
M third_party/WebKit/Source/core/css/parser/SizesCalcParserTest.cpp
M third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
M third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
M third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackground.cpp
M third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp
M third_party/WebKit/Source/core/css/resolver/SelectorFilterParentScope.cpp
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
M third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
M third_party/WebKit/Source/core/dom/ChildNodeList.cpp
M third_party/WebKit/Source/core/dom/ContainerNode.cpp
M third_party/WebKit/Source/core/dom/DOMException.cpp
M third_party/WebKit/Source/core/dom/Document.cpp
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
M third_party/WebKit/Source/core/dom/DocumentTest.cpp
M third_party/WebKit/Source/core/dom/Element.cpp
M third_party/WebKit/Source/core/dom/ElementShadow.cpp
M third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
M third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
M third_party/WebKit/Source/core/dom/PseudoElement.cpp
M third_party/WebKit/Source/core/dom/Range.cpp
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp
M third_party/WebKit/Source/core/dom/ShadowRoot.cpp
M third_party/WebKit/Source/core/dom/TreeOrderedList.cpp
M third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
M third_party/WebKit/Source/core/dom/TreeWalker.cpp
M third_party/WebKit/Source/core/dom/V0InsertionPoint.cpp
M third_party/WebKit/Source/core/dom/events/Event.cpp
M third_party/WebKit/Source/core/dom/events/EventPath.cpp
M third_party/WebKit/Source/core/editing/DOMSelection.cpp
M third_party/WebKit/Source/core/editing/EditingBehavior.cpp
M third_party/WebKit/Source/core/editing/EditingStyle.cpp
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp
M third_party/WebKit/Source/core/editing/Editor.cpp
M third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp
M third_party/WebKit/Source/core/editing/FrameSelection.cpp
M third_party/WebKit/Source/core/editing/InlineBoxPosition.cpp
M third_party/WebKit/Source/core/editing/KeyboardTest.cpp
M third_party/WebKit/Source/core/editing/Position.cpp
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp
M third_party/WebKit/Source/core/editing/ime/InputMethodController.cpp
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp
M third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
M third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
M third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
M third_party/WebKit/Source/core/exported/WebArrayBuffer.cpp
M third_party/WebKit/Source/core/exported/WebArrayBufferView.cpp
M third_party/WebKit/Source/core/exported/WebFrame.cpp
M third_party/WebKit/Source/core/exported/WebFrameTest.cpp
M third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
M third_party/WebKit/Source/core/exported/WebHelperPluginTest.cpp
M third_party/WebKit/Source/core/exported/WebInputElement.cpp
M third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
M third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
M third_party/WebKit/Source/core/exported/WebPluginDocument.cpp
M third_party/WebKit/Source/core/exported/WebViewTest.cpp
M third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
M third_party/WebKit/Source/core/fileapi/FileError.cpp
M third_party/WebKit/Source/core/fileapi/FileList.cpp
M third_party/WebKit/Source/core/fileapi/FileReader.cpp
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
M third_party/WebKit/Source/core/frame/Frame.cpp
M third_party/WebKit/Source/core/frame/FrameSerializerTest.cpp
M third_party/WebKit/Source/core/frame/History.cpp
M third_party/WebKit/Source/core/frame/LocalFrameView.cpp
M third_party/WebKit/Source/core/frame/MHTMLTest.cpp
M third_party/WebKit/Source/core/frame/SettingsDelegate.cpp
M third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
M third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
M third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
M third_party/WebKit/Source/core/html/HTMLCollection.cpp
M third_party/WebKit/Source/core/html/HTMLElement.cpp
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
M third_party/WebKit/Source/core/html/HTMLLIElement.cpp
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp
M third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp
M third_party/WebKit/Source/core/html/ImageDocument.cpp
M third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
M third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp
M third_party/WebKit/Source/core/html/forms/ColorChooserUIController.cpp
M third_party/WebKit/Source/core/html/forms/DateTimeChooserImpl.cpp
M third_party/WebKit/Source/core/html/forms/DateTimeEditElement.cpp
M third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
M third_party/WebKit/Source/core/html/forms/FormController.cpp
M third_party/WebKit/Source/core/html/forms/HTMLButtonElement.cpp
M third_party/WebKit/Source/core/html/forms/HTMLFormElement.cpp
M third_party/WebKit/Source/core/html/forms/InputType.cpp
M third_party/WebKit/Source/core/html/forms/KeyboardClickableInputTypeView.cpp
M third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
M third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
M third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
M third_party/WebKit/Source/core/html/media/HTMLMediaSource.cpp
M third_party/WebKit/Source/core/html/media/HTMLVideoElement.cpp
M third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp
M third_party/WebKit/Source/core/html/parser/HTMLEntitySearch.cpp
M third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.cpp
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParserTest.cpp
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp
M third_party/WebKit/Source/core/html/track/TextTrack.cpp
M third_party/WebKit/Source/core/html/track/TextTrackCue.cpp
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp
M third_party/WebKit/Source/core/input/EventHandler.cpp
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
M third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
M third_party/WebKit/Source/core/layout/HitTestResult.cpp
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
M third_party/WebKit/Source/core/layout/LayoutBox.cpp
M third_party/WebKit/Source/core/layout/LayoutButton.cpp
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
M third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
M third_party/WebKit/Source/core/layout/LayoutGeometryMapTest.cpp
M third_party/WebKit/Source/core/layout/LayoutImage.cpp
M third_party/WebKit/Source/core/layout/LayoutInline.cpp
M third_party/WebKit/Source/core/layout/LayoutObject.cpp
M third_party/WebKit/Source/core/layout/LayoutQuote.cpp
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
M third_party/WebKit/Source/core/layout/LayoutSearchField.cpp
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp
M third_party/WebKit/Source/core/layout/LayoutTable.cpp
M third_party/WebKit/Source/core/layout/LayoutText.cpp
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
M third_party/WebKit/Source/core/layout/LayoutVideo.cpp
M third_party/WebKit/Source/core/layout/LayoutView.cpp
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
M third_party/WebKit/Source/core/layout/line/TrailingObjects.cpp
M third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
M third_party/WebKit/Source/core/loader/CookieJar.cpp
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
M third_party/WebKit/Source/core/loader/FrameLoader.cpp
M third_party/WebKit/Source/core/loader/ImageLoader.cpp
M third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
M third_party/WebKit/Source/core/page/CreateWindow.cpp
M third_party/WebKit/Source/core/page/FocusController.cpp
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
M third_party/WebKit/Source/core/paint/FramePainter.cpp
M third_party/WebKit/Source/core/paint/GridPainter.cpp
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp
M third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
M third_party/WebKit/Source/core/paint/PaintLayer.cpp
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp
M third_party/WebKit/Source/core/paint/PaintLayerStackingNodeIterator.cpp
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
M third_party/WebKit/Source/core/paint/SelectionPaintingUtils.cpp
M third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
M third_party/WebKit/Source/core/paint/compositing/CompositingRequirementsUpdater.cpp
M third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
M third_party/WebKit/Source/core/style/ComputedStyle.cpp
M third_party/WebKit/Source/core/style/FillLayer.cpp
M third_party/WebKit/Source/core/style/FilterOperation.cpp
M third_party/WebKit/Source/core/style/ShadowList.cpp
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
M third_party/WebKit/Source/core/svg/SVGElement.cpp
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
M third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
M third_party/WebKit/Source/core/testing/InternalSettings.cpp
M third_party/WebKit/Source/core/testing/Internals.cpp
M third_party/WebKit/Source/core/testing/LayerRectList.cpp
M third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
M third_party/WebKit/Source/core/xml/XPathResult.cpp
M third_party/WebKit/Source/core/xml/XSLImportRule.cpp
M third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
M third_party/WebKit/Source/core/xml/XSLTUnicodeSort.cpp
M third_party/WebKit/Source/core/xml/parser/SharedBufferReaderTest.cpp
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp
M third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
M third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
M third_party/WebKit/Source/modules/canvas2d/CanvasGradient.cpp
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
M third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
M third_party/WebKit/Source/modules/crypto/CryptoKey.cpp
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
M third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp
M third_party/WebKit/Source/modules/exported/WebAXObject.cpp
M third_party/WebKit/Source/modules/fetch/RequestTest.cpp
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp
M third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
M third_party/WebKit/Source/modules/gamepad/GamepadList.cpp
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
M third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
M third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
M third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp
M third_party/WebKit/Source/modules/quota/StorageQuotaClient.cpp
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
M third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
M third_party/WebKit/Source/modules/webdatabase/Database.cpp
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
M third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp
M third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.cpp
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
M third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
M third_party/WebKit/Source/modules/webgl/WebGLSync.cpp
M third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.cpp
M third_party/WebKit/Source/platform/ContextMenu.cpp
M third_party/WebKit/Source/platform/Crypto.cpp
M third_party/WebKit/Source/platform/DragImageTest.cpp
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp
M third_party/WebKit/Source/platform/LinkHash.cpp
M third_party/WebKit/Source/platform/SharedBuffer.cpp
M third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp
M third_party/WebKit/Source/platform/audio/AudioBus.cpp
M third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp
M third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
M third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
M third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
M third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp
M third_party/WebKit/Source/platform/bindings/V8DOMActivityLogger.cpp
M third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
M third_party/WebKit/Source/platform/blob/BlobRegistry.cpp
M third_party/WebKit/Source/platform/exported/Platform.cpp
M third_party/WebKit/Source/platform/exported/WebCryptoAlgorithm.cpp
M third_party/WebKit/Source/platform/exported/WebCryptoKeyAlgorithm.cpp
M third_party/WebKit/Source/platform/exported/WebFont.cpp
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
M third_party/WebKit/Source/platform/exported/WebMediaStreamTrack.cpp
M third_party/WebKit/Source/platform/exported/WebPrerender.cpp
M third_party/WebKit/Source/platform/exported/WebPrerenderingSupport.cpp
M third_party/WebKit/Source/platform/exported/WebString.cpp
M third_party/WebKit/Source/platform/exported/WebThreadSafeData.cpp
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
M third_party/WebKit/Source/platform/fonts/Font.cpp
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp
M third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
M third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
M third_party/WebKit/Source/platform/geometry/Region.cpp
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
M third_party/WebKit/Source/platform/graphics/Color.cpp
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
M third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
M third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasResourceProvider.cpp
M third_party/WebKit/Source/platform/graphics/Path.cpp
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
M third_party/WebKit/Source/platform/graphics/StrokeData.cpp
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp
M third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
M third_party/WebKit/Source/platform/heap/HeapTest.cpp
M third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp
M third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp
M third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
M third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheTest.cpp
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
M third_party/WebKit/Source/platform/text/BidiContext.cpp
M third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
M third_party/WebKit/Source/platform/text/LocaleICU.cpp
M third_party/WebKit/Source/platform/text/LocaleICUTest.cpp
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
M third_party/WebKit/Source/platform/text/TextRun.cpp
M third_party/WebKit/Source/platform/text/UnicodeUtilitiesTest.cpp
M third_party/WebKit/Source/platform/transforms/TransformOperations.cpp
M third_party/WebKit/Source/platform/weborigin/KURL.cpp
M third_party/WebKit/Source/platform/weborigin/KURLTest.cpp
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
M third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
M third_party/WebKit/Source/platform/wtf/DataLog.cpp
M third_party/WebKit/Source/platform/wtf/DateMath.cpp
M third_party/WebKit/Source/platform/wtf/HashMapTest.cpp
M third_party/WebKit/Source/platform/wtf/StringHasherTest.cpp
M third_party/WebKit/Source/platform/wtf/TreeNodeTest.cpp
M third_party/WebKit/Source/platform/wtf/text/Base64.cpp
M third_party/WebKit/Source/platform/wtf/text/CStringTest.cpp
M third_party/WebKit/Source/platform/wtf/text/StringBuilderTest.cpp
M third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
M third_party/WebKit/Source/platform/wtf/text/StringToNumber.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecLatin1.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp
M third_party/WebKit/Source/platform/wtf/text/TextCodecUserDefined.cpp
M third_party/WebKit/Source/platform/wtf/text/TextEncodingRegistry.cpp
M third_party/WebKit/Source/platform/wtf/text/icu/CollatorICU.cpp
M third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBuffer.cpp
M third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayPiece.cpp
434 files changed, 1,564 insertions(+), 1,464 deletions(-)

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: newpatchset

Gerrit-Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Gerrit-Change-Number: 720361

Gerrit-PatchSet: 4

[Ivan Kotenkov (Gerrit)]

Patch Set 3:

Can you describe in enough detail in the Cl description how you ran clang-tidy that someone else can replicate this? Then I could do that and compare diffs instead of clicking through > 400 files.

Done. I didn't compile the tools exactly like it's described in the doc (I used the monorepo), but it should basically be the same. Then I fixed compilation errors, clang-format and wk-style.

Keep in mind that running clang-tidy on the whole blink takes a lot of time.

View Change

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: comment

Gerrit-Comment-Date: Tue, 17 Oct 2017 18:14:33 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Jochen Eisinger (Gerrit)]

Patch set 4:Code-Review +1

Gerrit-Comment-Date: Thu, 19 Oct 2017 07:30:24 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: Yes

[Kentaro Hara (Gerrit)]

LGTM 2

Patch set 4:Code-Review +1

View Change

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: comment

Gerrit-Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Gerrit-Change-Number: 720361

Gerrit-PatchSet: 4

Gerrit-Owner: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Jochen Eisinger <joc...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: Alice Boxhall <abox...@chromium.org>

Gerrit-CC: Commit Bot <commi...@chromium.org>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>

Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>

Gerrit-CC: Eric Willigers <ericwi...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Glenn Adams <gl...@chromium.org>

Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>

Gerrit-CC: Hayato Ito <hay...@chromium.org>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: James Zern <jz...@google.com>

Gerrit-CC: Javier Fernandez <jfern...@igalia.com>

Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Justin Novosad <ju...@chromium.org>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Mads Ager <ag...@chromium.org>

Gerrit-CC: Manuel Rego Casasnovas <re...@igalia.com>

Gerrit-CC: Michael Nordman <mich...@chromium.org>

Gerrit-CC: Mikhail Pozdnyakov <mikhail.p...@intel.com>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Navid Zolghadr <nzol...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Pascal Massimino <sk...@google.com>

Gerrit-CC: Raymond Toy <rt...@chromium.org>

Gerrit-CC: Renée Wright <rjwr...@chromium.org>

Gerrit-CC: Rob Buis <rob....@samsung.com>

Gerrit-CC: Sergio Villar <svi...@igalia.com>

Gerrit-CC: Shane Stephens <sh...@chromium.org>

Gerrit-CC: Silvia Pfeiffer <silv...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Taiju Tsuiki <tz...@chromium.org>

Gerrit-CC: Tim Volodine <timvo...@chromium.org>

Gerrit-CC: Urvang Joshi <urv...@chromium.org>

Gerrit-CC: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-CC: Yoav Weiss <yo...@yoav.ws>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Comment-Date: Thu, 19 Oct 2017 07:33:34 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: Yes

[Ivan Kotenkov (Gerrit)]

Patch set 5:Commit-Queue +2

View Change

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: comment

Gerrit-Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Gerrit-Change-Number: 720361

Gerrit-PatchSet: 5

Gerrit-Comment-Date: Thu, 19 Oct 2017 09:02:52 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: Yes

[Commit Bot (Gerrit)]

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/720361/5

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/720361/5

Bot data: {"action": "start", "triggered_at": "2017-10-19T09:02:52.0Z", "cq_cfg_revision": "2d3a62b279d3f647091bba3d1ee978f0ca0d8e45", "revision": "13c356c5f2f4c6df7db52f670a2dcdfcae9b3eb1"}

Gerrit-Comment-Date: Thu, 19 Oct 2017 09:03:02 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No

[Commit Bot (Gerrit)]

Commit Bot merged this change.

View Change

Approvals: Kentaro Hara: Looks good to me Jochen Eisinger: Looks good to me Ivan Kotenkov: Commit

Replace 0 with nullptr using clang-tidy.

Steps to replicate:
1. Build clang-tidy and clang-apply-replacements as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
2. Build blink in out/gn.
3. Generate the compilation database:
  tools/clang/scripts/generate_compdb.py -p out/gn > compile_commands.json
4. Run clang-tidy and apply replacements:
  cd out/gn && PATH_TO_RUN_CLANG_TIDY/run-clang-tidy.py -p ../../ -clang-tidy-binary PATH_TO_CLANG_TIDY_BINARY -clang-apply-replacements-binary PATH_TO_CLANG_APPLY_REPLACEMENTS_BINARY -checks=-*,hicpp-use-nullptr -fix -j 8 third_party/WebKit

BUG=403854

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Reviewed-on: https://chromium-review.googlesource.com/720361
Commit-Queue: Ivan Kotenkov <kote...@yandex-team.ru>
Reviewed-by: Jochen Eisinger <joc...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510054}

---
M third_party/WebKit/Source/bindings/core/v8/ActivityLoggerTest.cpp
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptString.cpp
M third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFactory.cpp
M third_party/WebKit/Source/core/animation/Animation.cpp
M third_party/WebKit/Source/core/animation/AnimationTest.cpp
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
M third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp
M third_party/WebKit/Source/core/animation/EffectStackTest.cpp

M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
M third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.cpp
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
M third_party/WebKit/Source/core/css/CSSGroupingRule.cpp
M third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
M third_party/WebKit/Source/core/css/CSSSelector.cpp
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
M third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
M third_party/WebKit/Source/core/css/StyleRule.cpp
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
M third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp
M third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp
M third_party/WebKit/Source/core/css/parser/SizesAttributeParserTest.cpp
M third_party/WebKit/Source/core/css/parser/SizesCalcParserTest.cpp
M third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
M third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

M third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIBackground.cpp
M third_party/WebKit/Source/core/css/properties/shorthands/CSSShorthandPropertyAPIBorderRadius.cpp

433 files changed, 1,563 insertions(+), 1,463 deletions(-)

To view, visit change 720361. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src

Gerrit-Branch: master

Gerrit-MessageType: merged

Gerrit-Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571

Gerrit-Change-Number: 720361

Gerrit-PatchSet: 6

Gerrit-Owner: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Commit Bot <commi...@chromium.org>

Gerrit-Reviewer: Ivan Kotenkov <kote...@yandex-team.ru>

Gerrit-Reviewer: Jochen Eisinger <joc...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: Alice Boxhall <abox...@chromium.org>