DevTools: auto-group console messages [chromium/src : master]

Erik Luo (Gerrit)

unread,

Oct 20, 2017, 9:46:52 PM10/20/17

to Dmitry Gozman, Pavel Feldman, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, devtools...@chromium.org, chromium...@chromium.org

Erik Luo uploaded patch set #4 to this change.

View Change

DevTools: auto-group console messages

Part 1 of a series to introduce coalescing groups.
New experiment called 'Group console logs automatically'
added.

Bug: 774694
Change-Id: I44beac80eb6b9cfa77209d97a611b947ab47be0e
---
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
M third_party/WebKit/Source/devtools/front_end/main/Main.js
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
4 files changed, 94 insertions(+), 6 deletions(-)

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Oct 20, 2017, 9:47:55 PM10/20/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org

Thanks for the help pfeldman@, I've only minorly changed code since your patch.
Styles will need to be fixed in the next CL..

Ptal

View Change

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Pavel Feldman (Gerrit)

unread,

Oct 21, 2017, 12:41:44 PM10/21/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org

Patch set 4:Code-Review +1

View Change

4 comments:

File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:
- Patch Set #2, Line 73:
  Don't use 'browser', it is misleading.
- Patch Set #2, Line 137: var settingsToolbarRight = new UI.Toolbar('', settingsPane.element);
  Your experiments are orthogonal.
File third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js:
- Patch Set #2, Line 558: isGroupable() {
  shouldGroupMessage()
- Patch Set #2, Line 560: this.source !== ConsoleModel.ConsoleMessage.MessageSource.ConsoleAPI &&
  MessageType is only there for ConsoleAPI Source, this check and the ones below don't make sense to me.

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Pavel Feldman (Gerrit)

unread,

Oct 21, 2017, 12:41:49 PM10/21/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org

Patch set 4:Commit-Queue +2

View Change

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 21, 2017, 2:00:55 PM10/21/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/571267)

View Change

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Pavel Feldman (Gerrit)

unread,

Oct 21, 2017, 2:10:05 PM10/21/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Commit Bot, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org

Patch set 4:Commit-Queue +2

View Change

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 21, 2017, 4:44:01 PM10/21/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Pavel Feldman: Looks good to me; Commit

DevTools: auto-group console messages

Part 1 of a series to introduce coalescing groups.
New experiment called 'Group console logs automatically'
added.

Bug: 774694
Change-Id: I44beac80eb6b9cfa77209d97a611b947ab47be0e

Reviewed-on: https://chromium-review.googlesource.com/730654
Reviewed-by: Pavel Feldman <pfel...@chromium.org>
Commit-Queue: Pavel Feldman <pfel...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510693}


---
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
M third_party/WebKit/Source/devtools/front_end/main/Main.js
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
4 files changed, 94 insertions(+), 6 deletions(-)

To view, visit change 730654. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward