Adds visual viewport size override to DevTools Emulation protocol. (issue 2173783002 by eseckler@chromium.org)

0 views
Skip to first unread message

esec...@chromium.org

unread,
Jul 22, 2016, 10:42:40 AM7/22/16
to dgo...@chromium.org, chromium...@chromium.org, mlamouri+wa...@chromium.org, caseq...@chromium.org, creis...@chromium.org, nasko+c...@chromium.org, j...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, dglazko...@chromium.org, dari...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, sergey...@chromium.org, blink-re...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org, bo...@chromium.org, skyo...@chromium.org, alexc...@google.com
Reviewers: dgozman
CL: https://codereview.chromium.org/2173783002/

Message:
Split off from crrev.com/2096633002.

Description:
Adds visual viewport size override to DevTools Emulation protocol.

This enables resizing of the visual viewport for (headless)
screenshots. For more information, see crbug.com/625577
and the design doc: bit.ly/viewport-screenshots.

We will add additional overrides for scroll/scale of viewports in
crrev.com/2096633002.

BUG=625577

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+345, -19 lines):
M content/browser/devtools/protocol/emulation_handler.h
M content/browser/devtools/protocol/emulation_handler.cc
M content/common/view_messages.h
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc
M content/renderer/render_view_browsertest.cc
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-visual-viewport-size.html
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-visual-viewport-size-expected.txt
M third_party/WebKit/Source/core/inspector/browser_protocol.json
M third_party/WebKit/public/web/WebDeviceEmulationParams.h


dgo...@chromium.org

unread,
Jul 25, 2016, 6:13:55 PM7/25/16
to esec...@chromium.org, chromium...@chromium.org, mlamouri+wa...@chromium.org, caseq...@chromium.org, creis...@chromium.org, nasko+c...@chromium.org, j...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, dglazko...@chromium.org, dari...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, sergey...@chromium.org, blink-re...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org, bo...@chromium.org, skyo...@chromium.org, alexc...@google.com
lgtm. Thanks for splitting this off.


https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h
File third_party/WebKit/public/web/WebDeviceEmulationParams.h (right):

https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h#newcode56
third_party/WebKit/public/web/WebDeviceEmulationParams.h:56: // Emulated
visual viewport size. |x == 0| or |y == 0| disables the override
nit: x, y -> width, height

https://codereview.chromium.org/2173783002/

esec...@chromium.org

unread,
Jul 26, 2016, 4:33:52 AM7/26/16
to dgo...@chromium.org, dch...@chromium.org, pfel...@chromium.org, chromium...@chromium.org, mlamouri+wa...@chromium.org, caseq...@chromium.org, creis...@chromium.org, nasko+c...@chromium.org, j...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, dglazko...@chromium.org, dari...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, sergey...@chromium.org, blink-re...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org, bo...@chromium.org, skyo...@chromium.org, alexc...@google.com
+dcheng for ipc change (view_messages.h).
+pfeldman for content/ and WebKit/public/.

Thanks!



https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h
File third_party/WebKit/public/web/WebDeviceEmulationParams.h (right):

https://codereview.chromium.org/2173783002/diff/1/third_party/WebKit/public/web/WebDeviceEmulationParams.h#newcode56
third_party/WebKit/public/web/WebDeviceEmulationParams.h:56: // Emulated
visual viewport size. |x == 0| or |y == 0| disables the override
On 2016/07/25 22:13:54, dgozman wrote:
> nit: x, y -> width, height

dch...@chromium.org

unread,
Jul 26, 2016, 7:05:03 AM7/26/16
to esec...@chromium.org, dgo...@chromium.org, pfel...@chromium.org, chromium...@chromium.org, mlamouri+wa...@chromium.org, caseq...@chromium.org, creis...@chromium.org, nasko+c...@chromium.org, j...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, dglazko...@chromium.org, dari...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, sergey...@chromium.org, blink-re...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org, bo...@chromium.org, skyo...@chromium.org, alexc...@google.com
Reply all
Reply to author
Forward
0 new messages