Framework and tests for WorkerNavigatorBudget (issue 2273743002 by harkness@chromium.org)

hark...@chromium.org

unread,

Aug 23, 2016, 12:11:03 PM8/23/16

to pe...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org

Reviewers: Peter Beverloo
CL: https://codereview.chromium.org/2273743002/

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
File
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
(right):

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html#newcode8
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:8:
<script src="../notifications/resources/test-helpers.js"></script>
I could also copy the helpers from notifications to budget, but it
seemed better to avoid the code duplication.

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl
(right):

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl#newcode5
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl:5: //
TODO(harkness): Update to WorkerNavigator partial interface
documentation.
I'm not sure why git is picking this up as a modified file rather than a
new file. I'll look into it.

Description:
Framework and tests for WorkerNavigatorBudget

This CL provides a Worker entrypoint for the BudgetAPI. The WorkerNavigator
partial interface provides a BudgetService object, which is the same for
both Navigator and WorkerNavigator.

BUG=617971

Base URL: https://chromium.googlesource.com/chromium/src.git@mojo_service

Affected files (+278, -2 lines):
A third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
A third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html
A third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html
A third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
A third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
A third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.cpp
A + third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl
M third_party/WebKit/Source/modules/modules.gypi

pe...@chromium.org

unread,

Aug 24, 2016, 11:28:24 AM8/24/16

to hark...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org

lgtm

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js#newcode10
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:10:
var options = event.data.options || {}
;

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js#newcode17
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:17:
cost: cost });
The alignment of this (and lines 23+, 31+, 39+ and 52+) is kind of odd.
Normally we align objects like:

port.postMessage({
command: event.data.command,
foo: 'bar'
});

or

port.postMessage({ command: event.data.command,
foo: 'bar' });

https://codereview.chromium.org/2273743002/

pe...@chromium.org

unread,

Aug 24, 2016, 11:31:18 AM8/24/16

to hark...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org

Sorry, two more IWYU comments:

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h#newcode8
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h:8:
#include "platform/Supplementable.h"
#include "platform/heap/GarbageCollected.h"
#include "wtf/Noncopyable.h"

https://codereview.chromium.org/2273743002/

hark...@chromium.org

unread,

Aug 24, 2016, 12:22:51 PM8/24/16

to pe...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js#newcode10
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:10:
var options = event.data.options || {}

On 2016/08/24 15:28:23, Peter Beverloo wrote:
> ;

Done.

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js#newcode17
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:17:
cost: cost });

On 2016/08/24 15:28:23, Peter Beverloo wrote:
> The alignment of this (and lines 23+, 31+, 39+ and 52+) is kind of
odd. Normally
> we align objects like:
>
> port.postMessage({
> command: event.data.command,
> foo: 'bar'
> });
>
> or
>
> port.postMessage({ command: event.data.command,
> foo: 'bar' });

Done.

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h#newcode8
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h:8:
#include "platform/Supplementable.h"

On 2016/08/24 15:31:04, Peter Beverloo wrote:
> #include "platform/heap/GarbageCollected.h"
> #include "wtf/Noncopyable.h"

Done.

https://codereview.chromium.org/2273743002/