Re: Loading: move core/fetch to platform/loader/fetch (issue 2584423002 by toyoshim@chromium.org)

kin...@chromium.org

unread,

Jan 16, 2017, 12:25:10 AM1/16/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, yo...@yoav.ws, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

https://codereview.chromium.org/2584423002/diff/60001/third_party/WebKit/Source/platform/BUILD.gn
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2584423002/diff/60001/third_party/WebKit/Source/platform/BUILD.gn#newcode1462
third_party/WebKit/Source/platform/BUILD.gn:1462:
"//third_party/WebKit/Source/platform/loader",
Would you be able to first just move all the files without making
structural changes in BUILD.gn (i.e. just add all files in this file) to
make this CL dedicated for simple file moving, and then create a
separate CL only for BUILD.gn changes?

https://codereview.chromium.org/2584423002/

kin...@chromium.org

unread,

Jan 16, 2017, 12:27:01 AM1/16/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, yo...@yoav.ws, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

Also please make extra sure that all the stakeholders are happy with this bulk
file moving.

https://codereview.chromium.org/2584423002/

bre...@chromium.org

unread,

Jan 16, 2017, 5:50:31 PM1/16/17

to toyoshi...@chromium.org, har...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, yo...@yoav.ws, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

This looks fairly straightforward to me. Unless you're having specific problems,
I think a normal third_party/WebKit reviewer should be review it.

https://codereview.chromium.org/2584423002/

toyo...@chromium.org

unread,

Jan 17, 2017, 8:51:48 AM1/17/17

to har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, tyos...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, yo...@yoav.ws, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

I added all OWNERS of core/fetch to reviewers list just in case.

I have submitted sub-patches to make loader unit tests work under platform, and
now I'm working on the last piece, ResourceFetcherTest. Also brettw@ says this
BUILD.gn change is straightforward thing. So, I think this main patch is ready
to start reviews by fetch/OWNERS.

https://codereview.chromium.org/2584423002/diff/60001/third_party/WebKit/Source/platform/BUILD.gn
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2584423002/diff/60001/third_party/WebKit/Source/platform/BUILD.gn#newcode1462
third_party/WebKit/Source/platform/BUILD.gn:1462:
"//third_party/WebKit/Source/platform/loader",

Thanks. Since now brettw@ says this is straightforward change, let me
keep this as is.

brettw@
Thank you for replying. My concerns (you asked in chat) were
- Is it reasonable to have a split BUILD.gn file under platform
- Do I pick up necessary and sufficient import gnis in loader/BUILD.gn
correctly

https://codereview.chromium.org/2584423002/

yo...@yoav.ws

unread,

Jan 17, 2017, 9:36:35 AM1/17/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, tyos...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

On 2017/01/17 13:51:48, toyoshim wrote:
> I added all OWNERS of core/fetch to reviewers list just in case.

I'd love to hear japhet@'s opinion on this change before landing (don't have a
strong opinion myself, but I know he did a lot of work on the loader/fetch
boundaries)

https://codereview.chromium.org/2584423002/

bre...@chromium.org

unread,

Jan 17, 2017, 4:19:39 PM1/17/17

to toyoshi...@chromium.org, har...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, tyos...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

I like split build files (smaller things closer to code are better). It works if
the dependencies go one way (one component includes headers from the other, but
not vice-versa).

But if the dependencies aren't clear it can get tricky and it's probably worse
than keeping it all together. This happens if both components include headers
from the other. Then there's no clear ordering for compilation.

https://codereview.chromium.org/2584423002/

yhi...@chromium.org

unread,

Jan 18, 2017, 12:44:04 AM1/18/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, tyos...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

Just in case, I'm fine with the overall direction.

https://codereview.chromium.org/2584423002/

kou...@chromium.org

unread,

Jan 18, 2017, 2:26:22 AM1/18/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kin...@chromium.org, tyos...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

LGTM
I'm also on-board w/ this plan.

https://codereview.chromium.org/2584423002/

tyos...@chromium.org

unread,

Jan 18, 2017, 2:57:13 AM1/18/17

to toyoshi...@chromium.org, har...@chromium.org, bre...@chromium.org, yhi...@chromium.org, kouhei+...@chromium.org, kin...@chromium.org, mk...@chromium.org, jap...@chromium.org, chromium...@chromium.org, szager+la...@chromium.org, tz...@chromium.org, webcomponen...@chromium.org, dongseo...@intel.com, eae+bli...@chromium.org, f...@opera.com, eric.c...@apple.com, leviw+re...@chromium.org, dominicc+...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, rob....@samsung.com, jsbell+ser...@chromium.org, dsch...@chromium.org, awdf+...@chromium.org, servicewor...@chromium.org, yhiran...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, ju...@chromium.org, aba...@chromium.org, blink-re...@chromium.org, dglazko...@chromium.org, caba...@adobe.com, blink-revie...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, gyuyou...@chromium.org, falken...@chromium.org, pdr+svgw...@chromium.org, blink-work...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, pe...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, sigb...@opera.com, caseq...@chromium.org, nhi...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, alexis...@intel.com, har...@chromium.org, loading-re...@chromium.org, dche...@chromium.org, jap...@chromium.org, vcar...@chromium.org, mich...@chromium.org, shimazu+se...@chromium.org, tyoshin...@chromium.org, gavinp+p...@chromium.org, ajuma+wat...@chromium.org, tfa...@chromium.org, pdr+renderi...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, shimazu...@chromium.org, pfeldma...@chromium.org, fma...@chromium.org, horo+...@chromium.org, sche...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org

me too fine with the refactoring.

https://codereview.chromium.org/2584423002/

mk...@chromium.org

unread,

Jan 18, 2017, 5:24:33 AM1/18/17

to toyoshi...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jap...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

LGTM, FWIW.

https://codereview.chromium.org/2584423002/

kin...@chromium.org

unread,

Jan 18, 2017, 8:28:49 AM1/18/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jap...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

lgtm/2, fwiw.

https://codereview.chromium.org/2584423002/

jap...@chromium.org

unread,

Jan 18, 2017, 5:03:48 PM1/18/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

On 2017/01/18 13:28:49, kinuko wrote:
> lgtm/2, fwiw.

I only skimmed the patch, but have another LGTM.

https://codereview.chromium.org/2584423002/

toyo...@chromium.org

unread,

Jan 24, 2017, 1:07:20 AM1/24/17

to mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Now the last sub-patch to make all tests work under platform was submitted.
I'd try submitting the patch set 5 via CQ.

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 1:23:14 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/100001

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 1:28:08 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:
ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/26303)
ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/30220)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 2:03:07 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/120001

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 3:20:51 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:

win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/335104)

https://codereview.chromium.org/2584423002/

yhi...@chromium.org

unread,

Jan 24, 2017, 3:25:58 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

lgtm

https://codereview.chromium.org/2584423002/

toyo...@chromium.org

unread,

Jan 24, 2017, 3:45:39 AM1/24/17

to mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Hum... on linux_chromium_asan_rel_ng, all ResourceFetcherTest are failing with
the following check failure.
Is this bot running under a special isolated environment that can not allow
accessing to files for testing?

[971:971:0123/234353.815911:15152552263:FATAL:weburl_loader_mock_factory_impl.cc(48)]
Check failed: base::PathExists(response_info.file_path).
/b/s/w/irsYaUnC/third_party/WebKit/Source/web/tests/data/white-1x1.png does not
exist.

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 4:03:32 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/140001

https://codereview.chromium.org/2584423002/

toyo...@chromium.org

unread,

Jan 24, 2017, 4:21:48 AM1/24/17

to mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Probably, I should include "web/tests/data/" in
group("blink_platform_unittests_data") to work it as is.
I will add this dependency in this CL, and create a followup CL that remove this
dependency (since it will need some non-mechanical code changes)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 4:27:54 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/160001

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 5:10:43 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:

win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/157497)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 5:33:04 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/180001

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 6:29:17 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:

win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/335200)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 6:30:31 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584423002/200001

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 7:12:55 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:

cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/296843)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 8:22:33 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 9:02:10 AM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:
cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,

http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/296916)

https://codereview.chromium.org/2584423002/

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 12:00:18 PM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

commit-bot@chromium.org via codereview.chromium.org

unread,

Jan 24, 2017, 12:37:30 PM1/24/17

to toyoshi...@chromium.org, mk...@chromium.org, bre...@chromium.org, har...@chromium.org, jap...@chromium.org, kin...@chromium.org, kouhei+...@chromium.org, tyos...@chromium.org, yhi...@chromium.org, commi...@chromium.org, aba...@chromium.org, ajuma+wat...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, awdf+...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-work...@chromium.org, caba...@adobe.com, caseq...@chromium.org, chromium...@chromium.org, dche...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dominicc+...@chromium.org, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, eric.c...@apple.com, falken...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp...@chromium.org, gavinp+p...@chromium.org, gl...@chromium.org, gyuyou...@chromium.org, har...@chromium.org, horo+...@chromium.org, jchaffraix...@chromium.org, jsbell+ser...@chromium.org, ju...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loading-rev...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, lushnik...@chromium.org, mich...@chromium.org, nhi...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pe...@chromium.org, pfeldma...@chromium.org, rob....@samsung.com, sche...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sigb...@opera.com, silv...@chromium.org, szager+la...@chromium.org, tfa...@chromium.org, tyoshin...@chromium.org, tz...@chromium.org, vcar...@chromium.org, webcomponen...@chromium.org, yhiran...@chromium.org, zol...@webkit.org

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc

https://codereview.chromium.org/2584423002/

Reply all

Reply to author

Forward