Rename WebFrameImpl to WebLocalFrameImpl. (issue 241303002)

0 views
Skip to first unread message

dch...@chromium.org

unread,
Apr 17, 2014, 2:42:58 PM4/17/14
to ese...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
Reviewers: eseidel,

Message:
More or less just a rename.

Description:
Rename WebFrameImpl to WebLocalFrameImpl.

WebFrameImpl is going to be the concrete implementation of WebLocalFrame
going forward. A followup patch will introduce its counterpart for
remote frames, WebRemoteFrameImpl.

BUG=346764

Please review this at https://codereview.chromium.org/241303002/

SVN Base: svn://svn.chromium.org/blink/trunk

Affected files (+482, -2833 lines):
M Source/web/AssociatedURLLoader.h
M Source/web/AssociatedURLLoader.cpp
M Source/web/ChromeClientImpl.cpp
M Source/web/ColorChooserUIController.cpp
M Source/web/ContextFeaturesClientImpl.cpp
M Source/web/ContextMenuClientImpl.cpp
M Source/web/DatabaseClientImpl.cpp
M Source/web/EditorClientImpl.cpp
M Source/web/FrameLoaderClientImpl.h
M Source/web/FrameLoaderClientImpl.cpp
M Source/web/IndexedDBClientImpl.cpp
M Source/web/LinkHighlight.cpp
M Source/web/LocalFileSystemClient.cpp
M Source/web/MediaKeysClientImpl.cpp
M Source/web/SharedWorkerRepositoryClientImpl.cpp
M Source/web/StorageClientImpl.cpp
M Source/web/StorageQuotaClientImpl.cpp
M Source/web/TextFinder.h
M Source/web/TextFinder.cpp
M Source/web/WebDOMFileSystem.cpp
M Source/web/WebDOMMessageEvent.cpp
M Source/web/WebDevToolsAgentImpl.h
M Source/web/WebDevToolsAgentImpl.cpp
M Source/web/WebDevToolsAgentPrivate.h
M Source/web/WebDevToolsFrontendImpl.cpp
M Source/web/WebDocument.cpp
M Source/web/WebEmbeddedWorkerImpl.cpp
D Source/web/WebFrameImpl.h
D Source/web/WebFrameImpl.cpp
M Source/web/WebHelperPluginImpl.h
M Source/web/WebHelperPluginImpl.cpp
A + Source/web/WebLocalFrameImpl.h
A + Source/web/WebLocalFrameImpl.cpp
M Source/web/WebMediaPlayerClientImpl.cpp
M Source/web/WebNode.cpp
M Source/web/WebPageSerializer.cpp
M Source/web/WebPageSerializerImpl.h
M Source/web/WebPageSerializerImpl.cpp
M Source/web/WebRange.cpp
M Source/web/WebSharedWorkerImpl.cpp
M Source/web/WebViewImpl.h
M Source/web/WebViewImpl.cpp
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp
M Source/web/tests/CompositedLayerMappingTest.cpp
M Source/web/tests/CustomEventTest.cpp
M Source/web/tests/FrameLoaderClientImplTest.cpp
M Source/web/tests/FrameTestHelpers.h
M Source/web/tests/FrameTestHelpers.cpp
M Source/web/tests/LinkHighlightTest.cpp
M Source/web/tests/PageSerializerTest.cpp
M Source/web/tests/PopupMenuTest.cpp
M Source/web/tests/ProgrammaticScrollTest.cpp
M Source/web/tests/RenderTableCellTest.cpp
M Source/web/tests/RenderTableRowTest.cpp
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp
M Source/web/tests/WebFrameTest.cpp
M Source/web/tests/WebPluginContainerTest.cpp
M Source/web/tests/WebViewTest.cpp
M Source/web/web.gypi
M public/web/WebFrame.h


dch...@chromium.org

unread,
Apr 18, 2014, 1:46:53 PM4/18/14
to ese...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
+abarth, because I can't seem to find Eric atm.

https://codereview.chromium.org/241303002/

ese...@chromium.org

unread,
Apr 18, 2014, 2:22:20 PM4/18/14
to dch...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
I support this product and or service.

rslgtm.

https://codereview.chromium.org/241303002/

commi...@chromium.org

unread,
Apr 18, 2014, 2:59:19 PM4/18/14
to dch...@chromium.org, ese...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dch...@chromium.org/241303002/10001


https://codereview.chromium.org/241303002/

commi...@chromium.org

unread,
Apr 18, 2014, 3:41:10 PM4/18/14
to dch...@chromium.org, ese...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
Try jobs failed on following builders:
tryserver.blink on mac_blink_rel

https://codereview.chromium.org/241303002/

commi...@chromium.org

unread,
Apr 18, 2014, 6:22:17 PM4/18/14
to dch...@chromium.org, ese...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dch...@chromium.org/241303002/30001


https://codereview.chromium.org/241303002/

commi...@chromium.org

unread,
Apr 18, 2014, 7:27:22 PM4/18/14
to dch...@chromium.org, ese...@chromium.org, aba...@chromium.org, blink-...@chromium.org, tz...@chromium.org, eric.c...@apple.com, apavlo...@chromium.org, aandre...@chromium.org, jam...@chromium.org, caseq...@chromium.org, malch...@chromium.org, yurys...@chromium.org, aba...@chromium.org, dglazko...@chromium.org, devtools...@chromium.org, loislo...@chromium.org, phi...@opera.com, nhi...@chromium.org, kin...@chromium.org, eustas...@chromium.org, pauliris...@chromium.org, lushnik...@chromium.org, feature-me...@chromium.org, alph+...@chromium.org, vsevik...@chromium.org, pfeldma...@chromium.org, groby+bl...@chromium.org
Change committed as 171986

https://codereview.chromium.org/241303002/
Reply all
Reply to author
Forward
0 new messages