Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (issue 2382653006 by dcheng@chromium.org)

esp...@chromium.org

unread,

Sep 30, 2016, 11:29:03 PM9/30/16

to dcheng...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dsch...@chromium.org, eae+bli...@chromium.org, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gyuyou...@chromium.org, je_jul...@chromium.org, kenneth.ch...@gmail.com, kinuko...@chromium.org, kouhe...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sh...@chromium.org, sigb...@opera.com, yo...@yoav.ws

lgtm

https://codereview.chromium.org/2382653006/

dch...@chromium.org

unread,

Sep 30, 2016, 11:31:40 PM9/30/16

to esp...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dsch...@chromium.org, eae+bli...@chromium.org, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gyuyou...@chromium.org, je_jul...@chromium.org, kenneth.ch...@gmail.com, kinuko...@chromium.org, kouhe...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sh...@chromium.org, sigb...@opera.com, yo...@yoav.ws, alanc...@chromium.org, joc...@chromium.org, tim...@chromium.org

Reviewers: esprehn
CL: https://codereview.chromium.org/2382653006/

Message:
CCing original reviewers.

Cloned from https://codereview.chromium.org/2346193002.

PS1 -> PS2 is auto rebase over the reformat commit (no merge conflicts)
PS2 -> PS3 is clang-format reformat for new code
PS3 -> PS4 is some brace fixes to make check-webkit-style happy

Description:
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)

Affected files (+2645, -2631 lines):
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
M third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
M third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp
M third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp
M third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h
M third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
M third_party/WebKit/Source/core/css/BUILD.gn
M third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
M third_party/WebKit/Source/core/css/CSSBasicShapeValues.h
M third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp
M third_party/WebKit/Source/core/css/CSSBorderImageSliceValue.h
M third_party/WebKit/Source/core/css/CSSCalculationValue.cpp
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
M third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
M third_party/WebKit/Source/core/css/CSSCounterValue.h
M third_party/WebKit/Source/core/css/CSSGradientValue.h
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp
A third_party/WebKit/Source/core/css/CSSIdentifierValue.h
A third_party/WebKit/Source/core/css/CSSIdentifierValue.cpp
M third_party/WebKit/Source/core/css/CSSMatrix.cpp
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
M third_party/WebKit/Source/core/css/CSSQuadValue.h
M third_party/WebKit/Source/core/css/CSSReflectValue.h
M third_party/WebKit/Source/core/css/CSSReflectValue.cpp
M third_party/WebKit/Source/core/css/CSSShadowValue.h
M third_party/WebKit/Source/core/css/CSSShadowValue.cpp
M third_party/WebKit/Source/core/css/CSSValue.h
M third_party/WebKit/Source/core/css/CSSValue.cpp
M third_party/WebKit/Source/core/css/CSSValuePool.h
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
M third_party/WebKit/Source/core/css/FontFace.cpp
M third_party/WebKit/Source/core/css/MediaQueryExp.cpp
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
M third_party/WebKit/Source/core/css/StylePropertySet.cpp
M third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
M third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
M third_party/WebKit/Source/core/dom/Element.cpp
M third_party/WebKit/Source/core/dom/TextLinkColors.cpp
M third_party/WebKit/Source/core/editing/EditingStyle.cpp
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
M third_party/WebKit/Source/web/WebAXObject.cpp

commit-bot@chromium.org via codereview.chromium.org

unread,

Sep 30, 2016, 11:32:04 PM9/30/16

to dcheng...@chromium.org, esp...@chromium.org, commi...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dsch...@chromium.org, eae+bli...@chromium.org, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gyuyou...@chromium.org, je_jul...@chromium.org, kenneth.ch...@gmail.com, kinuko...@chromium.org, kouhe...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sh...@chromium.org, sigb...@opera.com, yo...@yoav.ws, alanc...@chromium.org, joc...@chromium.org, tim...@chromium.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382653006/60001

https://codereview.chromium.org/2382653006/

commit-bot@chromium.org via codereview.chromium.org

unread,

Oct 1, 2016, 2:03:45 AM10/1/16

to dcheng...@chromium.org, esp...@chromium.org, commi...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dsch...@chromium.org, eae+bli...@chromium.org, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gyuyou...@chromium.org, je_jul...@chromium.org, kenneth.ch...@gmail.com, kinuko...@chromium.org, kouhe...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sh...@chromium.org, sigb...@opera.com, yo...@yoav.ws, alanc...@chromium.org, joc...@chromium.org, tim...@chromium.org

Committed patchset #4 (id:60001)

https://codereview.chromium.org/2382653006/

commit-bot@chromium.org via codereview.chromium.org

unread,

Oct 1, 2016, 2:05:45 AM10/1/16

to dcheng...@chromium.org, esp...@chromium.org, commi...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dsch...@chromium.org, eae+bli...@chromium.org, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gyuyou...@chromium.org, je_jul...@chromium.org, kenneth.ch...@gmail.com, kinuko...@chromium.org, kouhe...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sh...@chromium.org, sigb...@opera.com, yo...@yoav.ws, alanc...@chromium.org, joc...@chromium.org, tim...@chromium.org

Patchset 4 (id:??) landed as
https://crrev.com/90e5a7289784dc5a491a7f1e3a87f30a1eb0bbad
Cr-Commit-Position: refs/heads/master@{#422305}

https://codereview.chromium.org/2382653006/

Reply all

Reply to author

Forward