Add a comment explaining why ResourceFetcher::PrepareRequest() needs to use ResourceRequest::GetRedirectStatus() [chromium/src : master]

Takeshi Yoshino (Gerrit)

unread,

Aug 18, 2017, 8:28:53 AM8/18/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tyoshin...@chromium.org, Yutaka Hirano, chromium...@chromium.org, Nate Chapin

This change is ready for review.

View Change

To view, visit change 620514. To unsubscribe, or for help writing mail filters, visit settings.

Yutaka Hirano (Gerrit)

unread,

Aug 21, 2017, 8:25:47 AM8/21/17

to Takeshi Yoshino, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tyoshin...@chromium.org, Yutaka Hirano, chromium...@chromium.org, Nate Chapin

Patch set 1:Code-Review +1

View Change

To view, visit change 620514. To unsubscribe, or for help writing mail filters, visit settings.

Takeshi Yoshino (Gerrit)

unread,

Aug 22, 2017, 12:55:29 AM8/22/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tyoshin...@chromium.org, Yutaka Hirano, chromium...@chromium.org, Nate Chapin

Patch set 2:Commit-Queue +2

View Change

To view, visit change 620514. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 22, 2017, 12:55:48 AM8/22/17

to Takeshi Yoshino, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tyoshin...@chromium.org, Yutaka Hirano, chromium...@chromium.org, Nate Chapin

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/620514/2

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/620514/2

Bot data: {"action": "start", "triggered_at": "2017-08-22T04:55:24.0Z", "cq_cfg_revision": "81f1a3f0cb07446abeff7dd01ff1b8bae94ffe0d", "revision": "25d837ae6206039a7bbe587312907109ae741a67"}

View Change

To view, visit change 620514. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 22, 2017, 2:39:59 AM8/22/17

to Takeshi Yoshino, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tyoshin...@chromium.org, Yutaka Hirano, chromium...@chromium.org, Nate Chapin

Commit Bot merged this change.

View Change

Approvals:
  Yutaka Hirano: Looks good to me
  Takeshi Yoshino: Commit

Add a comment explaining why ResourceFetcher::PrepareRequest() needs to use ResourceRequest::GetRedirectStatus()

Bug: 665766
Change-Id: Iec7a76fcd49d39d32197a5df1ea307ea095d3253
Reviewed-on: https://chromium-review.googlesource.com/620514
Commit-Queue: Takeshi Yoshino <tyos...@chromium.org>
Reviewed-by: Yutaka Hirano <yhi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496234}
---
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
1 file changed, 5 insertions(+), 0 deletions(-)

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
index aad8129..f484bd7 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
@@ -556,6 +556,11 @@
           ? SecurityViolationReportingPolicy::kSuppressReporting
           : SecurityViolationReportingPolicy::kReport;
 
+  // Note that resource_request.GetRedirectStatus() may return kFollowedRedirect
+  // here since e.g. DocumentThreadableLoader may create a new Resource from
+  // a ResourceRequest that originates from the ResourceRequest passed to
+  // the redirect handling callback.
+
   // Before modifying the request for CSP, evaluate report-only headers. This
   // allows site owners to learn about requests that are being modified
   // (e.g. mixed content that is being upgraded by upgrade-insecure-requests).

To view, visit change 620514. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward