Rename 'WebKit Linux' to 'WebKit Linux Precise' (issue 2347293003 by jeffcarp@chromium.org)

0 views
Skip to first unread message

jeff...@chromium.org

unread,
Sep 16, 2016, 6:06:39 PM9/16/16
to jeff...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dpr...@chromium.org
Reviewers:
CL: https://codereview.chromium.org/2347293003/

Description:
Rename 'WebKit Linux' to 'WebKit Linux Precise'

BUG=613305

Affected files (+55, -55 lines):
M testing/buildbot/chromium.webkit.json
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py
M tools/mb/mb_config.pyl


qyea...@chromium.org

unread,
Sep 16, 2016, 6:16:12 PM9/16/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dpr...@chromium.org
Can't see any problems; I assume you searched for all instances of "WebKit
Linux" being used, these are the instances in src?

https://codereview.chromium.org/2347293003/

dpr...@chromium.org

unread,
Sep 16, 2016, 6:39:57 PM9/16/16
to jeff...@chromium.org, qyea...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Almost good, but see my important comments on
https://codereview.chromium.org/2338293005/ .


https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py
(right):

https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py#newcode38
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38:
'WebKit Linux Precise' : {
Ideally we'd change these test cases to refer to a totally fake builder,
so that we didn't have to change the tests when we change real
revisions.

https://codereview.chromium.org/2347293003/

jeff...@chromium.org

unread,
Sep 21, 2016, 3:21:51 PM9/21/16
to dpr...@chromium.org, qyea...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dpr...@chromium.org

https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py
(right):

https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py#newcode38
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38:
'WebKit Linux Precise' : {
On 2016/09/16 at 22:39:57, Dirk Pranke wrote:
> Ideally we'd change these test cases to refer to a totally fake
builder, so that we didn't have to change the tests when we change real
revisions.

That sounds good but sounds like it should be in a separate CL. Should I
revert this file or leave it as-is so it matches the new WebKit Precise
bots?

https://codereview.chromium.org/2347293003/

dpr...@chromium.org

unread,
Sep 21, 2016, 5:17:14 PM9/21/16
to jeff...@chromium.org, qyea...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Matching the new stuff is probably better.

https://codereview.chromium.org/2347293003/

qyea...@chromium.org

unread,
Sep 29, 2016, 4:31:46 PM9/29/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
The CL description here could be updated now that CL # 1 is closed in favor of
these two:
https://codereview.chromium.org/2382863002 (build/masters/...)
https://codereview.chromium.org/2382723004 (build/scripts/slave/...)


https://codereview.chromium.org/2347293003/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2347293003/diff/1/tools/mb/mb_config.pyl#newcode263
tools/mb/mb_config.pyl:263: 'WebKit Linux Precise - WPTServe':
'swarming_gn_release_bot',
Now these two lines can be reverted to how they were.

https://codereview.chromium.org/2347293003/

qyea...@chromium.org

unread,
Sep 29, 2016, 4:33:22 PM9/29/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
On 2016/09/29 at 20:31:46, qyearsley wrote:
> The CL description here could be updated now that CL # 1 is closed in favor of
these two:
> https://codereview.chromium.org/2382863002 (build/masters/...)
> https://codereview.chromium.org/2382723004 (build/scripts/slave/...)
>

Also: the CL title/description could note that (a) multiple builders are being
renamed (b) this CL should include all changes in the src repo.


https://codereview.chromium.org/2347293003/

qyea...@chromium.org

unread,
Sep 30, 2016, 1:48:26 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
LGTM -- Note, I believe that the WebKit Linux Precise builders are currently red
because mb_config.pyl needs to be updated; I expect that they should be green
after landing this. This CL needs LGTM from Dirk as well before passing the
OWNERS check.

https://codereview.chromium.org/2347293003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 2:21:08 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 3:26:07 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303020)

https://codereview.chromium.org/2347293003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 3:48:02 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 4:10:29 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
CQ is trying da patch. Follow status at

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 7:16:49 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 7:18:27 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 9:27:58 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 9:30:26 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

dpr...@chromium.org

unread,
Sep 30, 2016, 10:26:18 PM9/30/16
to jeff...@chromium.org, qyea...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 11:07:24 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 11:08:34 PM9/30/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 12:35:54 AM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 12:37:10 AM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 2:12:51 AM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 2:17:51 AM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 5:28:42 AM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 3:45:56 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 5:55:56 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 6:01:53 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 6:23:26 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 7:03:25 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 8:06:49 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 8:17:41 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 9:12:59 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 9:13:39 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 9:56:28 PM10/1/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Exceeded global retry quota

https://codereview.chromium.org/2347293003/

qyea...@chromium.org

unread,
Oct 2, 2016, 1:27:29 PM10/2/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
CQ is failing because some tests are failing at ToT; this is blocked on
http://crrev.com/652014.

https://codereview.chromium.org/2347293003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 3, 2016, 11:52:10 AM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 3, 2016, 12:59:28 PM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

qyea...@chromium.org

unread,
Oct 3, 2016, 5:16:47 PM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
On 2016/10/03 at 16:59:28, commit-bot wrote:
> Exceeded global retry quota

Last remaining CQ failure (mac_chromium_rel_ng) *still* looks unrelated to this
CL.

https://codereview.chromium.org/2347293003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 3, 2016, 6:52:10 PM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 3, 2016, 6:58:54 PM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Committed patchset #3 (id:40001)

https://codereview.chromium.org/2347293003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 3, 2016, 7:03:21 PM10/3/16
to jeff...@chromium.org, dpr...@chromium.org, qyea...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Patchset 3 (id:??) landed as
https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb
Cr-Commit-Position: refs/heads/master@{#422581}

https://codereview.chromium.org/2347293003/

jeff...@chromium.org

unread,
Oct 3, 2016, 7:32:00 PM10/3/16
to dpr...@chromium.org, qyea...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
On 2016/10/03 at 23:03:20, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb
> Cr-Commit-Position: refs/heads/master@{#422581}

Reply all
Reply to author
Forward
0 new messages