DevTools: remove unused css in objectValue.css (issue 2435153003 by luoe@chromium.org)

0 views
Skip to first unread message

lu...@chromium.org

unread,
Oct 20, 2016, 8:58:23 PM10/20/16
to lush...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Reviewers: lushnikov
CL: https://codereview.chromium.org/2435153003/

Description:
DevTools: remove unused css in objectValue.css

Affected files (+2, -38 lines):
M third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
M third_party/WebKit/Source/devtools/front_end/components/objectValue.css


Index: third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
index 310ee14499f638fb1d5657e2f930edc94e6e32a8..1be49617fb0b42dd9adf74eeef0b314caaafae13 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
@@ -154,7 +154,6 @@ WebInspector.RemoteObjectPreviewFormatter.prototype = {
}

if (type === "object" && subtype === "node" && description) {
- span.classList.add("object-value-preview-node");
WebInspector.DOMPresentationUtils.createSpansForNodeTitle(span, description);
return span;
}
Index: third_party/WebKit/Source/devtools/front_end/components/objectValue.css
diff --git a/third_party/WebKit/Source/devtools/front_end/components/objectValue.css b/third_party/WebKit/Source/devtools/front_end/components/objectValue.css
index 395cfcdafb9d22ff9abf32f0d60e5ab5c1c43dc7..49a9ed46a836c05d0b72e2a8ad75e058205bdda7 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/objectValue.css
+++ b/third_party/WebKit/Source/devtools/front_end/components/objectValue.css
@@ -23,7 +23,8 @@
background-color: rgba(56, 121, 217, 0.1);
}

-.object-value-function-prefix {
+.object-value-function-prefix,
+.object-value-boolean {
color: rgb(170, 13, 145);
}

@@ -54,9 +55,6 @@
.object-value-number {
color: rgb(28, 0, 207);
}
-.object-value-boolean {
- color: rgb(170, 13, 145);
-}

.object-value-string,
.object-value-regexp,
@@ -85,39 +83,6 @@
text-decoration: underline;
}

-.object-value-object .section,
-.object-value-promise .section,
-.object-formatted-map .section,
-.object-value-set .section,
-.object-value-iterator .section,
-.object-value-generator .section,
-.object-value-node .section,
-.object-value-typedarray .section,
-.object-value-array .section {
- position: static;
-}
-
-.object-value-object .section > .header::before,
-.object-value-promise .section > .header::before {
- margin-top: 0;
-}
-
-
-.object-value-object .properties-tree,
-.object-value-promise .properties-tree,
-.object-value-map .properties-tree,
-.object-value-set .properties-tree,
-.object-value-iterator .properties-tree,
-.object-value-generator .properties-tree,
-.object-value-node .properties-tree {
- padding-left: 0 !important;
-}
-
-.object-value-preview-node,
-.section .object-value-node {
- color: rgb(136, 18, 128);
-}
-
.object-properties-section-custom-section {
display: inline-flex;
flex-direction: column;


lush...@chromium.org

unread,
Oct 21, 2016, 10:24:31 PM10/21/16
to lu...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 21, 2016, 10:25:01 PM10/21/16
to lu...@chromium.org, lush...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 22, 2016, 12:11:02 AM10/22/16
to lu...@chromium.org, lush...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Committed patchset #2 (id:20001)

https://codereview.chromium.org/2435153003/

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 22, 2016, 12:17:53 AM10/22/16
to lu...@chromium.org, lush...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Patchset 2 (id:??) landed as
https://crrev.com/7b0ff4d08bddade737d797eac191c1bf02b5224e
Cr-Commit-Position: refs/heads/master@{#426967}

https://codereview.chromium.org/2435153003/
Reply all
Reply to author
Forward
0 new messages