Media Controls: hide duration field when changed to infinity. [chromium/src : master]
Mounir Lamouri (Gerrit)
This change is ready for review.
Patch set 1:Commit-Queue +1
To view, visit change 620775. To unsubscribe, or for help writing mail filters, visit settings.
Tommy Steimel (Gerrit)
lgtm, though fair warning this will definitely merge conflict with my change if I'm able to land first :)
apacible (Gerrit)
Patch set 1:Code-Review +1
1 comment:
File third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp:
Does 42 have any special significance for this test, or an arbitrary number?
To view, visit change 620775. To unsubscribe, or for help writing mail filters, visit settings.
Mounir Lamouri (Gerrit)
Patch set 2:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"" https://chromium-review.googlesource.com/c/620775/2
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/620775/2
Bot data: {"action": "start", "triggered_at": "2017-09-08T19:24:38.0Z", "cq_cfg_revision": "3afac2bac2b2a53f9e1a33d082a3e64f7e1ab983", "revision": "28f65273d47ef671cc24b555ecbda8557c74833b"}
Commit Bot (Gerrit)
Commit Bot merged this change.
Media Controls: hide duration field when changed to infinity.
The duration field will not show up when the resource is known to have
an infinite duration but if it is updated after load, the UI will not
properly update. This is refactoring both code path to be the same and
therefore always hide the duration field when the duration is known to
be not finite.
Bug: 756785
Change-Id: Iab38f61fc337f39e5b6bb712bd5f1cecc9a95f05
Reviewed-on: https://chromium-review.googlesource.com/620775
Commit-Queue: Mounir Lamouri <mlam...@chromium.org>
Reviewed-by: apacible <apac...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500664}
---
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
2 files changed, 35 insertions(+), 7 deletions(-)