[v8] Rebaseline layout tests related to issue v8:6529. [chromium/src : master]

Igor Sheludko (Gerrit)

unread,

Aug 17, 2017, 5:06:17 AM8/17/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

PTAL

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 17, 2017, 9:24:19 PM8/17/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Erik Luo, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch Set 2:
PTAL

Hey Igor - sorry about that I had some issues when I updated the test. Please take a look at my CL where I've updated the test and rebaselined it.

https://chromium-review.googlesource.com/c/620191

Do you want to just rebaseline console-format and I'll take care of console-dir?

Thanks.

Included @luoe who is responsible for console (he's OOO tomorrow)

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 17, 2017, 9:24:19 PM8/17/17

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Igor Sheludko

Will Chen would like Erik Luo to review this change.

View Change

[v8] Rebaseline layout tests related to issue v8:6529.

NOTRY=true

Bug: v8:6529
Change-Id: I6964f12edd6d64a1ee0d11c770485108e215971c
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
3 files changed, 10 insertions(+), 91 deletions(-)

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Igor Sheludko (Gerrit)

unread,

Aug 18, 2017, 3:14:27 AM8/18/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Erik Luo, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch Set 2:

Patch Set 2:
PTAL
Hey Igor - sorry about that I had some issues when I updated the test. Please take a look at my CL where I've updated the test and rebaselined it.
https://chromium-review.googlesource.com/c/620191
Do you want to just rebaseline console-format and I'll take care of console-dir?
Thanks.
Included @luoe who is responsible for console (he's OOO tomorrow)

Thanks! I'll wait for your CL and then land mine.

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 25, 2017, 6:14:57 PM8/25/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Erik Luo, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

+kozy

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Aug 25, 2017, 6:20:53 PM8/25/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

ishell@, if you wouldn't mind, could we please wait for my V8 CL to land before landing yours? ( https://chromium-review.googlesource.com/c/v8/v8/+/634584 )

My CL will be affecting boxed objects (e.g. new Number(42), new String('foo')), and will definitely change expectations for console-format test. I can let you know when it lands in chromium and post here on this CL when it is ready to go.

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Aug 26, 2017, 9:46:26 PM8/26/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch Set 3:

ishell@, if you wouldn't mind, could we please wait for my V8 CL to land before landing yours? ( https://chromium-review.googlesource.com/c/v8/v8/+/634584 )
My CL will be affecting boxed objects (e.g. new Number(42), new String('foo')), and will definitely change expectations for console-format test. I can let you know when it lands in chromium and post here on this CL when it is ready to go.

Just landed the CL in a V8 autoroll!
https://chromium.googlesource.com/v8/v8/+/8aed7767d6f4555795be9e74fbdf3d2085363277

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Igor Sheludko (Gerrit)

unread,

Aug 28, 2017, 5:41:13 AM8/28/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Michael Achenbach, Erik Luo, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Michael, PTAL.

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Michael Achenbach (Gerrit)

unread,

Aug 28, 2017, 5:43:33 AM8/28/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Erik Luo, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 4:Code-Review +1

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Igor Sheludko (Gerrit)

unread,

Aug 28, 2017, 5:44:33 AM8/28/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Michael Achenbach, Erik Luo, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 4:Commit-Queue +2

View Change

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 28, 2017, 5:50:05 AM8/28/17

to Igor Sheludko, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Michael Achenbach, Erik Luo, Aleksey Kozyatinskiy, Will Chen, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change.

View Change

Approvals:
  Michael Achenbach: Looks good to me
  Igor Sheludko: Commit

[v8] Rebaseline layout tests related to issue v8:6529.

NOTRY=true

Bug: v8:6529
Change-Id: I6964f12edd6d64a1ee0d11c770485108e215971c

Reviewed-on: https://chromium-review.googlesource.com/618568
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497727}
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt
2 files changed, 15 insertions(+), 16 deletions(-)

To view, visit change 618568. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward