Convert video-controls* tests to testharness.js (issue 2115833002 by srirama.m@samsung.com)

[srir...@samsung.com]

Reviewers: fs, Philip Jägenstedt
CL: https://codereview.chromium.org/2115833002/

Message:
PTAL

Description:
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+86, -152 lines):
M third_party/WebKit/LayoutTests/media/video-controls.html
D third_party/WebKit/LayoutTests/media/video-controls-expected.txt
M third_party/WebKit/LayoutTests/media/video-controls-transformed.html
D third_party/WebKit/LayoutTests/media/video-controls-transformed-expected.txt
M third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
D third_party/WebKit/LayoutTests/media/video-controls-zoomed-expected.txt

[f...@opera.com]

LGTM w/ nits


https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html
File
third_party/WebKit/LayoutTests/media/video-controls-transformed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html#newcode17
third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17:
assert_not_equals(video.controls, null);
assert_true

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
File third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html#newcode16
third_party/WebKit/LayoutTests/media/video-controls-zoomed.html:16:
assert_not_equals(video.controls, null);
Ditto

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html
File third_party/WebKit/LayoutTests/media/video-controls.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html#newcode10
third_party/WebKit/LayoutTests/media/video-controls.html:10:
assert_not_equals(video.controls, null);
'controls' is a boolean attribute, so assert_true would seem more to the
point here (and similarly below.)

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html#newcode19
third_party/WebKit/LayoutTests/media/video-controls.html:19:
assert_false(video.controls, false);
Nit: Drop second arg (false is a poor description ;-))

https://codereview.chromium.org/2115833002/

[srir...@samsung.com]

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html
File
third_party/WebKit/LayoutTests/media/video-controls-transformed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-transformed.html#newcode17
third_party/WebKit/LayoutTests/media/video-controls-transformed.html:17:
assert_not_equals(video.controls, null);

On 2016/07/01 09:21:22, fs wrote:
> assert_true

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
File third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
(right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html#newcode16
third_party/WebKit/LayoutTests/media/video-controls-zoomed.html:16:
assert_not_equals(video.controls, null);

On 2016/07/01 09:21:22, fs wrote:
> Ditto

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html
File third_party/WebKit/LayoutTests/media/video-controls.html (right):

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html#newcode10
third_party/WebKit/LayoutTests/media/video-controls.html:10:
assert_not_equals(video.controls, null);

On 2016/07/01 09:21:22, fs wrote:
> 'controls' is a boolean attribute, so assert_true would seem more to
the point
> here (and similarly below.)

Done.

https://codereview.chromium.org/2115833002/diff/1/third_party/WebKit/LayoutTests/media/video-controls.html#newcode19
third_party/WebKit/LayoutTests/media/video-controls.html:19:
assert_false(video.controls, false);

On 2016/07/01 09:21:22, fs wrote:
> Nit: Drop second arg (false is a poor description ;-))

Done.

https://codereview.chromium.org/2115833002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115833002/20001


https://codereview.chromium.org/2115833002/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #2 (id:20001)

https://codereview.chromium.org/2115833002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ bit was unchecked.

https://codereview.chromium.org/2115833002/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 2 (id:??) landed as
https://crrev.com/029e9b258d6a9f685f389054588d9f2cfb1ac9b0
Cr-Commit-Position: refs/heads/master@{#403434}

https://codereview.chromium.org/2115833002/