Added XRPresentationContext [chromium/src : master]
Brandon Jones (Gerrit)
senorblanco@: I'd like you to take a look at this. I'm sure you'll have questions. ;) Feel free to ping me directly for a chat or GVC if needed.
The best documentation at the moment for what we're trying to do with the XRPresentationContext is here: https://github.com/immersive-web/webxr/blob/master/explainer.md#rendering-to-the-page
Patch set 1:Commit-Queue +1
To view, visit change 877182. To unsubscribe, or for help writing mail filters, visit settings.
Stephen White (Gerrit)
I think Justin would be a better choice. He's much more up to speed on all things <canvas> these days.
Stephen White (Gerrit)
Stephen White would like Justin Novosad to review this change.
Added XRPresentationContext
This rendering context type is effectively a variant of an
ImageBitmapRenderingContext, but which can only be supplied images
directly by a XRSession.
Bug: 670510
Change-Id: I780d47b873f4295e169d06fe993278067e99178d
---
M third_party/WebKit/Source/bindings/IDLUnionTypes.md
M third_party/WebKit/Source/bindings/scripts/utilities.py
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
M third_party/WebKit/Source/modules/ModulesInitializer.cpp
M third_party/WebKit/Source/modules/canvas/BUILD.gn
M third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.idl
M third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.cpp
M third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.h
A third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.cpp
A third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.h
M third_party/WebKit/Source/modules/modules_idl_files.gni
M third_party/WebKit/Source/modules/xr/BUILD.gn
A third_party/WebKit/Source/modules/xr/XRPresentationContext.cpp
A third_party/WebKit/Source/modules/xr/XRPresentationContext.h
A third_party/WebKit/Source/modules/xr/XRPresentationContext.idl
18 files changed, 259 insertions(+), 82 deletions(-)
Blink WPT Bot (Gerrit)
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/9125.
If this CL lands and Travis CI upstream is green, we will auto-merge the PR.
Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process
Brandon Jones (Gerrit)
Hey Justin! If you could take a look at this I'd appreciate it. I'd like to know if this is a direction you're comfortable with and if you have an suggestions on how to improve it. High level overview of what we're trying to achieve is here: https://github.com/immersive-web/webxr/blob/master/explainer.md#rendering-to-the-page
Intent is that we want a context that acts more-or-less like a ImageBitmapRenderingContext but cannot be supplied images directly by the user, only from an XRSession. We wanted a separate context type to prevent confusing usage (user calling transferFromImageBitmap, which then gets replaced by the user agent silently) but also to allow us to add new API surface later that may not be appropriate for an ImageBitmapRenderingContext. Feel free to ping me if you'd like to talk it over, happy to do a video chat if that would help.
Brandon Jones (Gerrit)
junov@: Review ping?
Justin Novosad (Gerrit)
Patch set 2:Code-Review +1
Brandon Jones (Gerrit)
haraken@: Could you take a quick look at the bindings/ and top level modules/ changes?
Blink WPT Bot (Gerrit)
Successfully updated WPT GitHub pull request with new revision "Rebase": https://github.com/w3c/web-platform-tests/pull/9125
Kentaro Hara (Gerrit)
Implementation-wise LGTM
Patch set 3:Code-Review +1
1 comment:
File third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.cpp:
Patch Set #3, Line 1:
// Copyright 2016 The Chromium Authors. All rights reserved.2018
To view, visit change 877182. To unsubscribe, or for help writing mail filters, visit settings.
Brandon Jones (Gerrit)
Patch set 4:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Fixed date" https://chromium-review.googlesource.com/c/877182/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/877182/4
Bot data: {"action": "start", "triggered_at": "2018-01-30T03:15:54.0Z", "cq_cfg_revision": "38feaec854d6cc4a453791c47a60fb404960b79f", "revision": "6d8a5e00fd73d0c069f3a8d92241b4d8ca9b2790"}
Blink WPT Bot (Gerrit)
Successfully updated WPT GitHub pull request with new revision "Fixed date": https://github.com/w3c/web-platform-tests/pull/9125
Commit Bot (Gerrit)
Try jobs failed on following builders:
linux-chromeos-rel on master.tryserver.chromium.chromiumos (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/linux-chromeos-rel/builds/48972)
Brandon Jones (Gerrit)
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Fixed date" https://chromium-review.googlesource.com/c/877182/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/877182/4
Bot data: {"action": "start", "triggered_at": "2018-01-30T04:50:52.0Z", "cq_cfg_revision": "38feaec854d6cc4a453791c47a60fb404960b79f", "revision": "6d8a5e00fd73d0c069f3a8d92241b4d8ca9b2790"}
To view, visit change 877182. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
Commit Bot merged this change.
Added XRPresentationContext
This rendering context type is effectively a variant of an
ImageBitmapRenderingContext, but which can only be supplied images
directly by a XRSession.
Bug: 670510
Change-Id: I780d47b873f4295e169d06fe993278067e99178d
Reviewed-on: https://chromium-review.googlesource.com/877182
Commit-Queue: Brandon Jones <baj...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Justin Novosad <ju...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532777}
---
M third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
M third_party/WebKit/LayoutTests/external/wpt/webxr/resources/webxr_util.js
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
M third_party/WebKit/Source/bindings/IDLUnionTypes.md
M third_party/WebKit/Source/bindings/scripts/utilities.py
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
M third_party/WebKit/Source/modules/ModulesInitializer.cpp
M third_party/WebKit/Source/modules/canvas/BUILD.gn
M third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.idl
M third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.cpp
M third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.h
A third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.cpp
A third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.h
M third_party/WebKit/Source/modules/modules_idl_files.gni
M third_party/WebKit/Source/modules/xr/BUILD.gn
A third_party/WebKit/Source/modules/xr/XRPresentationContext.cpp
A third_party/WebKit/Source/modules/xr/XRPresentationContext.h
A third_party/WebKit/Source/modules/xr/XRPresentationContext.idl
21 files changed, 269 insertions(+), 88 deletions(-)
Blink WPT Bot (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/9125