Fix a bug where user agent shadow dom elements were inspectable (issue 2101143002 by einbinder@chromium.org)

2 views
Skip to first unread message

einb...@chromium.org

unread,
Jun 27, 2016, 8:55:15 PM6/27/16
to dgo...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, sergey...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Reviewers: dgozman
CL: https://codereview.chromium.org/2101143002/

Description:
Fix a bug where user agent shadow dom elements were inspectable
by recursively checking for shadow dom

BUG=582317

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+1, -1 lines):
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js


Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index 33e2b0dbf7c7f7385f8f4e6382a564c488cf3f1c..7d974cb2759ce76945c96b750823555c905ef45a 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -869,7 +869,7 @@ WebInspector.ElementsPanel.prototype = {
_leaveUserAgentShadowDOM: function(node)
{
var userAgentShadowRoot = node.ancestorUserAgentShadowRoot();
- return userAgentShadowRoot ? /** @type {!WebInspector.DOMNode} */ (userAgentShadowRoot.parentNode) : node;
+ return (userAgentShadowRoot && userAgentShadowRoot.parentNode) ? this._leaveUserAgentShadowDOM(userAgentShadowRoot.parentNode) : node;
},

/**


dgo...@chromium.org

unread,
Jun 27, 2016, 9:30:30 PM6/27/16
to einb...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, sergey...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

return (userAgentShadowRoot && userAgentShadowRoot.parentNode) ?
this._leaveUserAgentShadowDOM(userAgentShadowRoot.parentNode) : node;
Let's turn this into a while loop.

https://codereview.chromium.org/2101143002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 6:44:08 PM6/30/16
to einb...@chromium.org, dgo...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, sergey...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:12:08 PM6/30/16
to einb...@chromium.org, dgo...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, sergey...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Committed patchset #2 (id:20001)

https://codereview.chromium.org/2101143002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:15:41 PM6/30/16
to einb...@chromium.org, dgo...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, sergey...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Patchset 2 (id:??) landed as
https://crrev.com/63dae32710b9465a7a6a906e4be1bc2bc138e651
Cr-Commit-Position: refs/heads/master@{#403359}

https://codereview.chromium.org/2101143002/
Reply all
Reply to author
Forward
0 new messages