[device-ram] Update the <value> calculations to match the updated spec [chromium/src : master]
0 views
Skip to first unread message
Fadi Meawad (Gerrit)
Jun 23, 2017, 5:42:41 PM6/23/17
to blink-...@chromium.org, chromium...@chromium.org, Yoav Weiss
Fadi Meawad posted comments on this change.
Patch set 1:Commit-Queue +1
To view, visit change 546997. To unsubscribe, visit settings.
Fadi Meawad (Gerrit)
Jun 23, 2017, 5:44:22 PM6/23/17
to Shubhie Panicker, Kentaro Hara, blink-...@chromium.org
Fadi Meawad would like Shubhie Panicker and Kentaro Hara to review this change.
[device-ram] Update the <value> calculations to match the updated spec
After implmenting the original spec, we noticed that the returned value
did not provide a good representation of the actual device-ram.
The issue was discussed on the spec:
https://github.com/WICG/device-ram/issues/1 and the spec was updated.
The new <value> is a rounding (instead of flooring) of the actual
memory to a bound that can have only the 2 most significant bits set.
More details in the spec description at:
https://github.com/WICG/device-ram
Bug:chromium:718622
Change-Id: I33df6b0480b8e65a24fe4765839fb22633dfcd43
---
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
2 files changed, 27 insertions(+), 17 deletions(-)
Fadi Meawad (Gerrit)
Jun 23, 2017, 5:44:22 PM6/23/17
to blink-...@chromium.org, Kentaro Hara, Shubhie Panicker, Commit Bot, chromium...@chromium.org, Yoav Weiss
PTAL :)
Kentaro Hara (Gerrit)
Jun 24, 2017, 8:42:14 PM6/24/17
to Fadi Meawad, blink-...@chromium.org, Shubhie Panicker, Commit Bot, chromium...@chromium.org, Yoav Weiss
Kentaro Hara posted comments on this change.
Patch set 1:Code-Review +1
LGTM
Fadi Meawad (Gerrit)
Jun 26, 2017, 11:51:30 AM6/26/17
to blink-...@chromium.org, Kentaro Hara, Shubhie Panicker, Commit Bot, chromium...@chromium.org, Yoav Weiss
Fadi Meawad posted comments on this change.
Patch set 1:Commit-Queue +2
Commit Bot (Gerrit)
Jun 26, 2017, 1:35:22 PM6/26/17
to Fadi Meawad, blink-...@chromium.org, Kentaro Hara, Shubhie Panicker, chromium...@chromium.org, Yoav Weiss
Commit Bot merged this change.
Approvals:
Kentaro Hara: Looks good to me
Fadi Meawad: Commit
[device-ram] Update the <value> calculations to match the updated spec
After implmenting the original spec, we noticed that the returned value
did not provide a good representation of the actual device-ram.
The issue was discussed on the spec:
https://github.com/WICG/device-ram/issues/1 and the spec was updated.
The new <value> is a rounding (instead of flooring) of the actual
memory to a bound that can have only the 2 most significant bits set.
More details in the spec description at:
https://github.com/WICG/device-ram
Bug: chromium:718622
Change-Id: I33df6b0480b8e65a24fe4765839fb22633dfcd43
Reviewed-on: https://chromium-review.googlesource.com/546997
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Fadi Meawad <fme...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482306}
---
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
2 files changed, 27 insertions(+), 17 deletions(-)
Shubhie Panicker (Gerrit)
Jun 26, 2017, 2:20:50 PM6/26/17
to Fadi Meawad, Commit Bot, blink-...@chromium.org, Kentaro Hara, chromium...@chromium.org, Yoav Weiss
Shubhie Panicker posted comments on this change.
Patch set 2:
LGTM
Reply all
Reply to author
Forward
0 new messages