Move transform least common ancestor logic to GeometryMapper (issue 2380423002 by pdr@chromium.org)

0 views
Skip to first unread message

p...@chromium.org

unread,
Sep 30, 2016, 4:03:23 PM9/30/16
to chri...@chromium.org, wangx...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Reviewers: chrishtr, Xianzhu
CL: https://codereview.chromium.org/2380423002/

Description:
Move transform least common ancestor logic to GeometryMapper

This patch moves the least common ancestor logic off of
GeometryPropertyTreeState and onto GeometryMapper. This will make
it easier to remove GeometryPropertyTreestate in a future patch. With
this patch, we are able to remove some unnecessary templates and
remove the GeometryPropertyTreeStateTest entirely.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Affected files (+70, -100 lines):
M third_party/WebKit/Source/platform/BUILD.gn
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp
M third_party/WebKit/Source/platform/graphics/paint/GeometryPropertyTreeState.h
D third_party/WebKit/Source/platform/graphics/paint/GeometryPropertyTreeStateTest.cpp


wangx...@chromium.org

unread,
Sep 30, 2016, 4:26:57 PM9/30/16
to p...@chromium.org, chri...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

p...@chromium.org

unread,
Sep 30, 2016, 5:21:22 PM9/30/16
to chri...@chromium.org, wangx...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
On 2016/09/30 at 20:26:57, wangxianzhu wrote:
> lgtm

Chrishtr, are you okay with this too?

https://codereview.chromium.org/2380423002/

chri...@chromium.org

unread,
Sep 30, 2016, 6:47:51 PM9/30/16
to p...@chromium.org, wangx...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 7:57:17 PM9/30/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 8:07:48 PM9/30/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/271193)

https://codereview.chromium.org/2380423002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 9:07:18 PM9/30/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 10:13:00 PM9/30/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Try jobs failed on following builders:

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 11:30:44 PM9/30/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 1:49:07 AM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Try jobs failed on following builders:

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 2:03:52 AM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 4:22:43 AM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Try jobs failed on following builders:
linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 4:52:44 PM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 7:12:54 PM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Committed patchset #2 (id:20001)

https://codereview.chromium.org/2380423002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 7:14:26 PM10/1/16
to p...@chromium.org, chri...@chromium.org, wangx...@chromium.org, commi...@chromium.org, ajuma...@chromium.org, blink-...@chromium.org, blink-reviews-p...@chromium.org, caba...@adobe.com, chromium...@chromium.org, danakj...@chromium.org, dongseo...@intel.com, drott+bl...@chromium.org, dsch...@chromium.org, fma...@chromium.org, jbr...@chromium.org, ju...@chromium.org, pdr+graphi...@chromium.org, rob....@samsung.com, sche...@chromium.org
Patchset 2 (id:??) landed as
https://crrev.com/95f4e0b2bd03fa3443f782ae3cb3cbfc08a74503
Cr-Commit-Position: refs/heads/master@{#422332}

https://codereview.chromium.org/2380423002/
Reply all
Reply to author
Forward
0 new messages