Third step of many to porting blink CSP tests to WPT [chromium/src : master]

Andy Paicu (Gerrit)

unread,

Oct 19, 2017, 6:36:59 AM10/19/17

to blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Commit Bot, chromium...@chromium.org

They're still coming

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 19, 2017, 6:46:23 AM10/19/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Commit Bot, chromium...@chromium.org

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/7897.

If this CL lands and Travis CI upstream is green, we will auto-merge the PR.

Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Mike West (Gerrit)

unread,

Oct 19, 2017, 7:20:11 AM10/19/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Blink WPT Bot, Commit Bot, chromium...@chromium.org

This looks good too. *phew* Thank you for digging in!

Patch set 1:Code-Review +1

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Andy Paicu (Gerrit)

unread,

Oct 20, 2017, 6:16:32 AM10/20/17

to blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Blink WPT Bot, Commit Bot, chromium...@chromium.org

Patch set 2:Commit-Queue +2

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 6:16:38 AM10/20/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Blink WPT Bot, chromium...@chromium.org

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/728159/2

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/728159/2

Bot data: {"action": "start", "triggered_at": "2017-10-20T10:16:26.0Z", "cq_cfg_revision": "fc2b2f04ed20d88113c10951036ca403891c435f", "revision": "3a6c98a2c9c7516fb258fe6f5d7148800af2da56"}

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 20, 2017, 6:25:46 AM10/20/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Commit Bot, chromium...@chromium.org

Successfully updated WPT GitHub pull request with new revision "Rebase": https://github.com/w3c/web-platform-tests/pull/7897

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 7:36:54 AM10/20/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Blink WPT Bot, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Mike West: Looks good to me
  Andy Paicu: Commit

Third step of many to porting blink CSP tests to WPT

This has been a long time overdue but there are too many things currently
blocking on this so it's time to look at the blink-contrib folders.

Goals are to:
- make blink-contrib folders contain valid tests that are not only
programatically generated
- get rid of the reliance on checkreport as much as possible in these tests

Bug: 651742
Change-Id: I8ad66788ec28c01815437e71067c3ce9d4d54f7e
Reviewed-on: https://chromium-review.googlesource.com/728159
Commit-Queue: Andy Paicu <andy...@chromium.org>
Reviewed-by: Mike West <mk...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510402}
---
M third_party/WebKit/LayoutTests/TestExpectations
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/icon-allowed.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/icon-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/icon-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/icon-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/iframe-inside-csp.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-allowed.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-full-host-wildcard-allowed.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/image-full-host-wildcard-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-script-allowed.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-script-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-script-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-script-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-style-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-style-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/injected-inline-style-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-allowed-while-cloning-objects.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-attribute-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-attribute-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-attribute-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-attribute-on-html.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/inline-style-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/resources/inject-script.js
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/iframe-inside-csp.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/iframe-inside-csp.sub.html.sub.headers
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/support/sandboxed-eval.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/support/sandboxed-eval.sub.html.sub.headers
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/icon-allowed.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/icon-blocked.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/injected-inline-script-allowed.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/injected-inline-script-blocked.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/inject-script.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/injected-inline-style-allowed.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/injected-inline-style-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-allowed-while-cloning-objects.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-allowed.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-attribute-allowed.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-attribute-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-attribute-on-html.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/inline-style-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/support/inject-style.js
45 files changed, 243 insertions(+), 328 deletions(-)

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 20, 2017, 8:04:07 AM10/20/17

to Andy Paicu, Commit Bot, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, chromium...@chromium.org

The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/7897

View Change

To view, visit change 728159. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward