DevTools: Edit styles in HTML WIP [chromium/src : master]

Joel Einbinder (Gerrit)

unread,

Jan 18, 2018, 7:57:14 PM1/18/18

to apavlo...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Lushnikov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

what do you think about splitting this out into DocumentMapping.js?

View Change

2 comments:

File third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js:
- Patch Set #2, Line 293: var content = await this._uiSourceCode.requestContent();
  This techincally works as is, but I'm a bit scared of an async function on an event.
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:
- Patch Set #2, Line 28: this.editiedStartColumn = this.startColumn;
  This won't work if you reload devtools after editing. Fixing that requires requesting a lot of content.

To view, visit change 875010. To unsubscribe, or for help writing mail filters, visit settings.

Dmitry Gozman (Gerrit)

unread,

Jan 20, 2018, 12:18:31 PM1/20/18

to Joel Einbinder, apavlo...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Lushnikov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

This looks pretty involved. Let's think more :)

View Change

2 comments:

File third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js:
- Patch Set #2, Line 318: Bindings.cssWorkspaceBinding.updateLocations(style);
  Won't this happen automatically? I think we should throttle it somehow due to many places calling it again and again.
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:

- Patch Set #2, Line 28: this.editiedStartColumn = this.startColumn;

- This won't work if you reload devtools after editing. […]
  We can store this together with stylesheet content on backend. WDYT?

To view, visit change 875010. To unsubscribe, or for help writing mail filters, visit settings.

Joel Einbinder (Gerrit)

unread,

Jan 22, 2018, 7:06:11 PM1/22/18

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-rev...@chromium.org, Dmitry Gozman, Andrey Lushnikov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

View Change

2 comments:

File third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js:
- Patch Set #2, Line 318: continue;
  Won't this happen automatically? I think we should throttle it somehow due to many places calling it […]
  All things that call this are throttled, so I think we are ok.
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:
- Patch Set #2, Line 28: this.setSourceMapURL(payload.sourceMapURL);
  We can store this together with stylesheet content on backend. […]
  We talked about it offline and and decided to do it on the front end to avoid linking the CSS and JS backends, but isolating this code to bindings.

To view, visit change 875010. To unsubscribe, or for help writing mail filters, visit settings.

Dmitry Gozman (Gerrit)

unread,

Jan 23, 2018, 2:28:28 PM1/23/18

to Joel Einbinder, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-rev...@chromium.org, Andrey Lushnikov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

This looks good overall. Let's test it :)

View Change

To view, visit change 875010. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward