Changed EPointerEvents to an enum class and renamed its members to keywords (issue 2542843002 by napper@chromium.org)

[nap...@chromium.org]

Reviewers: sashab
CL: https://codereview.chromium.org/2542843002/

Description:
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043

Affected files (+63, -55 lines):
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
M third_party/WebKit/Source/core/layout/LayoutObject.h
M third_party/WebKit/Source/core/layout/PointerEventsHitRules.cpp
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
M third_party/WebKit/Source/core/style/ComputedStyle.h
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

[nap...@chromium.org]

[sas...@chromium.org]

Nice work, but this is only the first part of your patch description:

Changed EPointerEvents to an enum class and gave it an unsigned underlying type.

-- Done

Also renamed its members to match its keywords from CSSValueKeywords.in.

-- Not done

Happy to let you land this if you change the desc to say only the first part,
then do a second patch to rename the members. I have done this before :)
Alternatively they can be both in the same patch, your choice :)

https://codereview.chromium.org/2542843002/

[nap...@chromium.org]

Sorry, missed that. I will rename the members to match in a following CL.

https://codereview.chromium.org/2542843002/

[sas...@chromium.org]

lgtm



https://codereview.chromium.org/2542843002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542843002/1


https://codereview.chromium.org/2542843002/

[commit-bot@chromium.org via codereview.chromium.org]

Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/318191)

https://codereview.chromium.org/2542843002/

[sas...@chromium.org]

You'll need someone from the OWNERS file in core/svg and core/web :)

https://codereview.chromium.org/2542843002/

[sas...@chromium.org]

On 2016/12/04 at 23:14:54, sashab wrote:
> You'll need someone from the OWNERS file in core/svg and core/web :)

Oops sorry I meant just Source/web, I'm OWNERS for core/* :)

https://codereview.chromium.org/2542843002/

[nap...@chromium.org]

dcheng@ please RS web/

https://codereview.chromium.org/2542843002/

[dch...@chromium.org]

lgtm



https://codereview.chromium.org/2542843002/

[commit-bot@chromium.org via codereview.chromium.org]

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #1 (id:1)

https://codereview.chromium.org/2542843002/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 1 (id:??) landed as
https://crrev.com/7288d286aaf11b6c4a6da25b8dc6209f64908f97
Cr-Commit-Position: refs/heads/master@{#436232}

https://codereview.chromium.org/2542843002/