Re: Show image placeholders on dimension decode error (issue 2797993007 by rajendrant@chromium.org)

1 view
Skip to first unread message

scli...@chromium.org

unread,
Jun 8, 2017, 2:20:33 PM6/8/17
to rajen...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Sorry, I must've not seen this one. LGTM!

https://codereview.chromium.org/2797993007/

rajen...@google.com

unread,
Jun 12, 2017, 2:00:21 PM6/12/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

rajen...@google.com

unread,
Jun 22, 2017, 1:32:51 AM6/22/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
hiroshige: friendly ping. ptal

https://codereview.chromium.org/2797993007/

rajen...@google.com

unread,
Jun 22, 2017, 1:32:52 AM6/22/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

hiro...@chromium.org

unread,
Jun 22, 2017, 5:03:07 PM6/22/17
to rajen...@chromium.org, scli...@chromium.org, rajen...@google.com, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 22, 2017, 5:12:11 PM6/22/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, rajen...@google.com, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 22, 2017, 5:15:04 PM6/22/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, rajen...@google.com, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/366039)
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/471469)
mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/447764)
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/483729)

https://codereview.chromium.org/2797993007/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 23, 2017, 7:18:22 PM6/23/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, rajen...@google.com, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
CQ is trying da patch.

Follow status at:

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 23, 2017, 7:25:35 PM6/23/17
to rajen...@chromium.org, scli...@chromium.org, hiro...@chromium.org, rajen...@google.com, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:

oj...@chromium.org

unread,
Jun 23, 2017, 8:10:34 PM6/23/17
to rajen...@chromium.org, hiro...@chromium.org, rajen...@google.com, scli...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
lgtm




https://codereview.chromium.org/2797993007/diff/60001/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
File
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2797993007/diff/60001/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp#newcode247
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:247:
// EXPECT_TRUE(content->GetImage()->IsBitmapImage());
We don't typically check in commented out code. Did you intend to
comment this out?

https://codereview.chromium.org/2797993007/

dch...@chromium.org

unread,
Jun 23, 2017, 8:26:48 PM6/23/17
to rajen...@chromium.org, hiro...@chromium.org, rajen...@google.com, scli...@chromium.org, oj...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
also, please let reviewers know if they don't need to look anymore. I had this
open in a tab and was looking it over and didn't realize ojan already reviewed
until i refreshed.

lgtm with comment addressed.



https://codereview.chromium.org/2797993007/diff/60001/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
File
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2797993007/diff/60001/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp#newcode247
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:247:
// EXPECT_TRUE(content->GetImage()->IsBitmapImage());
On 2017/06/24 00:10:34, ojan wrote:
> We don't typically check in commented out code. Did you intend to
comment this
> out?

+1, please uncomment this or delete it.

https://codereview.chromium.org/2797993007/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 24, 2017, 1:18:16 PM6/24/17
to rajen...@chromium.org, hiro...@chromium.org, rajen...@google.com, scli...@chromium.org, oj...@chromium.org, dcheng+...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
CQ is trying da patch.

Follow status at:

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 24, 2017, 1:21:18 PM6/24/17
to rajen...@chromium.org, hiro...@chromium.org, rajen...@google.com, scli...@chromium.org, oj...@chromium.org, dcheng+...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Reply all
Reply to author
Forward
0 new messages