Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard." (issue 2626973005 by ktyliu@chromium.org)

[kty...@chromium.org]

Reviewers: sashab, eae
CL: https://codereview.chromium.org/2626973005/

Message:
Hi Sasha, Emil,

Sorry my last patch was reverted.

I've checked with author of rebaseline-cl, and he agrees that using
NeedsManualRebaseline for now is good until we figure out the root problem --
https://bugs.chromium.org/p/chromium/issues/detail?id=680768

Hope this is okay.

Thanks,
Kevin

Description:
Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard."
Using NeedsManualRebaseline since automatically rebaseline does not work

Original description:
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414

Affected files (+296, -270 lines):
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/animations/animations-responsive-to-color-change.html
M third_party/WebKit/LayoutTests/animations/composition/box-shadow-composition.html
M third_party/WebKit/LayoutTests/animations/composition/text-shadow-composition.html
M third_party/WebKit/LayoutTests/animations/interpolation/backdrop-filter-interpolation-expected.txt
M third_party/WebKit/LayoutTests/animations/interpolation/background-color-interpolation.html
M third_party/WebKit/LayoutTests/animations/interpolation/box-shadow-interpolation-expected.txt
M third_party/WebKit/LayoutTests/animations/interpolation/filter-interpolation-expected.txt
M third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation-expected.txt
M third_party/WebKit/LayoutTests/compositing/contents-opaque/background-color-expected.txt
M third_party/WebKit/LayoutTests/compositing/draws-content/canvas-background-layer-expected.txt
M third_party/WebKit/LayoutTests/compositing/draws-content/webgl-background-layer-expected.txt
M third_party/WebKit/LayoutTests/compositing/fixed-body-background-positioned-expected.png
M third_party/WebKit/LayoutTests/compositing/iframes/overlapped-nested-iframes-expected.txt
M third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
M third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
M third_party/WebKit/LayoutTests/compositing/overflow/clear-scroll-parent-expected.txt
A + third_party/WebKit/LayoutTests/compositing/overflow/clip-content-under-overflow-controls-expected.png
A + third_party/WebKit/LayoutTests/compositing/scrollbar-painting-expected.png
M third_party/WebKit/LayoutTests/compositing/z-order/collect-layers-does-not-initialize-pos-z-order-list-expected.png
M third_party/WebKit/LayoutTests/css-parser/color3-expected.txt
A third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
M third_party/WebKit/LayoutTests/css3/calc/color-hsl-expected.txt
M third_party/WebKit/LayoutTests/css3/calc/color-rgb-expected.txt
M third_party/WebKit/LayoutTests/editing/execCommand/query-command-value-background-color.html
M third_party/WebKit/LayoutTests/editing/execCommand/query-command-value-background-color-expected.txt
M third_party/WebKit/LayoutTests/fast/backgrounds/background-leakage-expected.png
M third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.txt
M third_party/WebKit/LayoutTests/fast/block/float/relative-painted-twice-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/border-image-trumps-radius-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/border-left-right-same-bottom-different-color-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-left-right-same-bottom-different-color-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha2-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-03-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-03-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-03-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-03-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-04-expected.png
M third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-04-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed05-expected.png
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed05-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted05-expected.png
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted05-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted06-expected.png
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted06-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble05-expected.png
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble05-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble09-expected.png
M third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble09-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.png
M third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.txt
M third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-expected.png
M third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius-expected.png
M third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius2-expected.png
M third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-radius-expected.png
M third_party/WebKit/LayoutTests/fast/box-shadow/inset-box-shadow-radius-expected.png
M third_party/WebKit/LayoutTests/fast/box-shadow/shadow-tiling-artifact-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-circumference-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-circumference-fill-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/canvas-blend-image-expected.txt
M third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-transformclip-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-circumference-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-circumference-fill-expected.png
M third_party/WebKit/LayoutTests/fast/canvas/rgba-parsing-expected.txt
M third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-blend-image.js
M third_party/WebKit/LayoutTests/fast/canvas/script-tests/rgba-parsing.js
M third_party/WebKit/LayoutTests/fast/canvas/toDataURL-alpha-stability-expected.png
M third_party/WebKit/LayoutTests/fast/css/percentage-non-integer-expected.png
M third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
M third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js
M third_party/WebKit/LayoutTests/fast/frames/content-opacity-1-expected.png
M third_party/WebKit/LayoutTests/fast/frames/content-opacity-1-expected.txt
M third_party/WebKit/LayoutTests/fast/layers/self-painting-outline-expected.png
M third_party/WebKit/LayoutTests/fast/replaced/border-radius-clip-content-edge-expected.png
M third_party/WebKit/LayoutTests/fast/ruby/select-ruby-expected.txt
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-expected.png
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-expected.txt
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt
M third_party/WebKit/LayoutTests/fast/table/row-box-shadow-expected.png
M third_party/WebKit/LayoutTests/fast/table/row-box-shadow-expected.txt
M third_party/WebKit/LayoutTests/fast/table/section-box-shadow-expected.png
M third_party/WebKit/LayoutTests/fast/table/section-box-shadow-expected.txt
M third_party/WebKit/LayoutTests/fast/table/self-painting-row-box-shadow-expected.png
M third_party/WebKit/LayoutTests/fast/table/self-painting-row-box-shadow-expected.txt
D third_party/WebKit/LayoutTests/fast/text/shadow-no-blur-expected.txt
M third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images-expected.png
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-get-background-colors-expected.txt
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-js-line-level-profile-expected.txt
M third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-borderbox-background-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/images/direct-image-background-color-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/images/direct-image-background-color-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/overflow-scroll-background-opaque-to-transparent-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/overflow-scroll-background-transparent-to-opaque-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/webgl/webgl-background-color-expected.png
M third_party/WebKit/LayoutTests/platform/linux/compositing/webgl/webgl-background-color-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-leakage-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-leakage-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-leakage-transforms-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-leakage-transforms-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/block/float/intruding-painted-twice-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/block/float/intruding-painted-twice-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-mixed-alpha-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-mixed-alpha2-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-radius-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-radius-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-radius2-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/mixed-border-styles-radius2-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/outline-alpha-block-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/outline-alpha-inline-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/basic-shadows-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/inset-box-shadow-radius-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/inset-box-shadow-radius-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-composite-video-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/canvas/canvas-composite-video-shadow-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/canvas/toDataURL-alpha-stability-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/css/percentage-non-integer-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/css/percentage-non-integer-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/css/shadow-multiple-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/css/shadow-multiple-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLMeterElement/meter-styles-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/month-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/week-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/checkbox/checkbox-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/radio/radio-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/range/range-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/search/search-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/listbox-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/submit/submit-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/text-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/textarea/textarea-appearance-basic-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/gradients/gradient-after-transparent-border-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/float-in-relpositioned-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/float-in-relpositioned-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/replaced/border-radius-clip-content-edge-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/text/shadow-no-blur-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/text/shadow-no-blur-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/text/shadow-translucent-fill-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/text/shadow-translucent-fill-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/svg/filters/feBlend-all-modes-expected.png
M third_party/WebKit/LayoutTests/platform/linux/svg/filters/feBlend-all-modes-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/svg/text/text-fill-opacity-expected.png
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-video-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-video-shadow-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/toDataURL-alpha-stability-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/toDataURL-alpha-stability-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/calendar-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/compositing/webgl/webgl-background-color-expected.png
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/compositing/webgl/webgl-background-color-expected.txt
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/shadow-multiple-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/month-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/week-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/search/search-appearance-basic-expected.png
[[ 245 additional files ]]

[sas...@chromium.org]

Still LGTM, I don't have OWNERs on platform/ or web/ though so you'll need LGTM
for those

https://codereview.chromium.org/2626973005/

[kty...@chromium.org]

Hi Emil,

Can you help RSLGTM for the platform/ change?

Thanks,
Kevin

https://codereview.chromium.org/2626973005/

[e...@chromium.org]

LGTM, thanks for your patience!

https://codereview.chromium.org/2626973005/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626973005/100001


https://codereview.chromium.org/2626973005/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a122cc62bf73f

https://codereview.chromium.org/2626973005/