Convert AudioNode Audit tests to testharness (issue 2638203002 by rtoy@chromium.org)

0 views
Skip to first unread message

rtoy@chromium.org via codereview.chromium.org

unread,
Jan 23, 2017, 3:54:43 PM1/23/17
to hongchan...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Reviewers: hongchan
CL: https://codereview.chromium.org/2638203002/

Message:
PTAL

Description:
Convert AudioNode Audit tests to testharness

These tests were converted using the script

for f in `grep -l Audit *.html`
do
# Replace js-test with testharness and add testharnessreport.js
sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
# Remove old js-test methods that no longer exist.
sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f
# Remove jsTestIsAsync stuff
sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f
# Remove expected results file.
base=`basename $f .html`
git rm $base-expected.txt
done

audionode-disconnect-audioparam.html required some manual adjustments
because it used testPassed directly.

BUG=682011
TEST=audionode-connect-method-chaining.html,audionode-disconnect-audioparam.html,audionode-disconnect.html

Affected files (+12, -125 lines):
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining.html
D third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining-expected.txt
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect.html
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-audioparam.html
D third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-audioparam-expected.txt
D third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-expected.txt


hong...@chromium.org

unread,
Jan 23, 2017, 4:48:56 PM1/23/17
to rt...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 10:52:16 AM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 10:56:09 AM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/198967)
android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/199598)

https://codereview.chromium.org/2638203002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 11:30:23 AM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 11:34:25 AM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 1:37:02 PM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 1:45:19 PM1/24/17
to rt...@chromium.org, hongchan...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org
Reply all
Reply to author
Forward
0 new messages