Re: Add MarkRole in blink side to expose mark tag properly (issue 653683005 by shreeram.k@samsung.com)

[shree...@samsung.com]

@Dominic - Spec has been updated for Mark tag. Now, IA2 role and
AXRoleDescription has been defined for Mark tag. PTAL. Thanks.



https://codereview.chromium.org/653683005/

[dmaz...@chromium.org]

I don't see where you're assigning the role. You should probably add it to
AXNodeObject::determineAccessibilityRoleUtil


https://codereview.chromium.org/653683005/

[shree...@samsung.com]

On 2015/06/01 17:09:10, dmazzoni wrote:
> I don't see where you're assigning the role. You should probably add it to
> AXNodeObject::determineAccessibilityRoleUtil

Ohh I think while rebasing I missed it, since it was an old CL.

https://codereview.chromium.org/653683005/

[shree...@samsung.com]

Updated the code. PTAL. Thanks.

https://codereview.chromium.org/653683005/

[dmaz...@chromium.org]

lgtm



https://codereview.chromium.org/653683005/

['commit-bot: I haz the power' via codereview.chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/653683005/80001


https://codereview.chromium.org/653683005/

['commit-bot: I haz the power' via codereview.chromium.org]

Try jobs failed on following builders:
win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64726)

https://codereview.chromium.org/653683005/

['commit-bot: I haz the power' via codereview.chromium.org]

['commit-bot: I haz the power' via codereview.chromium.org]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196310

https://codereview.chromium.org/653683005/

[ju...@chromium.org]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1160433004/ by ju...@chromium.org.

The reason for reverting is: content_browsertests
DumpAccessibilityTreeTest.AccessibilityMark
Failing on win7 and Mac.

https://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/10071/steps/content_browsertests/logs/DumpAccessibilityTreeTest.AccessibilityMark.

https://codereview.chromium.org/653683005/

['commit-bot: I haz the power' via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/653683005/100001


https://codereview.chromium.org/653683005/

['commit-bot: I haz the power' via codereview.chromium.org]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196825

https://codereview.chromium.org/653683005/