Enable SlimmingPaintInvalidation (issue 2647393002 by wangxianzhu@chromium.org)

1 view
Skip to first unread message

wangx...@chromium.org

unread,
Jan 23, 2017, 1:35:50 PM1/23/17
to esp...@chromium.org, chri...@chromium.org, p...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, j...@chromium.org, kinuko...@chromium.org, dari...@chromium.org
Reviewers: esprehn, chrishtr, pdr.
CL: https://codereview.chromium.org/2647393002/

Description:
Enable SlimmingPaintInvalidation

BUG=646176

Affected files (+4, -4 lines):
M content/child/runtime_features.cc
M content/public/common/content_features.cc
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in


Index: content/child/runtime_features.cc
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
index fd9241227a4f73f95ed63442d923bfb1b7d65428..9dbd3a3eeee75b952c41a159f84f83ce4fe612ca 100644
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -254,8 +254,8 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
if (command_line.HasSwitch(switches::kEnableSlimmingPaintV2))
WebRuntimeFeatures::enableSlimmingPaintV2(true);

- if (base::FeatureList::IsEnabled(features::kSlimmingPaintInvalidation))
- WebRuntimeFeatures::enableSlimmingPaintInvalidation(true);
+ WebRuntimeFeatures::enableSlimmingPaintInvalidation(
+ base::FeatureList::IsEnabled(features::kSlimmingPaintInvalidation));

if (command_line.HasSwitch(switches::kEnableSlimmingPaintInvalidation))
WebRuntimeFeatures::enableSlimmingPaintInvalidation(true);
Index: content/public/common/content_features.cc
diff --git a/content/public/common/content_features.cc b/content/public/common/content_features.cc
index d8f97951c4003c4c7325f19a55e24740435b37e7..0ed194494d772bc266116e5e6489112763c2618d 100644
--- a/content/public/common/content_features.cc
+++ b/content/public/common/content_features.cc
@@ -208,7 +208,7 @@ const base::Feature kSharedArrayBuffer{"SharedArrayBuffer",

// Paint invalidation based on slimming paint. See https://goo.gl/eQczQW
const base::Feature kSlimmingPaintInvalidation{
- "SlimmingPaintInvalidation", base::FEATURE_DISABLED_BY_DEFAULT};
+ "SlimmingPaintInvalidation", base::FEATURE_ENABLED_BY_DEFAULT};

// Speculatively launches Service Workers on mouse/touch events.
const base::Feature kSpeculativeLaunchServiceWorker{
Index: third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
diff --git a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
index b4b99e4d9009553a67dda1bd1b36f7b509ac22d9..6518e8c16afae3d3604c5ee611a8133afa17ae10 100644
--- a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
+++ b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
@@ -225,7 +225,7 @@ ShadowPiercingDescendantCombinator status=experimental
ShapeDetection status=experimental
SharedArrayBuffer
SharedWorker status=stable
-SlimmingPaintInvalidation implied_by=SlimmingPaintV2, status=experimental
+SlimmingPaintInvalidation implied_by=SlimmingPaintV2, status=stable
SlimmingPaintV2
SlimmingPaintStrictCullRectClipping
// Used as argument in attribute of stable-release functions/interfaces where


p...@chromium.org

unread,
Jan 23, 2017, 1:53:16 PM1/23/17
to wangx...@chromium.org, esp...@chromium.org, chri...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, j...@chromium.org, kinuko...@chromium.org, dari...@chromium.org
LGTM

@esprehn, there's a PSA that will go out today with more details.

https://codereview.chromium.org/2647393002/

chri...@chromium.org

unread,
Jan 23, 2017, 4:25:21 PM1/23/17
to wangx...@chromium.org, esp...@chromium.org, p...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org
Please double-check the disable mechanism via the commandline and about:flags
still works.

https://codereview.chromium.org/2647393002/

chri...@chromium.org

unread,
Jan 23, 2017, 4:25:22 PM1/23/17
to wangx...@chromium.org, esp...@chromium.org, p...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org

wangx...@chromium.org

unread,
Jan 23, 2017, 5:45:21 PM1/23/17
to chri...@chromium.org, esp...@chromium.org, p...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org
On 2017/01/23 21:25:20, chrishtr wrote:
> Please double-check the disable mechanism via the commandline and about:flags
> still works.

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 2:27:50 AM1/24/17
to wangx...@chromium.org, chri...@chromium.org, esp...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 4:08:46 AM1/24/17
to wangx...@chromium.org, chri...@chromium.org, esp...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org
Try jobs failed on following builders:
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/374623)

https://codereview.chromium.org/2647393002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 12:20:54 PM1/24/17
to wangx...@chromium.org, chri...@chromium.org, esp...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jan 24, 2017, 2:35:11 PM1/24/17
to wangx...@chromium.org, chri...@chromium.org, esp...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, kinuko...@chromium.org
Reply all
Reply to author
Forward
0 new messages