[heap-profiler] Fix highlighting of detached DOM tree nodes. [chromium/src : master]
Ulan Degenbaev (Gerrit)
PTAL. Is there a way to unit-test the _markDetachedDOMTreeNodes function? (cannot find on code search).
To view, visit change 964761. To unsubscribe, or for help writing mail filters, visit settings.
Alexei Filippov (Gerrit)
Patch set 1:Code-Review +1
1 comment:
File third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:
Patch Set #1, Line 2628:
if (nodeType === nodeNativeType) {nit: if ( != ) continue;
To view, visit change 964761. To unsubscribe, or for help writing mail filters, visit settings.
Ulan Degenbaev (Gerrit)
1 comment:
File third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:
Patch Set #1, Line 2628:
if (nodeType !== nodeNativeType)
nit: if ( != ) continue;
Done
To view, visit change 964761. To unsubscribe, or for help writing mail filters, visit settings.
Ulan Degenbaev (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/964761/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/964761/3
Bot data: {"action": "start", "triggered_at": "2018-03-17T13:03:06.0Z", "cq_cfg_revision": "b6c5f044c073ae207081077d3fd1ff808549a7e0", "revision": "eadd43cb7d396d080b62a0244c3e09b7991a6337"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/674087)
Ulan Degenbaev (Gerrit)
Patch set 4:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/964761/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/964761/4
Bot data: {"action": "start", "triggered_at": "2018-03-20T09:51:04.0Z", "cq_cfg_revision": "5b6c43e4d6b0297aa92e118e785d640c42297271", "revision": "5168fd2921ec3bd11ae94e551a20ef04069c072a"}
Commit Bot (Gerrit)
Commit Bot merged this change.
[heap-profiler] Fix highlighting of detached DOM tree nodes.
The _markDetachedDOMTreeNodes in the worker sets the detachedDOMTreeNode
flag if the node is native and its name starts with "Detached " prefix.
This patch also ensures that '.highlight' and '.detached-dom-tree-node'
CSS styles are not set both at the same time.
Bug: 811925
Change-Id: Iee4ee0647abb19a36c1be2f078b4c2915d67cba5
Reviewed-on: https://chromium-review.googlesource.com/964761
Commit-Queue: Ulan Degenbaev <ul...@chromium.org>
Reviewed-by: Alexei Filippov <al...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544327}
---
M third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
2 files changed, 14 insertions(+), 20 deletions(-)