Remove layoutTestController, an alias to testRunner [chromium/src : master]

Takeshi Yoshino (Gerrit)

unread,

Aug 18, 2017, 5:47:20 AM8/18/17

to blink-...@chromium.org, dari...@chromium.org, jochen...@chromium.org, mac-r...@chromium.org, mlamouri+wa...@chromium.org, Mike West, Commit Bot, chromium...@chromium.org, John Abd-El-Malek, Peter Beverloo

This change is ready for review.

View Change

To view, visit change 618432. To unsubscribe, or for help writing mail filters, visit settings.

Mike West (Gerrit)

unread,

Aug 18, 2017, 6:22:20 AM8/18/17

to Takeshi Yoshino, blink-...@chromium.org, dari...@chromium.org, jochen...@chromium.org, mac-r...@chromium.org, mlamouri+wa...@chromium.org, Commit Bot, chromium...@chromium.org, John Abd-El-Malek, Peter Beverloo

LGTM. Nice cleanup!

Patch set 4:Code-Review +1

View Change

To view, visit change 618432. To unsubscribe, or for help writing mail filters, visit settings.

Takeshi Yoshino (Gerrit)

unread,

Aug 18, 2017, 7:10:29 AM8/18/17

to blink-...@chromium.org, dari...@chromium.org, jochen...@chromium.org, mac-r...@chromium.org, mlamouri+wa...@chromium.org, Mike West, Commit Bot, chromium...@chromium.org, John Abd-El-Malek, Peter Beverloo

Patch set 4:Commit-Queue +2

View Change

To view, visit change 618432. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 18, 2017, 7:14:54 AM8/18/17

to Takeshi Yoshino, blink-...@chromium.org, dari...@chromium.org, jochen...@chromium.org, mac-r...@chromium.org, mlamouri+wa...@chromium.org, Mike West, chromium...@chromium.org, John Abd-El-Malek, Peter Beverloo

Commit Bot merged this change.

View Change

Approvals:
  Mike West: Looks good to me
  Takeshi Yoshino: Commit

Remove layoutTestController, an alias to testRunner

Bug: 
Change-Id: I5a3cc233bfc3daa96f8fa5258dc2cba0d1740fa1
Reviewed-on: https://chromium-review.googlesource.com/618432
Reviewed-by: Mike West <mk...@chromium.org>
Commit-Queue: Takeshi Yoshino <tyos...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495525}
---
M content/shell/test_runner/test_runner.cc
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js
M third_party/WebKit/LayoutTests/fast/dom/adopt-attribute-crash.svg
M third_party/WebKit/LayoutTests/fast/harness/testrunner-object.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-basic-post-success-no-content-type.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-headers-origin.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-301.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-501.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cors-origin-null.html
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-no-content-type-with-text.html
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
21 files changed, 65 insertions(+), 87 deletions(-)

To view, visit change 618432. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward