Rename canMakeActivePayment to canMakePayment (issue 2545523004 by rob.buis@samsung.com)

0 views
Skip to first unread message

rob....@samsung.com

unread,
Dec 1, 2016, 5:31:00 PM12/1/16
to rou...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, har...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Reviewers: rouslan
CL: https://codereview.chromium.org/2545523004/

Message:
PTAL.

I'll fix the build error soon (I think I forgot to update BUILD.gn) but maybe
you can already have a look.

Description:
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995

Affected files (+165, -871 lines):
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
M chrome/android/java_sources.gni
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestActivePaymentQueryNoCardTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestActivePaymentQueryTest.java
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcActivePaymentQueryNoCardTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcActivePaymentQueryTest.java
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppActivePaymentQueryTest.java
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
M chrome/browser/payments/payment_request_impl.h
D chrome/test/data/android/payments/active_payment_query.js
D chrome/test/data/android/payments/active_payment_query_bobpay.js
D chrome/test/data/android/payments/active_payment_query_cc.js
A + chrome/test/data/android/payments/can_make_payment_query.js
A + chrome/test/data/android/payments/can_make_payment_query_bobpay.js
A + chrome/test/data/android/payments/can_make_payment_query_cc.js
D chrome/test/data/android/payments/payment_request_active_payment_query_bobpay_test.html
D chrome/test/data/android/payments/payment_request_active_payment_query_cc_test.html
D chrome/test/data/android/payments/payment_request_active_payment_query_test.html
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_bobpay_test.html
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_cc_test.html
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_test.html
M components/payments/payment_request.mojom
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
M third_party/WebKit/Source/modules/payments/ActivePaymentTest.cpp
A + third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
M third_party/WebKit/Source/modules/payments/PaymentRequest.h
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
M third_party/WebKit/Source/modules/payments/PaymentRequest.idl
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in


rou...@chromium.org

unread,
Dec 1, 2016, 6:48:36 PM12/1/16
to rob....@samsung.com, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, har...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
LGTM

Thank you so much for helping out here.

https://codereview.chromium.org/2545523004/

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 1, 2016, 8:31:03 PM12/1/16
to rob....@samsung.com, rou...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, har...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 1, 2016, 8:38:36 PM12/1/16
to rob....@samsung.com, rou...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, har...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/317010)

https://codereview.chromium.org/2545523004/

har...@chromium.org

unread,
Dec 1, 2016, 8:40:07 PM12/1/16
to rob....@samsung.com, rou...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
On 2016/12/02 01:38:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
> chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/317010)

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 1, 2016, 8:51:34 PM12/1/16
to rob....@samsung.com, rou...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 1, 2016, 8:59:23 PM12/1/16
to rob....@samsung.com, rou...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,

rob....@samsung.com

unread,
Dec 1, 2016, 9:14:11 PM12/1/16
to rou...@chromium.org, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Adding tsepez for mojom review.

https://codereview.chromium.org/2545523004/

rob....@samsung.com

unread,
Dec 1, 2016, 9:15:01 PM12/1/16
to rou...@chromium.org, tse...@chromium.org, s...@chromium.org, the...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Adding sky/thestig for chrome/browser/payments/payment_request_impl.h review.

https://codereview.chromium.org/2545523004/

rou...@chromium.org

unread,
Dec 1, 2016, 9:16:26 PM12/1/16
to rob....@samsung.com, tse...@chromium.org, s...@chromium.org, the...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
On 2016/12/02 02:15:00, rwlbuis wrote:
> Adding sky/thestig for chrome/browser/payments/payment_request_impl.h review.

That's not necessary. Only payment_request.mojom needs approval.

https://codereview.chromium.org/2545523004/

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 10:51:23 AM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
CQ is trying da patch. Follow status at

rou...@chromium.org

unread,
Dec 2, 2016, 10:52:40 AM12/2/16
to rob....@samsung.com, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
You might want to wait for Tom to approve payment-request.mojom first.

https://codereview.chromium.org/2545523004/

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 10:59:10 AM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,

rob....@samsung.com

unread,
Dec 2, 2016, 11:14:49 AM12/2/16
to rou...@chromium.org, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
On 2016/12/02 15:52:40, rouslan wrote:
> You might want to wait for Tom to approve payment-request.mojom first.

Right, I wanted to get buildbots green so once he approves it will go in
quickly. However I guess I have to rebase again :(

https://codereview.chromium.org/2545523004/

tse...@chromium.org

unread,
Dec 2, 2016, 12:37:28 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 1:06:29 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
CQ is trying da patch. Follow status at

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 1:14:11 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,

rob....@samsung.com

unread,
Dec 2, 2016, 1:34:46 PM12/2/16
to rou...@chromium.org, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
On 2016/12/02 02:16:26, rouslan wrote:
> On 2016/12/02 02:15:00, rwlbuis wrote:
> > Adding sky/thestig for chrome/browser/payments/payment_request_impl.h
review.
>
> That's not necessary. Only payment_request.mojom needs approval.

It does seem necessary alas. Does chrome/browser/payments need OWNERS file too
maybe?
I'll add sky for this unless you know a way around this.

https://codereview.chromium.org/2545523004/

rou...@chromium.org

unread,
Dec 2, 2016, 1:44:49 PM12/2/16
to rob....@samsung.com, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Let's ask sky for review on chrome/browser/payments/. I have not placed an
OWNERS file in there yet, because I would like desktop expert oversight when we
develop the desktop implementation of PaymentRequest UI.

https://codereview.chromium.org/2545523004/

rob....@samsung.com

unread,
Dec 2, 2016, 1:48:33 PM12/2/16
to rou...@chromium.org, tse...@chromium.org, s...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
@sky PTAL chrome/browser/payments/payment_request_impl.h change.

https://codereview.chromium.org/2545523004/

s...@chromium.org

unread,
Dec 2, 2016, 1:59:15 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
On 2016/12/02 18:48:33, rwlbuis wrote:
> @sky PTAL chrome/browser/payments/payment_request_impl.h change.

I think the ui should belong in c/b/ui/payments. So, if you want to put in
OWNERs file in c/b/payments, please do so.
chrome/browser/payments/payment_request_impl.h LGTM

https://codereview.chromium.org/2545523004/

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 2:10:47 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, s...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 6:37:36 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, s...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Committed patchset #5 (id:100001)

https://codereview.chromium.org/2545523004/

commit-bot@chromium.org via codereview.chromium.org

unread,
Dec 2, 2016, 6:39:37 PM12/2/16
to rob....@samsung.com, rou...@chromium.org, tse...@chromium.org, s...@chromium.org, commi...@chromium.org, chromium...@chromium.org, qsr+...@chromium.org, gogerald+pa...@chromium.org, a...@chromium.org, viettrung...@chromium.org, yzshen...@chromium.org, aba...@chromium.org, rouslan+...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, da...@chromium.org, sebsg+pay...@chromium.org
Patchset 5 (id:??) landed as
https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98
Cr-Commit-Position: refs/heads/master@{#436078}

https://codereview.chromium.org/2545523004/
Reply all
Reply to author
Forward
0 new messages