Add use counter for XMLHttpRequest.responseXML [chromium/src : master]

Daniel Cheng (Gerrit)

unread,

Mar 16, 2018, 3:25:03 PM3/16/18

to asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Ojan Vafai, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

This change is ready for review.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Daniel Cheng (Gerrit)

unread,

Mar 17, 2018, 2:00:12 AM3/17/18

to Kentaro Hara, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Ojan Vafai

Daniel Cheng would like Kentaro Hara to review this change.

View Change

Add use counter for XMLHttpRequest.responseXML

Bug: 822832
Change-Id: If46f840560b99b9dbc5c10ae7656df51c3083d1b
---
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl
M third_party/WebKit/public/platform/web_feature.mojom
M tools/metrics/histograms/enums.xml
3 files changed, 4 insertions(+), 1 deletion(-)

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Daniel Cheng (Gerrit)

unread,

Mar 17, 2018, 2:00:13 AM3/17/18

to asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Kentaro Hara, Commit Bot, Ojan Vafai, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

XML is a continual maintenance burden in Blink. Let's measure it and see how much it's actually still used...

View Change

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Ojan Vafai (Gerrit)

unread,

Mar 17, 2018, 12:50:17 PM3/17/18

to Daniel Cheng, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Kentaro Hara, Commit Bot, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Patch set 1:Code-Review +1

View Change

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Ojan Vafai (Gerrit)

unread,

Mar 17, 2018, 12:50:32 PM3/17/18

to Daniel Cheng, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Kentaro Hara, Commit Bot, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Patch set 1:Commit-Queue +2

View Change

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 17, 2018, 12:53:25 PM3/17/18

to Daniel Cheng, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Ojan Vafai, Kentaro Hara, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Commit Bot merged this change.

View Change

Approvals:
  Ojan Vafai: Looks good to me; Commit

Add use counter for XMLHttpRequest.responseXML

Bug: 822832
Change-Id: If46f840560b99b9dbc5c10ae7656df51c3083d1b

Reviewed-on: https://chromium-review.googlesource.com/967013
Commit-Queue: Ojan Vafai <oj...@chromium.org>
Reviewed-by: Ojan Vafai <oj...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543943}


---
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl
M third_party/WebKit/public/platform/web_feature.mojom
M tools/metrics/histograms/enums.xml
3 files changed, 4 insertions(+), 1 deletion(-)

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Kentaro Hara (Gerrit)

unread,

Mar 18, 2018, 2:55:53 AM3/18/18

to Commit Bot, Daniel Cheng, asvitki...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Ojan Vafai, Philip Rogers, Stephen Chenney, Aaron Boodman, chromium...@chromium.org, Darin Fisher

LGTM

Patch set 2:Code-Review +1

View Change

To view, visit change 967013. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward