Remove the outdated comment in ThreadDebugger [chromium/src : master]

Zhuoyu Qian (Gerrit)

unread,

Dec 14, 2017, 8:35:50 PM12/14/17

to Dmitry Gozman, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-work...@chromium.org, eae+bli...@chromium.org, falken...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, devtools...@chromium.org, Taiju Tsuiki, chromium...@chromium.org, Hiroki Nakagawa, Nate Chapin, Rob Buis, Commit Bot, Michael Nordman, Kentaro Hara, Pavel Feldman

Zhuoyu Qian uploaded patch set #4 to this change.

View Change

Remove the outdated comment in ThreadDebugger

As ThreadDebugger is well-known, not need to rename it.
Just remove the "TODO" in ThreadDebugger.h

BUG=
R=dgo...@chromium.org

Signed-off-by: Zhuoyu Qian <zhuoy...@samsung.com>
Change-Id: I777eb79936b484dacb45cc3fe42c64bb017d7c92
---
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h
1 file changed, 0 insertions(+), 1 deletion(-)

To view, visit change 826822. To unsubscribe, or for help writing mail filters, visit settings.

Dmitry Gozman (Gerrit)

unread,

Dec 15, 2017, 2:37:25 PM12/15/17

to Zhuoyu Qian, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-work...@chromium.org, eae+bli...@chromium.org, falken...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, Pavel Feldman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Nate Chapin, Michael Nordman, Hiroki Nakagawa, Rob Buis, Taiju Tsuiki

Thank you!

Patch set 4:Code-Review +1

View Change

To view, visit change 826822. To unsubscribe, or for help writing mail filters, visit settings.

Zhuoyu Qian (Gerrit)

unread,

Dec 15, 2017, 9:46:58 PM12/15/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-work...@chromium.org, eae+bli...@chromium.org, falken...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, Dmitry Gozman, Pavel Feldman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Nate Chapin, Michael Nordman, Hiroki Nakagawa, Rob Buis, Taiju Tsuiki

Patch set 4:Commit-Queue +2

View Change

To view, visit change 826822. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Dec 15, 2017, 10:55:06 PM12/15/17

to Zhuoyu Qian, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-work...@chromium.org, eae+bli...@chromium.org, falken...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, Dmitry Gozman, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Nate Chapin, Michael Nordman, Hiroki Nakagawa, Rob Buis, Taiju Tsuiki

Commit Bot merged this change.

View Change

Approvals:
  Dmitry Gozman: Looks good to me
  Zhuoyu Qian: Commit

Remove the outdated comment in ThreadDebugger

As ThreadDebugger is well-known, not need to rename it.
Just remove the "TODO" in ThreadDebugger.h

BUG=
R=dgo...@chromium.org

Signed-off-by: Zhuoyu Qian <zhuoy...@samsung.com>
Change-Id: I777eb79936b484dacb45cc3fe42c64bb017d7c92

Reviewed-on: https://chromium-review.googlesource.com/826822
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524581}


---
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h
1 file changed, 0 insertions(+), 1 deletion(-)

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 4d98dac..a9e0118 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -23,7 +23,6 @@
 class ExecutionContext;
 class SourceLocation;
 
-// TODO(dgozman): rename this to ThreadInspector (and subclasses).
 class CORE_EXPORT ThreadDebugger : public v8_inspector::V8InspectorClient,
                                    public V8PerIsolateData::Data {
  public:

To view, visit change 826822. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward