testharnessreport: Remove div[id=log] from resultant HTML. (issue 1165753005 by tkent@chromium.org)

[tk...@chromium.org]

Reviewers: jsbell,

Message:
jsbell, would you review this please?


Description:
testharnessreport: Remove div[id=log] from resultant HTML.

BUG=

Please review this at https://codereview.chromium.org/1165753005/

Base URL: svn://svn.chromium.org/blink/trunk

Affected files (+0, -42 lines):
M LayoutTests/http/tests/resources/testharnessreport.js
M LayoutTests/http/tests/w3c/resources/testharnessreport.js
M
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
D
LayoutTests/imported/web-platform-tests/html/editing/dnd/dom/specials-expected.txt
D
LayoutTests/imported/web-platform-tests/html/infrastructure/conformance-requirements/extensibility/foreign-expected.txt
D
LayoutTests/imported/web-platform-tests/html/infrastructure/terminology/plugins/text-plain-expected.txt
M LayoutTests/resources/testharnessreport.js


Index:
LayoutTests/imported/web-platform-tests/html/editing/dnd/dom/specials-expected.txt
diff --git
a/LayoutTests/imported/web-platform-tests/html/editing/dnd/dom/specials-expected.txt
b/LayoutTests/imported/web-platform-tests/html/editing/dnd/dom/specials-expected.txt
deleted file mode 100644
index
e90fa92275464a80b8932d68387e319caaf8daa7..0000000000000000000000000000000000000000
---
a/LayoutTests/imported/web-platform-tests/html/editing/dnd/dom/specials-expected.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-Enable script and reload
-This is a testharness.js-based test.
-PASS ondragstart in window
-PASS ondrag in window
-PASS ondragover in window
-PASS ondragenter in window
-PASS ondragleave in window
-PASS ondrop in window
-PASS ondragend in window
-PASS ondragstart in document
-PASS ondrag in document
-PASS ondragover in document
-PASS ondragenter in document
-PASS ondragleave in document
-PASS ondrop in document
-PASS ondragend in document
-PASS ondragstart in HTMLElement
-PASS ondrag in HTMLElement
-PASS ondragover in HTMLElement
-PASS ondragenter in HTMLElement
-PASS ondragleave in HTMLElement
-PASS ondrop in HTMLElement
-PASS ondragend in HTMLElement
-Harness: the test ran to completion.
-
Index:
LayoutTests/imported/web-platform-tests/html/infrastructure/conformance-requirements/extensibility/foreign-expected.txt
diff --git
a/LayoutTests/imported/web-platform-tests/html/infrastructure/conformance-requirements/extensibility/foreign-expected.txt
b/LayoutTests/imported/web-platform-tests/html/infrastructure/conformance-requirements/extensibility/foreign-expected.txt
deleted file mode 100644
index
3524ff575037b22b6e1a4e8a1c8376f55f44bee1..0000000000000000000000000000000000000000
---
a/LayoutTests/imported/web-platform-tests/html/infrastructure/conformance-requirements/extensibility/foreign-expected.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-Running test...
-This is a testharness.js-based test.
-PASS foreign content
-Harness: the test ran to completion.
-
Index:
LayoutTests/imported/web-platform-tests/html/infrastructure/terminology/plugins/text-plain-expected.txt
diff --git
a/LayoutTests/imported/web-platform-tests/html/infrastructure/terminology/plugins/text-plain-expected.txt
b/LayoutTests/imported/web-platform-tests/html/infrastructure/terminology/plugins/text-plain-expected.txt
deleted file mode 100644
index
eb4155352e24497e242ef528647030909c5947f0..0000000000000000000000000000000000000000
---
a/LayoutTests/imported/web-platform-tests/html/infrastructure/terminology/plugins/text-plain-expected.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-Running test...
-This is a testharness.js-based test.
-PASS A user agent must not consider the type text/plain as having a
registered plugin.
-Harness: the test ran to completion.
-
Index: LayoutTests/http/tests/resources/testharnessreport.js
diff --git a/LayoutTests/http/tests/resources/testharnessreport.js
b/LayoutTests/http/tests/resources/testharnessreport.js
index
6e35da5ae1715880635e00aab9953c2dfa84b657..6119e0d544a038d884d42c72823b269adff43f38
100644
--- a/LayoutTests/http/tests/resources/testharnessreport.js
+++ b/LayoutTests/http/tests/resources/testharnessreport.js
@@ -102,8 +102,6 @@ add_completion_callback(function (tests,
harness_status) {
// Assume it's a CSSWG style test, and anything other than
the log div isn't
// material to the testrunner output, so should be hidden
from the text dump
for (var i = 0; i < document.body.children.length; i++) {
- if (document.body.children[i] === logDiv) continue;
-
document.body.children[i].style.visibility = "hidden";
}
}
Index: LayoutTests/http/tests/w3c/resources/testharnessreport.js
diff --git a/LayoutTests/http/tests/w3c/resources/testharnessreport.js
b/LayoutTests/http/tests/w3c/resources/testharnessreport.js
index
6e35da5ae1715880635e00aab9953c2dfa84b657..6119e0d544a038d884d42c72823b269adff43f38
100644
--- a/LayoutTests/http/tests/w3c/resources/testharnessreport.js
+++ b/LayoutTests/http/tests/w3c/resources/testharnessreport.js
@@ -102,8 +102,6 @@ add_completion_callback(function (tests,
harness_status) {
// Assume it's a CSSWG style test, and anything other than
the log div isn't
// material to the testrunner output, so should be hidden
from the text dump
for (var i = 0; i < document.body.children.length; i++) {
- if (document.body.children[i] === logDiv) continue;
-
document.body.children[i].style.visibility = "hidden";
}
}
Index:
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
diff --git
a/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
b/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
index
1eca51ac7914b020644f12adea12d27a34ec29ec..2bed17e13f38af533b6d8c604fbc7fb5a8fad673
100644
---
a/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
+++
b/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
@@ -1,4 +1,3 @@
-It looks like the browser stopped loading the page when encountering
a .go(-1) command pointing to a pushed state. This will break the tests.
This is a testharness.js-based test.
PASS history.state should initially be null
PASS history.pushState support is needed for this testcase
Index: LayoutTests/resources/testharnessreport.js
diff --git a/LayoutTests/resources/testharnessreport.js
b/LayoutTests/resources/testharnessreport.js
index
6e35da5ae1715880635e00aab9953c2dfa84b657..6119e0d544a038d884d42c72823b269adff43f38
100644
--- a/LayoutTests/resources/testharnessreport.js
+++ b/LayoutTests/resources/testharnessreport.js
@@ -102,8 +102,6 @@ add_completion_callback(function (tests,
harness_status) {
// Assume it's a CSSWG style test, and anything other than
the log div isn't
// material to the testrunner output, so should be hidden
from the text dump
for (var i = 0; i < document.body.children.length; i++) {
- if (document.body.children[i] === logDiv) continue;
-
document.body.children[i].style.visibility = "hidden";
}
}

[jsb...@chromium.org]

lgtm




https://codereview.chromium.org/1165753005/diff/20001/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
File
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
(left):

https://codereview.chromium.org/1165753005/diff/20001/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt#oldcode1
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt:1:

It looks like the browser stopped loading the page when encountering a
.go(-1) command pointing to a pushed state. This will break the tests.

Is this bogus, anything we need to investigate, or is it covered by
existing bugs or test cases below?

https://codereview.chromium.org/1165753005/

[tk...@chromium.org]

https://codereview.chromium.org/1165753005/diff/20001/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
File
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt
(left):

https://codereview.chromium.org/1165753005/diff/20001/LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt#oldcode1
LayoutTests/imported/web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt:1:
It looks like the browser stopped loading the page when encountering a
.go(-1) command pointing to a pushed state. This will break the tests.

On 2015/06/02 17:34:21, jsbell wrote:
> Is this bogus, anything we need to investigate, or is it covered by
existing
> bugs or test cases below?

I think the FAIL lines are due to this behavior. I'll revisit all of
FAILs in -expected.txt later.

https://codereview.chromium.org/1165753005/

['commit-bot: I haz the power' via codereview.chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1165753005/20001


https://codereview.chromium.org/1165753005/

['commit-bot: I haz the power' via codereview.chromium.org]

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196345

https://codereview.chromium.org/1165753005/