bindings: Use IDL dictionary to implement FontFaceSetLoadEventInit (issue 1159403005 by bashi@chromium.org)

0 views
Skip to first unread message

ba...@chromium.org

unread,
Jun 2, 2015, 12:59:17 AM6/2/15
to har...@chromium.org, ksak...@chromium.org, blink-...@chromium.org, arv+...@chromium.org, vive...@samsung.com, blink-re...@chromium.org, eae+bli...@chromium.org, viv...@chromium.org, dglazko...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, ch.d...@samsung.com, alexis...@intel.com, apavlo...@chromium.org, rob....@samsung.com
Reviewers: haraken, Kunihiko Sakamoto,

Message:
PTAL?

Since FontFaceSetLoadEvent is [NoInterfaceObject] we don't have any layout
tests
for the constructor. Per the spec, it should be exposed, but I guess that we
need to send an intent-to-ship before exposing FontFaceSetLoadEvent.
Exposing
the event isn't the purpose of this CL so I didn't remove
[NoInterfaceObject].

Description:
bindings: Use IDL dictionary to implement FontFaceSetLoadEventInit

This CL also adds an empty array default value ("[]") in IDL dictionary
as FontFaceSetLoadEventInit requires it.

BUG=433179

Please review this at https://codereview.chromium.org/1159403005/

Base URL: svn://svn.chromium.org/blink/trunk

Affected files (+117, -8 lines):
M Source/bindings/scripts/v8_types.py
M Source/bindings/tests/idls/core/TestDictionary.idl
M Source/bindings/tests/results/core/TestDictionary.h
M Source/bindings/tests/results/core/TestDictionary.cpp
M Source/bindings/tests/results/core/V8TestDictionary.cpp
M Source/core/core.gypi
M Source/core/css/FontFaceSetLoadEvent.h
M Source/core/css/FontFaceSetLoadEvent.cpp
A + Source/core/css/FontFaceSetLoadEventInit.idl


har...@chromium.org

unread,
Jun 2, 2015, 1:09:23 AM6/2/15
to ba...@chromium.org, ksak...@chromium.org, blink-...@chromium.org, arv+...@chromium.org, vive...@samsung.com, blink-re...@chromium.org, eae+bli...@chromium.org, viv...@chromium.org, dglazko...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, ch.d...@samsung.com, alexis...@intel.com, apavlo...@chromium.org, rob....@samsung.com

ksak...@chromium.org

unread,
Jun 2, 2015, 1:15:19 AM6/2/15
to ba...@chromium.org, har...@chromium.org, blink-...@chromium.org, arv+...@chromium.org, vive...@samsung.com, blink-re...@chromium.org, eae+bli...@chromium.org, viv...@chromium.org, dglazko...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, ch.d...@samsung.com, alexis...@intel.com, apavlo...@chromium.org, rob....@samsung.com

'commit-bot: I haz the power' via codereview.chromium.org

unread,
Jun 2, 2015, 1:21:49 AM6/2/15
to ba...@chromium.org, har...@chromium.org, ksak...@chromium.org, commi...@chromium.org, blink-...@chromium.org, arv+...@chromium.org, vive...@samsung.com, blink-re...@chromium.org, eae+bli...@chromium.org, viv...@chromium.org, dglazko...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, ch.d...@samsung.com, alexis...@intel.com, apavlo...@chromium.org, rob....@samsung.com

'commit-bot: I haz the power' via codereview.chromium.org

unread,
Jun 2, 2015, 4:15:28 AM6/2/15
to ba...@chromium.org, har...@chromium.org, ksak...@chromium.org, commi...@chromium.org, blink-...@chromium.org, arv+...@chromium.org, vive...@samsung.com, blink-re...@chromium.org, eae+bli...@chromium.org, viv...@chromium.org, dglazko...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, ch.d...@samsung.com, alexis...@intel.com, apavlo...@chromium.org, rob....@samsung.com
Reply all
Reply to author
Forward
0 new messages