Tidy up canvas code after ImageBuffer is removed [chromium/src : master]

0 views
Skip to first unread message

Olivia Lai (Gerrit)

unread,
Mar 16, 2018, 6:01:43 PM3/16/18
to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Justin Novosad, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

This change is ready for review.

Patch set 5:Commit-Queue +1

View Change

    To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
    Gerrit-Change-Number: 967252
    Gerrit-PatchSet: 5
    Gerrit-Owner: Olivia Lai <xl...@chromium.org>
    Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
    Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
    Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-Comment-Date: Fri, 16 Mar 2018 22:01:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Justin Novosad (Gerrit)

    unread,
    Mar 17, 2018, 2:22:38 AM3/17/18
    to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

    I have issues with how a lot of the new identifiers are named. Otherwise, looks good.

    View Change

    16 comments:

    To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
    Gerrit-Change-Number: 967252
    Gerrit-PatchSet: 5
    Gerrit-Owner: Olivia Lai <xl...@chromium.org>
    Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
    Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Mar 2018 06:22:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Olivia Lai (Gerrit)

    unread,
    Mar 19, 2018, 3:00:30 PM3/19/18
    to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Justin Novosad, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

    Mass renaming done.

    Patch set 6:Commit-Queue +1

    View Change

    15 comments:

      • I'd rather this be called GetCanvas2DLayerBridge (uses the class name)

      • GetOrCreateCanvasResourceProviderForWebGL

        Done

      • Patch Set #5, Line 224: al void Trace(blink::Visitor*

        CreateCanvas2DLayerBridgeForTesting

        Done

      • The old name was better IMHO.

      • I think you mean CanvasResourceProvider.

      • Done

    To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
    Gerrit-Change-Number: 967252
    Gerrit-PatchSet: 6
    Gerrit-Owner: Olivia Lai <xl...@chromium.org>
    Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
    Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Mar 2018 19:00:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Justin Novosad <ju...@chromium.org>
    Gerrit-MessageType: comment

    Justin Novosad (Gerrit)

    unread,
    Mar 19, 2018, 3:01:53 PM3/19/18
    to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

    Patch set 6:Code-Review +1

    View Change

      To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
      Gerrit-Change-Number: 967252
      Gerrit-PatchSet: 6
      Gerrit-Owner: Olivia Lai <xl...@chromium.org>
      Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
      Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-Comment-Date: Mon, 19 Mar 2018 19:01:48 +0000

      Olivia Lai (Gerrit)

      unread,
      Mar 19, 2018, 4:40:30 PM3/19/18
      to Olivia Lai, Justin Novosad, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, Dongseong Hwang, Xida Chen, Commit Bot, Kentaro Hara

      Olivia Lai uploaded patch set #9 to this change.

      View Change

      Tidy up canvas code after ImageBuffer is removed

      This CL cleans up code in canvas/OffscreenCanvas and their rendering contexts
      in a world after ImageBuffer has been removed. It does the following:

      - Renamed certain functions/variables to avoid misleading future readers.
      - Split CreateImageBuffer into two functions, one for creating
        Canvas2dLayerBridge in 2d context, another for creating resourceProvider for
        webgl in webgl context. It was unnecessary and misleading to lump these two
        unrelated operations together.
      - Drive-by deletion of some unused code.


      TBR=z...@chromium.org
      Bug: 776806
      Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
      ---
      M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
      M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextHost.h
      M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
      M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
      M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
      M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
      M third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
      M third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
      M third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.h
      M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.cpp
      M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.h
      M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
      M third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
      M third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
      M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
      M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
      16 files changed, 188 insertions(+), 223 deletions(-)

      To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
      Gerrit-Change-Number: 967252
      Gerrit-PatchSet: 9
      Gerrit-Owner: Olivia Lai <xl...@chromium.org>
      Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
      Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-MessageType: newpatchset

      Olivia Lai (Gerrit)

      unread,
      Mar 19, 2018, 4:40:48 PM3/19/18
      to Zhenyao Mo, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Olivia Lai, Justin Novosad

      Olivia Lai would like Zhenyao Mo to review this change.

      Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-MessageType: newchange

      Olivia Lai (Gerrit)

      unread,
      Mar 19, 2018, 4:41:48 PM3/19/18
      to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Zhenyao Mo, Justin Novosad, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

      Patch set 9:Commit-Queue +2

      View Change

        To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
        Gerrit-Change-Number: 967252
        Gerrit-PatchSet: 9
        Gerrit-Owner: Olivia Lai <xl...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
        Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Xida Chen <xida...@chromium.org>
        Gerrit-Comment-Date: Mon, 19 Mar 2018 20:41:47 +0000

        Commit Bot (Gerrit)

        unread,
        Mar 19, 2018, 4:41:55 PM3/19/18
        to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Zhenyao Mo, Justin Novosad, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

        CQ is trying the patch.

        Note: The patchset sent to CQ was uploaded after this CL was approved.
        "Edit commit message" https://chromium-review.googlesource.com/c/967252/9

        Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/967252/9

        Bot data: {"action": "start", "triggered_at": "2018-03-19T20:41:47.0Z", "cq_cfg_revision": "5b6c43e4d6b0297aa92e118e785d640c42297271", "revision": "beb8760f9f5f9e43563285bd5f75f0548708b012"}

        View Change

          To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: master
          Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
          Gerrit-Change-Number: 967252
          Gerrit-PatchSet: 9
          Gerrit-Owner: Olivia Lai <xl...@chromium.org>
          Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
          Gerrit-Reviewer: Olivia Lai <xl...@chromium.org>
          Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org>
          Gerrit-CC: Commit Bot <commi...@chromium.org>
          Gerrit-CC: Dongseong Hwang <dongseo...@intel.com>
          Gerrit-CC: Kentaro Hara <har...@chromium.org>
          Gerrit-CC: Xida Chen <xida...@chromium.org>
          Gerrit-Comment-Date: Mon, 19 Mar 2018 20:41:54 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          Gerrit-MessageType: comment

          Commit Bot (Gerrit)

          unread,
          Mar 19, 2018, 6:38:34 PM3/19/18
          to Olivia Lai, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, Zhenyao Mo, Justin Novosad, chromium...@chromium.org, Dongseong Hwang, Kentaro Hara, Xida Chen

          Commit Bot merged this change.

          View Change

          Approvals: Justin Novosad: Looks good to me Olivia Lai: Commit 
          Tidy up canvas code after ImageBuffer is removed

          This CL cleans up code in canvas/OffscreenCanvas and their rendering contexts
          in a world after ImageBuffer has been removed. It does the following:

          - Renamed certain functions/variables to avoid misleading future readers.
          - Split CreateImageBuffer into two functions, one for creating
            Canvas2dLayerBridge in 2d context, another for creating resourceProvider for
            webgl in webgl context. It was unnecessary and misleading to lump these two
            unrelated operations together.
          - Drive-by deletion of some unused code.


          TBR=z...@chromium.org

          Bug: 776806
          Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
          Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6
          Reviewed-on: https://chromium-review.googlesource.com/967252
          Commit-Queue: Olivia Lai <xl...@chromium.org>
          Reviewed-by: Justin Novosad <ju...@chromium.org>
          Cr-Commit-Position: refs/heads/master@{#544190}

          ---
          M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
          M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextHost.h
          M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
          M third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
          M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
          M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
          M third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
          M third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
          M third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.h
          M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.cpp
          M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.h
          M third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
          M third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
          M third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
          M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
          M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
          16 files changed, 188 insertions(+), 223 deletions(-)


          To view, visit change 967252. To unsubscribe, or for help writing mail filters, visit settings.
          


           Gerrit-Project: chromium/src 
          

           Gerrit-Branch: master 
          

           Gerrit-Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6 
          

           Gerrit-Change-Number: 967252 
          

           Gerrit-PatchSet: 10 
          

           Gerrit-Owner: Olivia Lai <xl...@chromium.org> 
          

           Gerrit-Reviewer: Commit Bot <commi...@chromium.org> 
          

           Gerrit-Reviewer: Justin Novosad <ju...@chromium.org> 
          

           Gerrit-Reviewer: Olivia Lai <xl...@chromium.org> 
          

           Gerrit-Reviewer: Zhenyao Mo <z...@chromium.org> 
          

           Gerrit-CC: Dongseong Hwang <dongseo...@intel.com> 
          

           Gerrit-CC: Kentaro Hara <har...@chromium.org> 
          

           Gerrit-CC: Xida Chen <xida...@chromium.org> 
          


           Gerrit-MessageType: merged 
          


          Reply all
          Reply to author
          Forward
          0 new messages