Whitelist IDL methods/attributes that return Elements/Nodes [chromium/src : master]

Erik Luo (Gerrit)

unread,

Apr 23, 2018, 9:54:45 PM4/23/18

to Yuki Shiino, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Kentaro Hara

Erik Luo would like Yuki Shiino to review this change.

View Change

Whitelist IDL methods/attributes that return Elements/Nodes

This CL marks methods and attributes that produce no
JS-observable side-effect and have return type Element, Node,
HTMLCollection, NodeList, or a derived type.

Bug: 829571
Change-Id: Ia1d7def24fae8764620f80f3f46f8454de976ce4
---
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/side-effects/evaluate-embedder-side-effect-free-attributes.js
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/side-effects/evaluate-embedder-side-effect-free-methods.js
M third_party/blink/renderer/core/dom/document.idl
M third_party/blink/renderer/core/dom/document_or_shadow_root.idl
M third_party/blink/renderer/core/dom/element.idl
M third_party/blink/renderer/core/dom/node.idl
M third_party/blink/renderer/core/dom/parent_node.idl
7 files changed, 76 insertions(+), 30 deletions(-)

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Apr 23, 2018, 9:54:46 PM4/23/18

to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Yuki Shiino, Kentaro Hara, chromium...@chromium.org, devtools...@chromium.org, Hayato Ito, Joseph Medley, Rob Buis

Please take a look.

This chain of 5 CLs should include almost all the callbacks I planned to whitelist (excluding Native/LazyDataAttributes). All 5 CLs should be ready for review, and are mostly independent, but I made this one the first because I think these are the most important attributes/methods for DevTools.

View Change

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Kentaro Hara (Gerrit)

unread,

Apr 23, 2018, 10:07:38 PM4/23/18

to Erik Luo, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Yuki Shiino, chromium...@chromium.org, devtools...@chromium.org, Hayato Ito, Joseph Medley, Rob Buis

LGTM

Patch set 2:Code-Review +1

View Change

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Yuki Shiino (Gerrit)

unread,

Apr 24, 2018, 2:15:39 AM4/24/18

to Erik Luo, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Kentaro Hara, chromium...@chromium.org, devtools...@chromium.org, Hayato Ito, Joseph Medley, Rob Buis

LGTM.

Patch set 2:Code-Review +1

View Change

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Apr 24, 2018, 2:44:10 AM4/24/18

to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Yuki Shiino, Kentaro Hara, chromium...@chromium.org, devtools...@chromium.org, Hayato Ito, Joseph Medley, Rob Buis

Thank you, landing

Patch set 2:Commit-Queue +2

View Change

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Apr 24, 2018, 4:42:31 AM4/24/18

to Erik Luo, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, eae+bli...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Yuki Shiino, Kentaro Hara, chromium...@chromium.org, devtools...@chromium.org, Hayato Ito, Joseph Medley, Rob Buis

Commit Bot merged this change.

View Change

Approvals:
  Yuki Shiino: Looks good to me
  Kentaro Hara: Looks good to me
  Erik Luo: Commit

Whitelist IDL methods/attributes that return Elements/Nodes

This CL marks methods and attributes that produce no
JS-observable side-effect and have return type Element, Node,
HTMLCollection, NodeList, or a derived type.

Bug: 829571
Change-Id: Ia1d7def24fae8764620f80f3f46f8454de976ce4

Reviewed-on: https://chromium-review.googlesource.com/1025170
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Commit-Queue: Erik Luo <lu...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553036}


---
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/side-effects/evaluate-embedder-side-effect-free-attributes.js
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/side-effects/evaluate-embedder-side-effect-free-methods.js
M third_party/blink/renderer/core/dom/document.idl
M third_party/blink/renderer/core/dom/document_or_shadow_root.idl
M third_party/blink/renderer/core/dom/element.idl
M third_party/blink/renderer/core/dom/node.idl
M third_party/blink/renderer/core/dom/parent_node.idl
7 files changed, 76 insertions(+), 30 deletions(-)

To view, visit change 1025170. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward