[scheduler] Use hard-coded tracing categories. (issue 2846533002 by altimin@chromium.org)

0 views
Skip to first unread message

alt...@chromium.org

unread,
Apr 26, 2017, 9:42:13 AM4/26/17
to skyo...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, dglazko...@chromium.org, schedul...@chromium.org, blink-re...@chromium.org
Reviewers: Sami
CL: https://codereview.chromium.org/2846533002/

Message:
PTAL

Description:
[scheduler] Use hard-coded tracing categories.

R=skyo...@chromium.org

Affected files (+145, -280 lines):
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
M third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
M third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
M third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc
M third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc
M third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.h
M third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.cc
M third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
M third_party/WebKit/Source/platform/scheduler/child/idle_helper.h
M third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc
M third_party/WebKit/Source/platform/scheduler/child/idle_helper_unittest.cc
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
M third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
M third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h


alt...@chromium.org

unread,
Apr 26, 2017, 10:36:51 AM4/26/17
to skyo...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, dglazko...@chromium.org, schedul...@chromium.org, blink-re...@chromium.org
On 2017/04/26 13:42:13, altimin wrote:
> PTAL

You're right, this solves the problem with TaskQueueManager missing from the
trace.

https://codereview.chromium.org/2846533002/

skyostil@chromium.org via codereview.chromium.org

unread,
Apr 26, 2017, 11:43:42 AM4/26/17
to altimi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, dglazko...@chromium.org, schedul...@chromium.org, blink-re...@chromium.org
lgtm, thanks for taking care of this!

https://codereview.chromium.org/2846533002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Apr 26, 2017, 1:33:06 PM4/26/17
to altimi...@chromium.org, skyo...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, dglazko...@chromium.org, schedul...@chromium.org, blink-re...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Apr 26, 2017, 1:48:28 PM4/26/17
to altimi...@chromium.org, skyo...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, dglazko...@chromium.org, schedul...@chromium.org, blink-re...@chromium.org
Reply all
Reply to author
Forward
0 new messages