Replace WTF::RefPtr with scoped_refptr in core/worker [chromium/src : master]
0 views
Skip to first unread message
Taiju Tsuiki (Gerrit)
Oct 19, 2017, 8:19:17 AM10/19/17
to blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Hiroki Nakagawa, Commit Bot, chromium...@chromium.org
Matt Falkenhagen (Gerrit)
Oct 19, 2017, 11:48:50 AM10/19/17
to Taiju Tsuiki, blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Hiroki Nakagawa, Commit Bot, chromium...@chromium.org
Patch set 1:Code-Review +1
1 comment:
File third_party/WebKit/Source/core/workers/DedicatedWorker.h:
Patch Set #1, Line 16:
#include "platform/wtf/RefPtr.h"Just to make sure, you plan to change the header to base/ref_ptr.h later?
To view, visit change 727446. To unsubscribe, or for help writing mail filters, visit settings.
Matt Falkenhagen (Gerrit)
Oct 19, 2017, 11:49:08 AM10/19/17
to Taiju Tsuiki, blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Hiroki Nakagawa, Commit Bot, chromium...@chromium.org
Ha, I just realized I'm not an owner of core/workers. Sorry.
Taiju Tsuiki (Gerrit)
Oct 19, 2017, 12:39:59 PM10/19/17
to blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Matt Falkenhagen, Hiroki Nakagawa, Commit Bot, chromium...@chromium.org
1 comment:
Patch Set #1, Line 16:
#include "platform/wtf/RefPtr.h"
Just to make sure, you plan to change the header to base/ref_ptr. […]
Eventually yes, but not now. As we currently ban all base:: stuff in core/ and modules/, we need to bring AdoptRef() and WrapRefPtr() from base to WTF for a while.
To view, visit change 727446. To unsubscribe, or for help writing mail filters, visit settings.
Hiroki Nakagawa (Gerrit)
Oct 19, 2017, 9:53:36 PM10/19/17
to Taiju Tsuiki, blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Matt Falkenhagen, Commit Bot, chromium...@chromium.org
Taiju Tsuiki (Gerrit)
Oct 20, 2017, 2:47:30 AM10/20/17
to blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Hiroki Nakagawa, Matt Falkenhagen, Commit Bot, chromium...@chromium.org
Patch set 1:Commit-Queue +2
Commit Bot (Gerrit)
Oct 20, 2017, 2:54:18 AM10/20/17
to Taiju Tsuiki, blink-...@chromium.org, blink-work...@chromium.org, falken...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org, shimazu...@chromium.org, Hiroki Nakagawa, Matt Falkenhagen, chromium...@chromium.org
Commit Bot merged this change.
Approvals:
Matt Falkenhagen: Looks good to me
Hiroki Nakagawa: Looks good to me
Taiju Tsuiki: Commit
Replace WTF::RefPtr with scoped_refptr in core/worker
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of
scoped_refptr for migration. This CL inlines the alias to the RefPtr
users in core/worker to remove RefPtr.
Bug: 763844
Change-Id: I0667d2c0cc9c73b23ed60a6ce3f685518ff599da
Reviewed-on: https://chromium-review.googlesource.com/727446
Reviewed-by: Matt Falkenhagen <fal...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Commit-Queue: Taiju Tsuiki <tz...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510363}
---
M third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
M third_party/WebKit/Source/core/workers/DedicatedWorker.h
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h
M third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
M third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
M third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
M third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
M third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.h
M third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
M third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
M third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
M third_party/WebKit/Source/core/workers/Worklet.cpp
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
M third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
M third_party/WebKit/Source/core/workers/WorkletModuleResponsesMapProxy.cpp
M third_party/WebKit/Source/core/workers/WorkletModuleResponsesMapProxy.h
M third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.cpp
M third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h
32 files changed, 83 insertions(+), 78 deletions(-)
Reply all
Reply to author
Forward
0 new messages