Re: Add "StaleWhileRevalidate" runtime flag. (issue 1031493002 by yhirano@chromium.org)

0 views
Skip to first unread message

yhi...@chromium.org

unread,
Mar 30, 2015, 7:11:36 AM3/30/15
to ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
+tkent for OWNER review.

https://codereview.chromium.org/1031493002/

tk...@chromium.org

unread,
Mar 30, 2015, 7:09:19 PM3/30/15
to yhi...@chromium.org, ri...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
I can't image what's this flag is for. What's stale? What's revalidated?
Is
it related to WebScoket, XHR, or Fetch API?


https://codereview.chromium.org/1031493002/

yhi...@chromium.org

unread,
Mar 30, 2015, 8:51:53 PM3/30/15
to ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org

yhi...@chromium.org

unread,
Mar 30, 2015, 8:52:06 PM3/30/15
to ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
On 2015/03/31 00:51:52, yhirano wrote:
> On 2015/03/30 23:09:19, tkent wrote:
> > I can't image what's this flag is for. What's stale? What's
> revalidated?
Is
> > it related to WebScoket, XHR, or Fetch API?

I updated the description.

https://codereview.chromium.org/1031493002/

tk...@chromium.org

unread,
Mar 30, 2015, 8:56:05 PM3/30/15
to yhi...@chromium.org, ri...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
On 2015/03/31 00:52:06, yhirano wrote:
> On 2015/03/31 00:51:52, yhirano wrote:
> > On 2015/03/30 23:09:19, tkent wrote:
> > > I can't image what's this flag is for. What's stale? What's
> revalidated?

> Is
> > > it related to WebScoket, XHR, or Fetch API?

> I updated the description.

Thanks. I'd like to name it "HTTPStaleWhileRevalidate," or something to
represent the Blink cache behavior change by the flag.



https://codereview.chromium.org/1031493002/

yhi...@chromium.org

unread,
Mar 30, 2015, 9:11:56 PM3/30/15
to ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
How about StaleWhileRevalidateCacheControl? I don't like adding "HTTP"
prefix
because the first character will be uncapitalized automatically.

https://codereview.chromium.org/1031493002/

tk...@chromium.org

unread,
Mar 30, 2015, 9:15:29 PM3/30/15
to yhi...@chromium.org, ri...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
> How about StaleWhileRevalidateCacheControl? I don't like adding "HTTP"
> prefix
> because the first character will be uncapitalized automatically.

It sounds good.


https://codereview.chromium.org/1031493002/

yhi...@chromium.org

unread,
Mar 31, 2015, 2:50:05 AM3/31/15
to ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
On 2015/03/31 01:15:28, tkent wrote:
> > How about StaleWhileRevalidateCacheControl? I don't like adding "HTTP"
prefix
> > because the first character will be uncapitalized automatically.

> It sounds good.

Renamed. PTAL.

https://codereview.chromium.org/1031493002/

tk...@chromium.org

unread,
Mar 31, 2015, 2:54:53 AM3/31/15
to yhi...@chromium.org, ri...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
lgtm



https://codereview.chromium.org/1031493002/

commi...@chromium.org

unread,
Mar 31, 2015, 2:55:19 AM3/31/15
to yhi...@chromium.org, ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1031493002/20001


https://codereview.chromium.org/1031493002/

commi...@chromium.org

unread,
Mar 31, 2015, 4:42:50 AM3/31/15
to yhi...@chromium.org, ri...@chromium.org, tk...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192812

https://codereview.chromium.org/1031493002/
Reply all
Reply to author
Forward
0 new messages