Last week in Style and Animations

79 views
Skip to first unread message

Eddy Mead

unread,
Aug 30, 2016, 3:06:13 AM8/30/16
to style-dev
(bcc blink-dev)

The Style team is a group of engineers, working at Google (Sydney and Tokyo), Opera (Oslo) and Samsung (Boston). We are tasked with improving the style engine in Blink. Our responsibility is to maintain and improve style resolution and application (core/css/resolver, core/style), as well as the other parts of CSS (core/css).

The Animations team is a group of engineers in Google Sydney who maintain and improve the main thread animations system in Blink (core/animation). We are also responsible for the Web Animations javascript polyfill, and work with Google Waterloo on compositor thread animations (cc/animation).

The Style and Animations teams together triage bugs labelled as Blink>CSS and Blink>Animation.

Updates from the last week (22 August - 28 August, 2016):


Style (contact: me...@chromium.org)

  • Discussion of LayoutNG with @eae and @ikilpatrick

  • Splitting up Style Resolution and Layout Tree Construction (bugsnash@ and nainar@)

    • Set ComputedStyle on Node and use that in buildOwnLayout() - worked on test failures

    • Remove redundant ComputedStyles in OptionElement and OptGroupElement - worked on fixing crashes

  • Buffy (nainar@)

    • Met with @rbyers and @foolip to discuss Style team's Interop efforts

    • Sent out follow up email summary to everyone on Style team

    • Started working on a final resting place for all Buffy learnings, etc

  • Non-Interop triage (nainar@)

    • Logging bug numbers over the days

    • Set up a spreadsheet to track the work on Performance bugs

    • First session going through Performance bugs with @timloh

    • Started working on a document highlighting the process for others on the team to follow.

  • Continued refactoring of invalidation set extraction and landed fixes for 639561, 638869, 284142, 641296. Fix for 636500 in review (rune)

  • Typed OM

    • Landed CL to allow StylePropertyMap::get on properties with list or number types (meade)

    • Finished implementation for getting CSSTokenStreamValue from inline StylePropertyMap (anthonyhkf)

    • Made CSSImageValue object in Polyfill (anthonyhkf)


Animations (contact: su...@chromium.org)

  • Experimented with restructuring StyleResolver for applying custom properties via animations (alancutter)

  • CSS motion-path implementation updates ongoing (ericwilligers)

  • Compositor animations - Implemented optimization on animations commit, which was then reverted (loyso)

Eddy Mead

unread,
Sep 6, 2016, 2:28:32 AM9/6/16
to style-dev
(bcc blink-dev)

The Style team is a group of engineers, working at Google (Sydney and Tokyo), Opera (Oslo) and Samsung (Boston). We are tasked with improving the style engine in Blink. Our responsibility is to maintain and improve style resolution and application (core/css/resolver, core/style), as well as the other parts of CSS (core/css).

The Animations team is a group of engineers in Google Sydney who maintain and improve the main thread animations system in Blink (core/animation). We are also responsible for the Web Animations javascript polyfill, and work with Google Waterloo on compositor thread animations (cc/animation).

The Style and Animations teams together triage bugs labelled as Blink>CSS and Blink>Animation.

Updates from the last week (29 August - 4 September, 2016):


Style (contact: me...@chromium.org)

    • Splitting up Style Resolution and Layout Tree Construction (bugsnash@ and nainar@)

    • Made invalidation set extraction refactoring ready for review (rune)

    • Fixed MatchedPropertiesCache assertion failure (rune)

    • Fixed :-webkit-any() invalidation set bug (rune)

    • Finally landing (in progress) RuleSet diffing for active stylesheets (rune)

    • Started working on 624139 which needs to be resolved for async active stylesheets (rune)

    • Discussed approach and potential problems about implementing display:contents in Blink (required for a correct implementation of <slot>) with mste...@opera.com.  Will make some notes and distribute (rune)

    • Introduced and fixed a bug in setting a custom property as a named property (timloh)

    • Uploaded first patch for CSS Properties and Values API (timloh)

    • Fixed regression in update_style benchmark, merged to M54 (jfernandez)

    • TypedOM:

      • Landed CL for getting CSSURLImageValue from StyleMap (anthonyhkf)

      • Landed CL for getting CSSUnparsedValue (formerly CSSTokenStreamValue) from StyleMap (anthonyhkf)


    Animations (contact: su...@chromium.org)

    • Created working prototype for applying custom properties via animations (alancutter)

    • CSS motion-path implementation updates continue (ericwilligers)

    • Compositor animations - Fixing 599484 to land the optimization from last week. CL. (loyso)

    Eddy Mead

    unread,
    Sep 13, 2016, 1:40:56 AM9/13/16
    to style-dev
    (bcc blink-dev)

    The Style team is a group of engineers, working at Google (Sydney and Tokyo), Opera (Oslo) and Samsung (Boston). We are tasked with improving the style engine in Blink. Our responsibility is to maintain and improve style resolution and application (core/css/resolver, core/style), as well as the other parts of CSS (core/css).

    The Animations team is a group of engineers in Google Sydney who maintain and improve the main thread animations system in Blink (core/animation). We are also responsible for the Web Animations javascript polyfill, and work with Google Waterloo on compositor thread animations (cc/animation).

    The Style and Animations teams together triage bugs labelled as Blink>CSS and Blink>Animation.

    Updates from the last week (5 August - 11 September, 2016):


    Style (contact: me...@chromium.org)

    • Splitting up Style Resolution and Layout Tree Construction (bugsnash and nainar)

      • Investigating a lonely crash in fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html - seems like the CITE node is Laying out different as compared to before. Investigating why?

      • Worked on ComputedStyle storage logic inside ElementRareData https://codereview.chromium.org/2293713002

        • Completed unit test

        • Investigated ElementRareData::clearComputedStyle usage

    • Triaged label:Performance and Type=Feature bugs. Started writing and evaluating a process to triage these bugs. (meade, sashab, timloh, nainar)

    • CSS Property And Values API - landed first patch, implemented non-inherited properties locally (timloh)

    • Started uploading and landing async stylesheet update CLs: inspector stylesheet changes and invalidation set changes. (rune)

    • More invalidation set refactoring. (rune)

    • Wrote up and distributed display:contents intent draft. (rune)

    • Typed OM (meade and rjwright):

      • Fixed a crash caused by an unimplemented case in getting CSSTransformValues from StylePropertyMaps (meade)

      • Started re-implementing computed StylePropertyMap to be consistent with the spec instead of wrapping the current implementation (rjwright)


    Animations (contact: su...@chromium.org)

    • We're excited to note that the Safari Technology Preview release 12 has some support for the Web Animations API: https://developer.apple.com/safari/technology-preview/release-notes/#r12  \o/

    • Motion path (ericwilligers, suzyh) - Continuing with implementation updates and strategy discussion about property renaming

    • Custom properties in keyframes (alancutter) - Implemented animation-tainting, completed performance testing on the prototype implementation

    • Compositor animations (loyso) - Relanded optimization for cc/animation commit process. Started to move animations ownership from ElementAnimations to AnimationPlayer (http://crbug.com/592873)
    Reply all
    Reply to author
    Forward
    0 new messages