PSA: introducing core/script

[Hiroshige Hayashizaki]

Hi,

I'm going to introduce a new directory core/script that contains script-related files in Blink, and

move files (mostly from core/dom) to core/script.

This effort is initiated by kochi@ to improve core/dom responsibility.

Quoting kochi@'s initial e-mail in loading-dev:

As a part of reorganizing core/dom files, we identified some of the files are more
related to script execution or ES6 modules rather than pure DOM implementation,
and we'd like to propose creating a "core/script" directory and move files there. 

 

The merit of having the separate directory is a clear separation of responsibility
between dom and script execution, and the ownership of script related classes
will be clarified.

I'd like to move the files around the end of 2017.

To avoid rebasing pending CLs, I'll wait for CLs (including mine) that modify heavily the files to be moved, so please let me know if you have such CLs.

Design Doc:

https://docs.google.com/presentation/d/1H-1U9LmCghOmviw0nYE_SP_r49-bU42SkViBn539-vg/edit

Draft CL:

https://chromium-review.googlesource.com/c/chromium/src/+/808750

Discussion at loading-dev:

https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/loading-dev/GYPCLAsvpo4

List of files to be moved:

core/dom/ClassicPendingScript.cpp

core/dom/ClassicPendingScript.h

core/dom/ClassicScript.cpp

core/dom/ClassicScript.h

core/dom/DocumentModulatorImpl.cpp

core/dom/DocumentModulatorImpl.h

core/dom/DocumentWriteIntervention.cpp

core/dom/DocumentWriteIntervention.h

core/dom/DynamicModuleResolver.cpp

core/dom/DynamicModuleResolver.h

core/dom/DynamicModuleResolverTest.cpp

core/dom/IgnoreDestructiveWriteCountIncrementer.h

core/dom/MockScriptElementBase.h

core/dom/Modulator.cpp

core/dom/Modulator.h

core/dom/ModulatorImplBase.cpp

core/dom/ModulatorImplBase.h

core/dom/ModulatorTest.cpp

core/dom/ModuleImportMeta.h

core/dom/ModuleMap.cpp

core/dom/ModuleMap.h

core/dom/ModuleMapTest.cpp

core/dom/ModulePendingScript.cpp

core/dom/ModulePendingScript.h

core/dom/ModuleScript.cpp

core/dom/ModuleScript.h

core/dom/PendingScript.cpp

core/dom/PendingScript.h

core/dom/ScriptElementBase.cpp

core/dom/ScriptElementBase.h

core/dom/Script.h

core/dom/ScriptLoader.cpp

core/dom/ScriptLoader.h

core/dom/ScriptModuleResolver.h

core/dom/ScriptModuleResolverImpl.cpp

core/dom/ScriptModuleResolverImpl.h

core/dom/ScriptModuleResolverImplTest.cpp

core/dom/ScriptRunner.cpp

core/dom/ScriptRunner.h

core/dom/ScriptRunnerTest.cpp

core/dom/WorkletModulatorImpl.cpp

core/dom/WorkletModulatorImpl.h

core/dom/WorkerModulatorImpl.cpp

core/dom/WorkerModulatorImpl.h

core/html/parser/HTMLParserScriptRunner.h

core/html/parser/HTMLParserScriptRunner.cpp

core/html/parser/HTMLParserScriptRunnerHost.h

core/xml/parser/XMLParserScriptRunner.h

core/xml/parser/XMLParserScriptRunner.cpp

core/xml/parser/XMLParserScriptRunnerHost.h

[Kouhei Ueno]

sgtm. Thanks for driving this work!

--
You received this message because you are subscribed to the Google Groups "loading-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to loading-dev+unsubscribe@chromium.org.
To post to this group, send email to loadi...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/loading-dev/CAOaYce6BZQVka6L%3DZe59EgO8TCCLOOfBzfiai9YB8xy1xN12fQ%40mail.gmail.com.

--

kouhei