Intent to Implement and Ship: display:flow-root

142 views
Skip to first unread message

Robert Hogan

unread,
Jan 8, 2017, 11:32:53 AM1/8/17
to blink-dev
robh...@chromium.org https://drafts.csswg.org/css-display-3/#valdef-display-flow-root display:flow-root generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents. This is intended to make "clearfix" hacks unnecessary. See https://discourse.wicg.io/t/1835/6 for background on the way web developers try to achieve the behaviour of display:flow-root with existing CSS. Firefox: Shipping in Firefox 53. (https://bugzilla.mozilla.org/show_bug.cgi?id=1322191) Edge: No public signals Safari: No public signals Web developers: Positive (See https://discourse.wicg.io/t/1835/6) Low. None. Yes. https://crbug.com/672508 https://www.chromestatus.com/features/5769454877147136 Yes.


Chris Harrelson

unread,
Jan 9, 2017, 7:07:22 PM1/9/17
to Robert Hogan, blink-dev
LGTM1

On Sun, Jan 8, 2017 at 8:32 AM, Robert Hogan <robh...@gmail.com> wrote:
robh...@chromium.org https://drafts.csswg.org/css-display-3/#valdef-display-flow-root display:flow-root generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents. This is intended to make "clearfix" hacks unnecessary. See https://discourse.wicg.io/t/1835/6 for background on the way web developers try to achieve the behaviour of display:flow-root with existing CSS. Firefox: Shipping in Firefox 53. (https://bugzilla.mozilla.org/show_bug.cgi?id=1322191) Edge: No public signals Safari: No public signals Web developers: Positive (See https://discourse.wicg.io/t/1835/6) Low. None. Yes. https://crbug.com/672508 https://www.chromestatus.com/features/5769454877147136 Yes.


--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

TAMURA, Kent

unread,
Jan 15, 2017, 8:25:17 PM1/15/17
to Robert Hogan, blink-dev
Is our implementation interoperable with Firefox? Do we have interoperability tests for this feature?  

On Mon, Jan 9, 2017 at 1:32 AM, Robert Hogan <robh...@gmail.com> wrote:
robh...@chromium.org https://drafts.csswg.org/css-display-3/#valdef-display-flow-root display:flow-root generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents. This is intended to make "clearfix" hacks unnecessary. See https://discourse.wicg.io/t/1835/6 for background on the way web developers try to achieve the behaviour of display:flow-root with existing CSS. Firefox: Shipping in Firefox 53. (https://bugzilla.mozilla.org/show_bug.cgi?id=1322191) Edge: No public signals Safari: No public signals Web developers: Positive (See https://discourse.wicg.io/t/1835/6) Low. None. Yes. https://crbug.com/672508 https://www.chromestatus.com/features/5769454877147136 Yes.





--
TAMURA Kent
Software Engineer, Google


Robert Hogan

unread,
Jan 16, 2017, 1:56:25 PM1/16/17
to TAMURA, Kent, blink-dev
Yes, Firefox developed some tests for their implementation and I've included them in my patch. Hopefully Firefox will get them upstreamed to the CSS test suite at some point and we can then remove our local copy.

Manuel Rego Casasnovas

unread,
Jan 16, 2017, 3:48:41 PM1/16/17
to blin...@chromium.org

On 16/01/17 19:56, Robert Hogan wrote:
> Yes, Firefox developed some tests for their implementation and I've
> included them in my patch <https://codereview.chromium.org/2620623002>.
> Hopefully Firefox will get them upstreamed to the CSS test suite at some
> point and we can then remove our local copy.

If I'm not wrong Firefox doesn't automatically import csswg-test
repository, so I guess they won't upstream that test (at least until
csswg-test repo is merged into wpt).
That's why I suggested we could upstream it by ourselves instead of
adding it manually in the CL. Just a suggestion though.

My 2 cents,
Rego

Rick Byers

unread,
Jan 16, 2017, 3:57:56 PM1/16/17
to Manuel Rego Casasnovas, Robert Hogan, blink-dev, Geoffrey Sneddon, Tab Atkins
Yes I'd prefer we upstream the test case ourselves prior to shipping.

Also CSSWG doesn't want browsers shipping APIs that haven't reached CR, and prior to that has a tendency to make breaking changes without much concern for existing implementations, unless granted an explicit exception. 
 +Tab: how we can we confirm that flow-root is sufficiently stable to ship?

Christian Biesinger

unread,
Jan 17, 2017, 11:02:25 AM1/17/17
to Manuel Rego Casasnovas, L. David Baron, blink-dev
On Mon, Jan 16, 2017 at 3:48 PM, Manuel Rego Casasnovas <re...@igalia.com> wrote:
>
I don't know about those specific tests but Firefox does upstream
certain tests to csswg's vendor-imports directory:
https://github.com/w3c/csswg-test/tree/master/vendor-imports/mozilla/mozilla-central-reftests

Perhaps we could ask them to upstream these tests there -- adding
dbaron for this question. We do have the infrastructure to import
them.

Christian

Rick Byers

unread,
Jan 19, 2017, 1:21:08 PM1/19/17
to Christian Biesinger, Manuel Rego Casasnovas, L. David Baron, blink-dev
Discussed in API owners today.

Given that Firefox has already shipped and Tab's comments on discourse about this, we're OK shipping under the assumption the spec is now stable.  Tab, please correct us if we mis-interpreted us.

LGTM2 from me
LGTM3 from jochen@

Still, although it's not technically required (yet), given that it should be easy we'd like to see the tests upstreamed along with shipping in Chrome.  (All too often we ship stuff and Mozilla folks take our tests and upstream them for us, we shouldn't hesitate to repay the favor).

Robert Hogan

unread,
Jan 20, 2017, 6:36:57 PM1/20/17
to Rick Byers, Christian Biesinger, Manuel Rego Casasnovas, L. David Baron, blink-dev
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Rick Byers

unread,
Jan 20, 2017, 9:29:33 PM1/20/17
to Robert Hogan, Manuel Rego Casasnovas, blink-dev, L. David Baron, Christian Biesinger
Perfect, thanks!

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
Reply all
Reply to author
Forward
0 new messages