Intent to Deprecate: CSSKeyframesRule.insertRule()

106 views
Skip to first unread message

Philip Jägenstedt

unread,
Mar 18, 2015, 4:10:42 AM3/18/15
to blink-dev

Primary eng (and PM) emails

phi...@opera.com


Summary

Deprecate the CSSKeyframesRule.insertRule() in favor of the identical appendRule().

Motivation

The spec has only appendRule():

Compatibility Risk

IE11 implements only CSSKeyframesRule.appendRule(). Gecko has MozCSSKeyframesRule with only appendRule(). WebKit trunk has both CSSKeyframesRule.insertRule() and appendRule().


In other words, content that depends on insertRule() currently will not work in IE or Firefox.


Alternative implementation suggestion for web developers

Try to use CSSKeyframesRule.appendRule(), but fall back to insertRule() as stable Safari doesn't have appendRule() yet.


Usage information from UseCounter

https://www.chromestatus.com/metrics/feature/timeline/popularity/604

https://www.chromestatus.com/metrics/feature/timeline/popularity/605


insertRule() unfortunately has higher usage, but it only reaches 0.0002%.


Entry on chromestatus.com, crbug.com, or MDN

None.


Requesting approval to remove too?

No, let it be deprecated for at least one release cycle.

PhistucK

unread,
Mar 18, 2015, 4:45:27 AM3/18/15
to Philip Jägenstedt, blink-dev
After the experience with the fonts.ready deprecation and transition to a property instead of a method, I believe one release cycle is not enough and the minimal number should be two, or event three.
Since this API is not costly at all to maintain, we can wait two releases before removing and developers could adapt. Bonus points for including the exact version and/or approximate time of stable removal within the message itself.


PhistucK

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Philip Jägenstedt

unread,
Mar 19, 2015, 7:32:22 AM3/19/15
to PhistucK, blink-dev
OK, two release cycles works for me, that's about 3 months on stable, and more time to react for people who use beta/dev/canary.

Philip Jägenstedt

unread,
Mar 19, 2015, 8:15:55 AM3/19/15
to PhistucK, blink-dev
As for including the version and/or time, can you suggest a specific wording? It's hard to predict several releases into the future and the version numbers aren't the same for all products that use Chromium/Blink, notably Opera.

PhistucK

unread,
Mar 19, 2015, 9:00:07 AM3/19/15
to Philip Jägenstedt, blink-dev
Right, so versions do not work here. But starting dates (months) do.
So...
"CSSKeyframesRule.insertRule() was used, which is nonstandard, deprecated and will be removed in the first release after June, 2015. Be sure to update your code to use its standard variant, CSSKeyframesRule.appendRule() instead so it does not break."


PhistucK

Chris Harrelson

unread,
Mar 24, 2015, 11:15:37 AM3/24/15
to PhistucK, Philip Jägenstedt, blink-dev
LGTM

Jochen Eisinger

unread,
Mar 24, 2015, 11:17:26 AM3/24/15
to Chris Harrelson, PhistucK, Philip Jägenstedt, blink-dev
LGTM2

Dimitri Glazkov

unread,
Mar 24, 2015, 12:21:28 PM3/24/15
to Jochen Eisinger, Chris Harrelson, PhistucK, Philip Jägenstedt, blink-dev
LGTM95.
Reply all
Reply to author
Forward
0 new messages