Intent to Implement and Ship: OfflineAudioContext constructor with dictionary

[Raymond Toy]

Contact emails

rt...@chromium.org, hong...@chromium.org

Spec

https://webaudio.github.io/web-audio-api/#OfflineAudioContext

https://webaudio.github.io/web-audio-api/#offlineaudiocontextoptions

Summary

In addition to the existing constructor for an OfflineAudioContext that takes three arguments, add a new constructor taking a single dictionary specifying the necessary options.

Motivation

A while ago, all of the WebAudio nodes were updated to have, in addition to the factory method, a constructor taking a dictionary argument to specify any needed arguments. The exception to this was the OfflineAudioContext which takes three arguments.  For consistency, the spec was updated to allow construction of an OfflineAudioContext using a dictionary argument to specify the number of channels, frames to render and the sample rate.

Interoperability and Compatibility Risk

This is a new addition and we fully expect all browsers to implement this.  Mozilla was involved in the discussion and agreed with adding this.  

Ongoing technical constraints

None.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes.

OWP launch tracking bug

http://crbug.com/737200.

Link to entry on the feature dashboard

https://www.chromestatus.com/feature/5635820090294272

Requesting approval to ship?

Yes.

[Dimitri Glazkov]

LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE3TgXGMVDVWZ8ZnGE8ULRXJz0U3MGmZdcPMTQvPr7z5t20O5w%40mail.gmail.com.

[Rick Byers]

Sounds reasonable to me, but this section of the template is missing:

Is this feature fully tested by web-platform-tests?

Please link to the test suite. If any part of the feature is not tested by web-platform-tests, please include links to issues, e.g.:

• A web-platform-tests issue with the "infra" label explaining why a certain thing cannot be tested. (example)

• A spec issue for some change that would make it possible to test. (example)

• A Chromium issue to upstream some existing tests. (example)

An Intent to Ship requires either a web platform test suite or such issues to be filed explaining why such a test suite is currently impossible or in the progress of being upstreamed.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOtFfx4h%2BvTKW6ZeEWTWHyoPUKYyDhNrOSQV3JbDcjA1xoa0Cw%40mail.gmail.com.

[Raymond Toy]

On Tue, Jul 18, 2017 at 7:52 AM, Rick Byers <rby...@chromium.org> wrote:

Sounds reasonable to me, but this section of the template is missing:

I must be using an older version of the template. (I made a local copy for myself.)

 

Is this feature fully tested by web-platform-tests?

No, not yet.  When we land this change, we will have tests for this in Chrome's LayoutTests.

We are still working on moving Chrome's webaudio tests to WPT (and getting the existing WPT tests to work and pass in Chrome). The hard part of converting Chrome's tests to use testharness is done.  We're now trying to coordinate with Mozilla on how to integrate out respective testsuites into WPT.

 

Please link to the test suite. If any part of the feature is not tested by web-platform-tests, please include links to issues, e.g.:

• A web-platform-tests issue with the "infra" label explaining why a certain thing cannot be tested. (example)

• A spec issue for some change that would make it possible to test. (example)

• A Chromium issue to upstream some existing tests. (example)

An Intent to Ship requires either a web platform test suite or such issues to be filed explaining why such a test suite is currently impossible or in the progress of being upstreamed.

Just filed crbug.com/745778.

[Rick Byers]

On Tue, Jul 18, 2017 at 11:31 AM, Raymond Toy <rt...@chromium.org> wrote:

On Tue, Jul 18, 2017 at 7:52 AM, Rick Byers <rby...@chromium.org> wrote:

Sounds reasonable to me, but this section of the template is missing:

I must be using an older version of the template. (I made a local copy for myself.)

 

Is this feature fully tested by web-platform-tests?

No, not yet.  When we land this change, we will have tests for this in Chrome's LayoutTests.

We are still working on moving Chrome's webaudio tests to WPT (and getting the existing WPT tests to work and pass in Chrome). The hard part of converting Chrome's tests to use testharness is done.  We're now trying to coordinate with Mozilla on how to integrate out respective testsuites into WPT. 

 

Please link to the test suite. If any part of the feature is not tested by web-platform-tests, please include links to issues, e.g.:

• A web-platform-tests issue with the "infra" label explaining why a certain thing cannot be tested. (example)

• A spec issue for some change that would make it possible to test. (example)

• A Chromium issue to upstream some existing tests. (example)

An Intent to Ship requires either a web platform test suite or such issues to be filed explaining why such a test suite is currently impossible or in the progress of being upstreamed.

Just filed crbug.com/745778.

Ok, thanks.  Is it you or someone else who is driving this effort?  Can you assign the bug to whoever that is to make it clear who is accountable for the progress?

LGTM1

[Raymond Toy]

On Tue, Jul 18, 2017 at 12:13 PM, Rick Byers <rby...@chromium.org> wrote:

On Tue, Jul 18, 2017 at 11:31 AM, Raymond Toy <rt...@chromium.org> wrote:

Just filed crbug.com/745778.

Ok, thanks.  Is it you or someone else who is driving this effort?  Can you assign the bug to whoever that is to make it clear who is accountable for the progress?

Yeah, I guess I'm driving this effort.  I assigned myself to the bug now.

We also want to clean up the existing WPT tests. It uses some huge lodash lib that may not really be needed.

[TAMURA, Kent]

LGTM3.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE3TgXE3s5FyztZ-nuymoSz1JnZwo8a9J3aBOt_rFx19cDhjQA%40mail.gmail.com.

--

TAMURA Kent
Software Engineer, Google