Intent to Ship: ImageData constructor

[Sigbjorn Finne]

Contact emails:
sigb...@opera.com

Spec
https://html.spec.whatwg.org/multipage/scripting.html#imagedata

Summary
Create ImageData objects by way of "new".

Link to “Intent to Implement” blink-dev discussion
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FvHQUEXCgEo

Is this feature supported on all six Blink platforms (Windows, Mac,
Linux, Chrome OS, Android, and Android WebView)?
Yes.

Compatibility Risk.
Low; an "API convenience" addition to the ImageData offering that both
Firefox and WebKit has shipped since Spring 2014.

OWP launching bug
http://crbug.com/338804

Link to entry on the feature dashboard
https://www.chromestatus.com/feature/6200618314104832

[Justin Novosad]

Non-owner lgtm

[Philip Jägenstedt]

LGTM, but there are two issues probably worth fixing in the same
release that ships this:

1. Because of [Default=Undefined], the C++
|ImageData::create(DOMUint8ClampedArray* data, unsigned width,
unsigned height, ExceptionState& exceptionState)| cannot differentiate
between the height argument being omitted and being 0, but that
difference is observable per the spec: "If the sh argument was not
omitted, and its value is not equal to height, then throw an
IndexSizeError exception and abort these steps."

2. Add [TypeChecking=Interface] so that null for the Uint8ClampedArray
argument will throw an exception.

Philip

> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+...@chromium.org.

[Chris Harrelson]

LGTM

> email to blink-dev+unsubscribe@chromium.org.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

[Sigbjorn Finne]

Den 1/22/2015 17:08, Philip Jägenstedt skreiv:
> LGTM, but there are two issues probably worth fixing in the same
> release that ships this:
>
> 1. Because of [Default=Undefined], the C++
> |ImageData::create(DOMUint8ClampedArray* data, unsigned width,
> unsigned height, ExceptionState& exceptionState)| cannot differentiate
> between the height argument being omitted and being 0, but that
> difference is observable per the spec: "If the sh argument was not
> omitted, and its value is not equal to height, then throw an
> IndexSizeError exception and abort these steps."
>
> 2. Add [TypeChecking=Interface] so that null for the Uint8ClampedArray
> argument will throw an exception.
>

Thanks,

no need to wait; infelicities were addressed by Blink r188847.

--sigbjorn

[Philip Jägenstedt]

Awesome, thanks for the quick fix. Even more LGTM to ship!

Philip

[Jochen Eisinger]

lgtm3