Intent to Implement and Ship: @supports selector() feature query function

103 views
Skip to first unread message

박중헌

unread,
Oct 6, 2019, 2:46:07 AM10/6/19
to blink-dev
pjh...@gmail.com,jh718...@samsung.com https://github.com/dbaron/css-supports-functions/blob/master/explainer.md Specification: https://drafts.csswg.org/css-conditional-4/#at-supports-ext None. None. This is a simple selector query function that allows to query whether an UA supports a selector. Web authors can use this feature to query whether the UA supports the selector before they actually try to apply the specified style rules matching the selector.
FireFox 69 has shipped this feature: https://bugzilla.mozilla.org/show_bug.cgi?id=1499386 WebKit has a bug page for this feature: https://bugs.webkit.org/show_bug.cgi?id=199237. Chromium has a bug page for this feature: https://bugs.chromium.org/p/chromium/issues/detail?id=979041 Firefox: Shipped (https://bugzilla.mozilla.org/show_bug.cgi?id=1499386) Firefox 69 has shipped this behavior. Edge: No public signals Safari: In development (https://bugs.webkit.org/show_bug.cgi?id=199237) Web developers: No signals None. None. None.
Yes This feature is a CSS feature. Yes https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html https://bugs.chromium.org/p/chromium/issues/detail?id=979041 The 3 tests below is for testing feature query function of css selector. https://github.com/web-platform-tests/wpt/blob/master/css/css-conditional/at-supports-040.html https://github.com/web-platform-tests/wpt/blob/master/css/css-conditional/at-supports-041.html https://github.com/web-platform-tests/wpt/blob/master/css/css-conditional/at-supports-042.html https://www.chromestatus.com/feature/5555643303854080
This intent message was generated by Chrome Platform Status.

Rune Lillesveen

unread,
Oct 7, 2019, 3:39:27 AM10/7/19
to 박중헌, blink-dev
non-OWNER lgtm

On Sun, Oct 6, 2019 at 8:46 AM 박중헌 <pjh...@gmail.com> wrote:

There are certainly more than this single test in wpt?

박중헌

unread,
Oct 7, 2019, 3:58:42 AM10/7/19
to Rune Lillesveen, blink-dev

2019년 10월 7일 (월) 오후 4:39, Rune Lillesveen <fut...@chromium.org>님이 작성:

Daniel Bratell

unread,
Oct 17, 2019, 4:06:54 PM10/17/19
to 박중헌, Rune Lillesveen, blink-dev

Useful. There should have been an explanation why there was no TAG review, but I think I know the standards of that CSS spec to be high enough and with Firefox shipping it a year ago, I see no reason why not to get some improved compatibility. And please do add more wpt tests unless you think those cover enough.

LGTM1

/Daniel

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEmFqRd3eZw7b_aMC5XadBG5tKtb9CjBaSC6-%2B13kCpRsEt4Yw%40mail.gmail.com.

Emilio Cobos Álvarez

unread,
Oct 17, 2019, 8:40:34 PM10/17/19
to blin...@chromium.org

On 10/7/19 9:57 AM, 박중헌 wrote:
> Certainly. AFAIK, there are 3 cases for feature query function of css
> selector.
> While I make a CL for it, I will check whether there are some more wpt
> test cases for this feature.
>
> https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html
> <https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html>
> https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-041.html
> <https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html>
> https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-042.html
> <https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html>

I also added various tests to the existing CSS.supports() tests in
css/cssom/CSS.html, fwiw.

Thanks for implementing this!

-- Emilio

>
> Thank you:)
> Joonghun Park
>
> 2019년 10월 7일 (월) 오후 4:39, Rune Lillesveen <fut...@chromium.org
> <mailto:fut...@chromium.org>>님이 작성:
>
> non-OWNER lgtm
>
> On Sun, Oct 6, 2019 at 8:46 AM 박중헌 <pjh...@gmail.com
> <mailto:pjh...@gmail.com>> wrote:
>
> Contact emails...@gmail.com
> <mailto:pjh...@gmail.com>,jh718...@samsung.com
> <mailto:jh718...@samsung.com>Explainerhttps://github.com/dbaron/css-supports-functions/blob/master/explainer.md
> <https://github.com/dbaron/css-supports-functions/blob/master/explainer.md>Design
> docs/specSpecification:
> https://drafts.csswg.org/css-conditional-4/#at-supports-ext
> <https://drafts.csswg.org/css-conditional-4/#at-supports-ext>Is
> this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?Yes
> https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html
> <https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html>
>
>
> There are certainly more than this single test in wpt?
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEmFqRd3eZw7b_aMC5XadBG5tKtb9CjBaSC6-%2B13kCpRsEt4Yw%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEmFqRd3eZw7b_aMC5XadBG5tKtb9CjBaSC6-%2B13kCpRsEt4Yw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Yoav Weiss

unread,
Oct 18, 2019, 3:56:37 AM10/18/19
to Emilio Cobos Álvarez, blink-dev
LGTM2

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ee2a449f-999a-cf55-4620-6d8f31a6d318%40crisal.io.

Alex Russell

unread,
Oct 24, 2019, 3:44:03 PM10/24/19
to blink-dev, emi...@crisal.io
LGTM3
LGTM2


>         <https://github.com/dbaron/css-supports-functions/blob/master/explainer.md>Design
>         docs/specSpecification:
>         https://drafts.csswg.org/css-conditional-4/#at-supports-ext
>         <https://drafts.csswg.org/css-conditional-4/#at-supports-ext>Is
>         this feature fully tested by web-platform-tests
>         <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?Yes
>         https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html
>         <https://wpt.fyi/results/css/css-conditional?label=master&label=experimental&aligned&q=at-supports-040.html>
>
>
>     There are certainly more than this single test in wpt?
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blin...@chromium.org
> <mailto:blin...@chromium.org>.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.
Reply all
Reply to author
Forward
0 new messages