Is a XHR.getAllResponseHeaders change need any intent process?

48 views
Skip to first unread message

Yutaka Hirano

unread,
Apr 20, 2017, 12:47:37 AM4/20/17
to blink-dev, raphael.ku...@intel.com, Takeshi Yoshino, Mike West, Anne van Kesteren
Hi,

Raphael is proposing a CL which changes XHR.getAllResponseHeaders behavior. With the CL, all header names will be lower-cased. It's a developer-facing change but small, do we need to send any intent (to ship? to change?) for this change?

The change is based on a spec change.

Thanks,

Takeshi Yoshino

unread,
Apr 20, 2017, 1:08:12 AM4/20/17
to Yutaka Hirano, blink-dev, raphael.ku...@intel.com, Mike West, Anne van Kesteren

Rick Byers

unread,
Apr 20, 2017, 1:20:39 AM4/20/17
to Takeshi Yoshino, Yutaka Hirano, blink-dev, raphael.ku...@intel.com, Mike West, Anne van Kesteren
The questions I ask myself to try to decide between bug fix / "trivial" vs. platform change are:
  • Is there a spec and web-platform-test change involved?
  • Is this something this is significant enough that we'd update MDN docs for?
  • Is it reasonable to expect that some (non-trivial number of) web pages might be broken by this change?
I haven't looked deeply into the details here, but big picture we trust blink contributors and their code reviewers to use good judgement here, and it's OK to sometimes get things on the edges wrong in either direction (there's always going to be bug fixes with unintended compat consequences).

Mike West

unread,
Apr 20, 2017, 1:55:59 AM4/20/17
to Rick Byers, Takeshi Yoshino, Yutaka Hirano, blink-dev, raphael.ku...@intel.com, Anne van Kesteren
I'd suggest erring on the side of sending an intent. It doesn't take much more effort than sending a question about whether to send an intent. :)

For this change in particular, it's a developer-visible change in behavior that you could imagine sufficiently brittle code relying on: `x == "Content-Type"` will fail tomorrow when it didn't fail today. I think lowercasing is a reasonable change to make, but it's something we'd also want to tell developers about in one way or another, and evaluate whether other vendors will hop on board.

-mike
Reply all
Reply to author
Forward
0 new messages