API Proposal: feedbackPrivate.readLinesFromFile()

[Simon Que]

Hi,

I would like to add a new function to the feedbackPrivate API that reads lines of text from a log file on Chrome OS.

feedbackPrivate already exposes a function to get a large set of logs from the system. This new function would provide a more flexible logging option during moments when bandwidth is scarce, such as during a video call.

There are proper precautions for:

• security (can only access whitelisted files)
• privacy (can only read whole lines, which are then sanitized for PII)
  

See the API proposal here:

https://docs.google.com/document/d/1cwC9mzI3ISaFzDhcywGEeuoLHD4uyUCs7ahc6ahxC8I/edit

Simon

[Emily Stark]

I see Jorge commented on the doc; security lgtm if he's happy.

[Simon Que]

+Greg Levin has already reviewed it for privacy in a meeting with me.

+Devlin, could you please review the overall change to the Apps/Extensions API?

[Jorge Lucangeli Obes]

On Fri, May 5, 2017 at 11:42 AM, Simon Que <sq...@chromium.org> wrote:

+Greg Levin has already reviewed it for privacy in a meeting with me.

+Devlin, could you please review the overall change to the Apps/Extensions API?

On Fri, May 5, 2017 at 11:34 AM, Emily Stark <est...@chromium.org> wrote:

I see Jorge commented on the doc; security lgtm if he's happy.

Given that:

-Access to the files is RO.

-There's a fixed number of sources and the API can only select between them.

-There's a limit to the number of handles open for a single file.

-And there's a limit to the number of requests per unit of time.

-Things will get anonymized.

I think this is OK.

[Devlin Cronin]

I left a few idl-specific comments in the doc, but overall this LGTM.