Actions for File System Provider API [API update proposal].

8 views
Skip to first unread message

Tomasz Mikolajewski

unread,
May 27, 2015, 7:24:15 PM5/27/15
to apps-dev, security-enamel, Ben Wells, Benjamin Kalman
Hi folks,

I created a one paged for adding two new events to the existing File
System Provider API.
https://docs.google.com/document/d/1S2ZbJF87TGWrBDGp5_Y0IfusWbIT06Z5vkgY9HmocSI/edit

I'd like to ask you for the API change review, so I can go ahead with
the implementation.
The change is fairly simple - it's adding two new events.

The prototype CL is here:
https://codereview.chromium.org/1151763007/

Thanks,
Tomasz

Ben Wells

unread,
May 28, 2015, 9:44:21 PM5/28/15
to Tomasz Mikolajewski, apps-dev, security-enamel, Benjamin Kalman, Mustafa Emre Acer
API lgtm. There might be some details to sort out but we can do that in the CL / document comments.

meacer: any comments from a security perspective?

Tomasz Mikolajewski

unread,
Jun 2, 2015, 4:58:14 AM6/2/15
to Ben Wells, apps-dev, security-enamel, Benjamin Kalman, Mustafa Emre Acer
@meacer: Friendly ping.

Tomasz Mikolajewski

unread,
Jun 6, 2015, 5:34:56 AM6/6/15
to Ben Wells, apps-dev, security-enamel, Benjamin Kalman, Mustafa Emre Acer, Ben Goldsmith
Hi guys. Is there anything we can do to speed up these reviews? It's very frustrating that for each API change we're blocked usually for over 2 weeks.

Mustafa Emre Acer

unread,
Jun 6, 2015, 2:14:02 PM6/6/15
to Tomasz Mikolajewski, Ben Wells, apps-dev, security-enamel, Benjamin Kalman, Ben Goldsmith
Security LGTM.

Sorry for the delay, there is some backlog with the API reviews these days. That said, security reviews become much faster if the proposal includes a section listing security concerns and possible mitigations. Even a "no security concerns" note helps :)

Tomasz Mikolajewski

unread,
Jun 6, 2015, 9:35:44 PM6/6/15
to Mustafa Emre Acer, Ben Wells, apps-dev, security-enamel, Benjamin Kalman, Ben Goldsmith
Thanks Mustafa! Next time I'll fill prepare a security concerns section. Sorry for that!
Reply all
Reply to author
Forward
0 new messages