chrome.tabs.removeCSS - New Chrome API Proposal

Sungguk Lim

unread,

Apr 20, 2017, 1:54:23 PM4/20/17

to apps...@chromium.org, securit...@chromium.org, Devlin Cronin

Hi apps-dev,

Would you review my proposal?

https://docs.google.com/document/d/1rg88OKK88jGqG8Ez971vtjdpBkpuxpHgmQIRTsE89lE/edit?usp=sharing

I didn't add my api on Chrome API tracking master document since I don't have permission.

Thanks in advance.

Devlin Cronin

unread,

Apr 20, 2017, 2:18:22 PM4/20/17

to Sungguk Lim, apps-dev, security-enamel

Overall, this seems pretty reasonable to me. A few nits, but generally fine. Security folks, mind taking a quick look? (Since this only removes CSS already inserted by the extension, I don't think there's any security implications here.)

Mustafa Emre Acer

unread,

Apr 20, 2017, 2:35:47 PM4/20/17

to Devlin Cronin, Sungguk Lim, apps-dev, security-enamel

Looks good to me too, assuming the API will be gated with the same permissions as injectCSS.

--
You received this message because you are subscribed to the Google Groups "apps-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to apps-dev+unsubscribe@chromium.org.

Sungguk Lim

unread,

Apr 21, 2017, 12:15:31 AM4/21/17

to Mustafa Emre Acer, Devlin Cronin, apps-dev, security-enamel

Thanks for the review.

I have slightly updated to reply your comments.

Devlin Cronin

unread,

Apr 24, 2017, 6:34:08 PM4/24/17

to Sungguk Lim, Mustafa Emre Acer, apps-dev, security-enamel

LGTM You're good to start implementing!

Sungguk Lim

unread,

Apr 24, 2017, 6:37:07 PM4/24/17

to Devlin Cronin, Mustafa Emre Acer, apps-dev, security-enamel

Thank you, Devlin.

I started implementing blink side first. I will ping you when ready to review.(or when I have questions :))

To unsubscribe from this group and stop receiving emails from it, send an email to apps-dev+u...@chromium.org.

Reply all

Reply to author

Forward